From nobody Fri Nov 13 18:41:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jR5gb4bdGz7143Y for ; Fri, 13 Nov 2026 18:41:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jR5gb3bdGz4Nsl for ; Fri, 13 Nov 2026 18:41:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794595275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JH9QrfQgLbqeRfi5R7O6GZXaJy45v370XWKlyBR7Sww=; b=vHxwoXqD51VZAJZJDZcCrcENaS+OdzQOOag4aDgsiXnKlCQliCW6rK25H/uV/YyNsyW5IM rblBvgrdDwUkI+Q9HcrbXWcMr8kwCE+6j+C9kyIP7SoyaTCQ/fE2u4qLmT6JcIO6GpawLZ 077CoxWw8b10vzjqooweOjsasmmoTIMedTnCmZKAu2UeQ/XUNoX/1pEmsWh/6emHPGh/wq 0cj1EpmkFMhXx/Ul+p+MfznXa0kK5ydJ4Smttfbe5auVbXyIFygCBhY+yQhIR3PBuE6M3v 3RxtRfHsswVe8hXFn09ijuWhmhDyWD3+XIbasyUDu0ngf5q6EQku1tX46hC8cg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794595275; b=XFTN+ySbkzVAE6emCfIjNMhfDRIBvxkKVFiCvXakmlftMy/5p90B/14ERb0b3Ay2EuO9wY OJcbNlFTdty74ifMrNDGB/cLUieYfh624roQ2wXz53dsHIq/AAC8iYk213KwJNK39IoP4s 3M61ofIc2kRCvB8mcYbSNXr85+ApjtFnZFyVnSr/nVY+ApFfm0Wq1u1KPl90FKHNMFtTCe ID2WsJCoLU4WEpNmL0lxV7u4pco4afejkFr0yTl//5HEa3Up9U3CV6Qs9emwtm3cHhjsHt BCOAbS21k1IQr2KFvwWaeh9loluPYzwVWRhx2y7R8WLc5RRWJ4tlOamm7NSSJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794595275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JH9QrfQgLbqeRfi5R7O6GZXaJy45v370XWKlyBR7Sww=; b=wEWpf/DmeqSJfhLHjJXK3ppkJ8eyrS+deUpFFN2aonzsKCXjD6N6QOe2YJcQkTDE3dAb1x 3UhZWjmmY+v5H8kHv7rwPbasT4lwmuK+KQXj8NnNmLppoXh7gCi7bKxIm9jv+UgiqAvwrM RqTGye421FE4quvRHboEsJAygGkz21HiGy0BOUpoliZX6YBx0LHjxdMl7DcTEMPWel3Rel WRe1eADDslBjfmXdwqQjytCHMVQFiqfwaH0pG0rfQ1PGBaodu+Jdk0Am/bjbmo19rhgION 0+OoIcgsw5moz+zl2ctbLzWucKKaj7EWQ6MjrzX4BWg91ZMJZL5ivslC9OVsRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jR5gb2vZ9znT3 for ; Fri, 13 Nov 2026 18:41:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f82f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Nov 2026 18:41:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mitchell Horne Subject: git: a4d5853c6734 - stable/14 - amd64: use pc_is_full() helper function List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a4d5853c673494c8c502728daafe2e1d08445aa1 Auto-Submitted: auto-generated Date: Fri, 13 Nov 2026 18:41:15 +0000 Message-Id: <6af759cb.1f82f.78f5a5bd@gitrepo.freebsd.org> The branch stable/14 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=a4d5853c673494c8c502728daafe2e1d08445aa1 commit a4d5853c673494c8c502728daafe2e1d08445aa1 Author: Mitchell Horne AuthorDate: 2024-07-09 18:43:33 +0000 Commit: Mitchell Horne CommitDate: 2026-11-13 18:41:02 +0000 amd64: use pc_is_full() helper function This seems to have been missed in a few places. No functional change intended. Reviewed by: kib MFC after: 1 week Fixes: 4d90a5afc51b ("sys: Consolidate common implementation details...") Differential Revision: https://reviews.freebsd.org/D45920 (cherry picked from commit e7f849e25bbca9a74c9d3a5b633f9cd01ba95a55) --- sys/amd64/amd64/pmap.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/amd64/amd64/pmap.c b/sys/amd64/amd64/pmap.c index af0bb5cea262..1ffadd8283b2 100644 --- a/sys/amd64/amd64/pmap.c +++ b/sys/amd64/amd64/pmap.c @@ -5595,8 +5595,7 @@ retry: pv = &pc->pc_pventry[field * 64 + bit]; pc->pc_map[field] &= ~(1ul << bit); /* If this was the last item, move it to tail */ - if (pc->pc_map[0] == 0 && pc->pc_map[1] == 0 && - pc->pc_map[2] == 0) { + if (pc_is_full(pc)) { TAILQ_REMOVE(&pmap->pm_pvchunk, pc, pc_list); TAILQ_INSERT_TAIL(&pmap->pm_pvchunk, pc, pc_list); @@ -5807,8 +5806,7 @@ pmap_pv_demote_pde(pmap_t pmap, vm_offset_t va, vm_paddr_t pa, va_last = va + NBPDR - PAGE_SIZE; for (;;) { pc = TAILQ_FIRST(&pmap->pm_pvchunk); - KASSERT(pc->pc_map[0] != 0 || pc->pc_map[1] != 0 || - pc->pc_map[2] != 0, ("pmap_pv_demote_pde: missing spare")); + KASSERT(!pc_is_full(pc), ("pmap_pv_demote_pde: missing spare")); for (field = 0; field < _NPCM; field++) { while (pc->pc_map[field]) { bit = bsfq(pc->pc_map[field]); @@ -5829,7 +5827,7 @@ pmap_pv_demote_pde(pmap_t pmap, vm_offset_t va, vm_paddr_t pa, TAILQ_INSERT_TAIL(&pmap->pm_pvchunk, pc, pc_list); } out: - if (pc->pc_map[0] == 0 && pc->pc_map[1] == 0 && pc->pc_map[2] == 0) { + if (pc_is_full(pc)) { TAILQ_REMOVE(&pmap->pm_pvchunk, pc, pc_list); TAILQ_INSERT_TAIL(&pmap->pm_pvchunk, pc, pc_list); }