git: 39b97c10e6d0 - main - if_geneve: Ignore reserved bits on receive
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 13 Nov 2026 11:42:43 UTC
The branch main has been updated by pouria:
URL: https://cgit.FreeBSD.org/src/commit/?id=39b97c10e6d0ed21f65bf0cb8bd8e359c2c2d8d3
commit 39b97c10e6d0ed21f65bf0cb8bd8e359c2c2d8d3
Author: Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
AuthorDate: 2026-11-13 11:35:13 +0000
Commit: Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
CommitDate: 2026-11-13 11:41:56 +0000
if_geneve: Ignore reserved bits on receive
RFC 8926 section 3.4 requires the reserved fields of geneve header
to be ignored on receipt.
While here, remove the needless htons() from the version check, as
geneve_ver is a 2-bit bitfield with no byte order.
Fixes: e44d2e941e8e ("if_geneve: Add Support for Geneve (RFC8926)")
---
sys/net/if_geneve.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sys/net/if_geneve.c b/sys/net/if_geneve.c
index c7571984c4cf..e13075ec583d 100644
--- a/sys/net/if_geneve.c
+++ b/sys/net/if_geneve.c
@@ -123,7 +123,6 @@ struct geneve_socket_mc_info {
#define GENEVE_BASIC_IFCAPS (IFCAP_LINKSTATE | IFCAP_JUMBO_MTU | IFCAP_NV)
#define GENEVE_VERSION 0
-#define GENEVE_VNI_MASK (GENEVE_VNI_MAX - 1)
#define GENEVE_HDR_VNI_SHIFT 8
@@ -3005,8 +3004,7 @@ geneve_udp_input(struct mbuf *m, int offset, struct inpcb *inpcb,
* Drop if there is a reserved bit or unknown version set in the header.
* As defined in RFC 8926 3.4
*/
- if (gnvh->geneve_ver != htons(GENEVE_VERSION) ||
- gnvh->geneve_vni & ~GENEVE_VNI_MASK)
+ if (gnvh->geneve_ver != GENEVE_VERSION)
return (false);
/*