From nobody Fri Nov 13 10:07:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQtGK2n6pz70PWj for ; Fri, 13 Nov 2026 10:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQtGK0bbsz5088 for ; Fri, 13 Nov 2026 10:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794564425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KAjJpdaCJJmfA9BJ6NAsOmyGQqyWEgo6asiVM1LCWAQ=; b=thpPMd9YkzdyfgTaxii9vtVS9zL6cc05z+UZYvBkAtyc4lRJ4Wz67WMCLb081EJ1Zi6Bdp s5g25j1q37baS125mamB2oAV1NU6+Bj6t/KG0twofblaMLAiirKY4kvKxj4Cv+C7gFAA/K nlq/B0Q4dId+AKFxRNUQXY+gxz+6n9QIAFXcX38MNIU9X77Eoe7WGIjB4f2CPiUVCGoA0w uaZO4CvnXjUk74QHs/w+Kekd9htwqI5W8gT5p6MofOop8F85qkkjAR9Gj+XJAq5sF+4JHC 2MeXlcrLTtaS3SdZw+bR2ZvmHvHzzo/3TgZmZoLXXwtwv/LiddDgs9Q0NhgxTg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794564425; b=xCqeL+MCFO+UvZzWuBm1XydpOTEXcfeCPKIu6XYyLovbQAmzUgXM5hfIekX2R30hZbcxB8 aHqdkieYhsCPF3XzqHrjKYr1R5HY62vXo96EdOUXeFMPW+0dscs1tWWErkVkaq+Cx6/fCT GXQ+bUw2pAe/LxK2+V9xMp7Xni3lcCSVqhD4UDSlfoaI9bPpfnBe0bDO3UrwHUfa8LngAU twOBkvto5RhXUH/cxpFiUXwgHmSiM2fro67sfTBAWZF5/3+/ZGTlbnn6O6OZuD0Cw7SY9Y jjQXNqWnJJ11xh5OY2IVnsVReyMhPv+h4nNLmNdDm5acneIN+hugPb/VvWruyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794564425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KAjJpdaCJJmfA9BJ6NAsOmyGQqyWEgo6asiVM1LCWAQ=; b=UDETTIBkZSLl3Y9HaRVZCSMOrbwiSzDk+Nkr82uITEDXa9S2psAWwgn9zb+JZdRGX5j/gY nD+OpUpATYXRbVDgraHQbECRTgoY5kOsVMXU0UCOgtpLKGEANChwiwTbkb1chUGfIHR6sX coszFsAls/CL2HEnFXyadx+oHrOCjxzlwpJqrtei/z1ekEWxTJ7jVekzje//0mCMw2B+er 56rieD9h8BDJp3ivCoFo8K4ou4EDbhJBmxAwbuh5Ojblepmj/s9qKLPAH7fOKm5ZtuvdOd pmtKFnvD/Cq93S5SPWclX5FJ8ifQN9zQarTfxnXaZ0YrRUoLoN8K3RK17UP9lw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQtGK0Gs7zStt for ; Fri, 13 Nov 2026 10:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id a0ac by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Nov 2026 10:07:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: 118067f51c11 - main - extattr_list*: avoid panic with absurd buffer lengths List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 118067f51c111390dbc54760d781cd14a10c499e Auto-Submitted: auto-generated Date: Fri, 13 Nov 2026 10:07:05 +0000 Message-Id: <6af6e149.a0ac.2afc75f1@gitrepo.freebsd.org> The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=118067f51c111390dbc54760d781cd14a10c499e commit 118067f51c111390dbc54760d781cd14a10c499e Author: Brooks Davis AuthorDate: 2026-11-13 10:06:52 +0000 Commit: Brooks Davis CommitDate: 2026-11-13 10:06:52 +0000 extattr_list*: avoid panic with absurd buffer lengths Apply a layered defence: - Reject nbytes > IOSIZE_MAX in user_extattr_list_fd and user_extattr_list_path. - In extattr_list_vp require auiop->uio_resid to be non-negative. Effort: CHERI upstreaming Reviewed by: markj Reported by: llm-postcr MFC after: 3 days Sponsored by: Innovate UK Fixes: 6453d4240f6b ("vfs: Export exattr methods to reuse by Linuxulator") Differential Revision: https://reviews.freebsd.org/D61461 --- sys/kern/vfs_extattr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/kern/vfs_extattr.c b/sys/kern/vfs_extattr.c index 70da1cdf56e2..e5a087bc0fff 100644 --- a/sys/kern/vfs_extattr.c +++ b/sys/kern/vfs_extattr.c @@ -737,7 +737,7 @@ extattr_list_vp(struct vnode *vp, int attrnamespace, struct uio *auiop, sizep = NULL; cnt = 0; if (auiop != NULL) { - if (auiop->uio_resid > IOSIZE_MAX) + if (auiop->uio_resid < 0 || auiop->uio_resid > IOSIZE_MAX) return (EINVAL); cnt = auiop->uio_resid; } else @@ -787,6 +787,9 @@ user_extattr_list_fd(struct thread *td, int fd, int attrnamespace, void *data, struct uio auio, *auiop; struct iovec aiov; + if (nbytes > IOSIZE_MAX) + return (EINVAL); + if (data != NULL) { aiov.iov_base = data; aiov.iov_len = nbytes; @@ -870,6 +873,9 @@ user_extattr_list_path(struct thread *td, const char *path, int attrnamespace, struct uio auio, *auiop; struct iovec aiov; + if (nbytes > IOSIZE_MAX) + return (EINVAL); + if (data != NULL) { aiov.iov_base = data; aiov.iov_len = nbytes;