git: 770d272d871f - main - allwinner: h616: Put the PI pins in bank 8

From: Emmanuel Vadot <manu_at_FreeBSD.org>
Date: Fri, 13 Nov 2026 07:29:52 UTC
The branch main has been updated by manu:

URL: https://cgit.FreeBSD.org/src/commit/?id=770d272d871fd99e1d6c2489eab5a60cefccc9a3

commit 770d272d871fd99e1d6c2489eab5a60cefccc9a3
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2026-11-13 06:50:12 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2026-11-13 07:29:30 +0000

    allwinner: h616: Put the PI pins in bank 8
    
    The PI0 to PI16 entries of the pad table had port 9 and interrupt bank 9
    but the PI bank is the ninth one, bank 8, at offset 0x120.  Bank 9 is a
    bank that does not exist, so the configuration, data, drive and pull of
    these pins, and their interrupt registers, were accessed at the wrong
    place and a <&pio 8 N> specifier, like the one of the card detect GPIO
    of some boards, did not find its pin.
    
    Use 8 for the port and the interrupt bank, like the other entries do
    with the position of their letter.
    
    Reported by:    llm-postcr
    Fixes:          e506af08bb52 ("aw_gpio: Add support for H616")
---
 sys/arm/allwinner/h616/h616_padconf.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/sys/arm/allwinner/h616/h616_padconf.c b/sys/arm/allwinner/h616/h616_padconf.c
index 03a616875e59..c3f964126c1a 100644
--- a/sys/arm/allwinner/h616/h616_padconf.c
+++ b/sys/arm/allwinner/h616/h616_padconf.c
@@ -79,23 +79,23 @@ static const struct allwinner_pins h616_pins[] = {
 	{ "PH9",  7,  9, { "gpio-in", "gpio_out",    NULL, "i2s3",          "spi1", "i2s3", "ph_eint9" },  6,  9, 7 },
 	{ "PH10", 7, 10, { "gpio-in", "gpio_out",    NULL, "cir_rx",  "tcon_trig1",   NULL, "ph_eint10" }, 6, 10, 7 },
 
-	{ "PI0",  9,  0, { "gpio-in", "gpio_out",    "rgmii",   "dmic_clk", "i2s0", "hdmi"        ,  "pi_eint0" }, 6,  0, 9 },
-	{ "PI1",  9,  1, { "gpio-in", "gpio_out",    "rgmii", "dmic_data0", "i2s0", "hdmi"        ,  "pi_eint1" }, 6,  1, 9 },
-	{ "PI2",  9,  2, { "gpio-in", "gpio_out",    "rgmii", "dmic_data1", "i2s0", "hdmi"        ,  "pi_eint2" }, 6,  2, 9 },
-	{ "PI3",  9,  3, { "gpio-in", "gpio_out",    "rgmii", "dmic_data2", "i2s0", "i2s0"        ,  "pi_eint3" }, 6,  3, 9 },
-	{ "PI4",  9,  4, { "gpio-in", "gpio_out",    "rgmii", "dmic_data3", "i2s0", "i2s0"        ,  "pi_eint4" }, 6,  4, 9 },
-	{ "PI5",  9,  5, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi0"        ,  "pi_eint5" }, 6,  5, 9 },
-	{ "PI6",  9,  6, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi0"        ,  "pi_eint6" }, 6,  6, 9 },
-	{ "PI7",  9,  7, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi1"        ,  "pi_eint7" }, 6,  7, 9 },
-	{ "PI8",  9,  8, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi1"        ,  "pi_eint8" }, 6,  8, 9 },
-	{ "PI9",  9,  9, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "spi2"        ,  "pi_eint9" }, 6,  9, 9 },
-	{ "PI10", 9, 10, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "spi2"        , "pi_eint10" }, 6, 10, 9 },
-	{ "PI11", 9, 11, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "pwm1"        , "pi_eint11" }, 6, 11, 9 },
-	{ "PI12", 9, 12, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "pwm2"        , "pi_eint12" }, 6, 12, 9 },
-	{ "PI13", 9, 13, { "gpio-in", "gpio_out",    "rgmii",      "uart4",  "ts0", "pwm3"        , "pi_eint13" }, 6, 13, 9 },
-	{ "PI14", 9, 14, { "gpio-in", "gpio_out",      "mdc",      "uart4",  "ts0", "pwm4"        , "pi_eint14" }, 6, 14, 9 },
-	{ "PI15", 9, 15, { "gpio-in", "gpio_out",     "mdio",      "uart4",  "ts0", "clk_fanout0" , "pi_eint15" }, 6, 15, 9 },
-	{ "PI16", 9, 16, { "gpio-in", "gpio_out", "ephy_25m",      "uart4",  "ts0", "clk_fanout1" , "pi_eint16" }, 6, 16, 9 },
+	{ "PI0",  8,  0, { "gpio-in", "gpio_out",    "rgmii",   "dmic_clk", "i2s0", "hdmi"        ,  "pi_eint0" }, 6,  0, 8 },
+	{ "PI1",  8,  1, { "gpio-in", "gpio_out",    "rgmii", "dmic_data0", "i2s0", "hdmi"        ,  "pi_eint1" }, 6,  1, 8 },
+	{ "PI2",  8,  2, { "gpio-in", "gpio_out",    "rgmii", "dmic_data1", "i2s0", "hdmi"        ,  "pi_eint2" }, 6,  2, 8 },
+	{ "PI3",  8,  3, { "gpio-in", "gpio_out",    "rgmii", "dmic_data2", "i2s0", "i2s0"        ,  "pi_eint3" }, 6,  3, 8 },
+	{ "PI4",  8,  4, { "gpio-in", "gpio_out",    "rgmii", "dmic_data3", "i2s0", "i2s0"        ,  "pi_eint4" }, 6,  4, 8 },
+	{ "PI5",  8,  5, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi0"        ,  "pi_eint5" }, 6,  5, 8 },
+	{ "PI6",  8,  6, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi0"        ,  "pi_eint6" }, 6,  6, 8 },
+	{ "PI7",  8,  7, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi1"        ,  "pi_eint7" }, 6,  7, 8 },
+	{ "PI8",  8,  8, { "gpio-in", "gpio_out",    "rgmii",      "uart2",  "ts0", "spi1"        ,  "pi_eint8" }, 6,  8, 8 },
+	{ "PI9",  8,  9, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "spi2"        ,  "pi_eint9" }, 6,  9, 8 },
+	{ "PI10", 8, 10, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "spi2"        , "pi_eint10" }, 6, 10, 8 },
+	{ "PI11", 8, 11, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "pwm1"        , "pi_eint11" }, 6, 11, 8 },
+	{ "PI12", 8, 12, { "gpio-in", "gpio_out",    "rgmii",      "uart3",  "ts0", "pwm2"        , "pi_eint12" }, 6, 12, 8 },
+	{ "PI13", 8, 13, { "gpio-in", "gpio_out",    "rgmii",      "uart4",  "ts0", "pwm3"        , "pi_eint13" }, 6, 13, 8 },
+	{ "PI14", 8, 14, { "gpio-in", "gpio_out",      "mdc",      "uart4",  "ts0", "pwm4"        , "pi_eint14" }, 6, 14, 8 },
+	{ "PI15", 8, 15, { "gpio-in", "gpio_out",     "mdio",      "uart4",  "ts0", "clk_fanout0" , "pi_eint15" }, 6, 15, 8 },
+	{ "PI16", 8, 16, { "gpio-in", "gpio_out", "ephy_25m",      "uart4",  "ts0", "clk_fanout1" , "pi_eint16" }, 6, 16, 8 },
 };
 
 const struct allwinner_padconf h616_padconf = {