From nobody Thu Nov 12 23:41:49 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQcNs5xmyz6xnFm for ; Thu, 12 Nov 2026 23:41:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQcNs58n9z4Rn3 for ; Thu, 12 Nov 2026 23:41:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794526909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0AZZw4Ad/gV+ceb6sPe/ky6ntKl5PMQZcG1Z54UJk10=; b=FX9q9Syp4KK1xRulyCRacRCdSLwrrfsxfvcx02wFtnNOVxaUoMDoiM8MBZodDCIpUA2Eq2 07Q+W5B0P6BHafIRYF+3TQvJlmN4R0DQMPNk9Ymteb5cW9pcdA74URggS6fCac2/t5MWSv 7vO6aXX4UV/N4qz4r0XupzexYNUzeYRxqJ43VUqXEjt6FGxBGy/ewHEdx1qSuD1ulTJXvm 9dx1JMGDozoB+5MLDWI5+qLS0T0cs+e5LqeZl/bRPXDR0rLMk6bdKr4DPaEwSv1LYPuwFT zJDtdqCFNKuM2nKVOJ2YyRKR64xT2DDthRBCnofbJBTjxyfIh7jFhri5mCLRyQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794526909; b=dNCqCq9W6ugaMUralOpty4pJ/FmJWqvMvuTE3jVZNztXMsYSX9hPo1nl1LxN986CTNgidq YQX/ScEcUb0oqoeRnGb91wtRDHSLoPraD2sZoixkL/s7Rm7+lbUoN5bLg2XkBUI5rE0TH9 WvRUaG2PmvUkUn5gpFwmKvc6JZDEzLNTXZpCQxOSI1ZezBRxJJlCBrbESgC6vXxHyliq2+ uUyPLR/a6B286fMcmdC8ZhgTGcodV7SQHxBc0adB05YT5y+1GxdskXdozHhFIIywxe1L9r VSnTw171J8iG4H5gBAO0QTlyeOu8/WnXeti64d9/BSHC0VwuU0vZeJollH3LPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794526909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0AZZw4Ad/gV+ceb6sPe/ky6ntKl5PMQZcG1Z54UJk10=; b=xAp17hw6mGzIETybqo5RY1Zg5MuDdVorjqSj6aHFE1RViU4RZrcgR6ve8HFjtYPTkxg/Ba yuylVLpcBMPlQoxQCVW2UxPGSv5WGdihdJs7l1fB2mhTC9t3csUSAVaZbRR/LiiSWXMEbH E4mC8EP00AQfrJ6hzLHzjXVF74mzJO1doNaqYO0P/s5TO2Q9IRuiwM+fiumtn3GdJ4wK0I RWWnCDFU9MX2Ogge5z0KkYRQ1pOpo1tHdJwnOJie5o2zaUQ4ygllm7R8igh5hPEAInNoIa 8X3bPQvjZsf8pyd1ei71IRKdlMZo+FW7BDqTZDLKruhi5Wwlo3zU7+usxnlSKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQcNs4XnRz1NV5 for ; Thu, 12 Nov 2026 23:41:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id e1e5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 23:41:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Xin LI From: Colin Percival Subject: git: 908d6b206607 - releng/15.2 - mqueuefs: set *a_eofflag in VOP_READDIR List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.2 X-Git-Reftype: branch X-Git-Commit: 908d6b206607e7f4b37ae4aa87aaaa23e697d112 Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 23:41:49 +0000 Message-Id: <6af64ebd.e1e5.2610952d@gitrepo.freebsd.org> The branch releng/15.2 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=908d6b206607e7f4b37ae4aa87aaaa23e697d112 commit 908d6b206607e7f4b37ae4aa87aaaa23e697d112 Author: Xin LI AuthorDate: 2026-11-03 03:02:03 +0000 Commit: Colin Percival CommitDate: 2026-11-12 23:41:04 +0000 mqueuefs: set *a_eofflag in VOP_READDIR mqfs_readdir() never reported end of directory. Since 77b273d8f5f4 VOP_READDIR_APV() asserts that a readdir which returns no entries also sets *a_eofflag, so with INVARIANTS the final zero-length getdirentries(2) that ls(1) issues on a mounted mqueuefs panics: panic: VOP_READDIR: eofflag not set Report end of directory when the child list was walked to its end; leave the flag clear when the walk stopped because the buffer was full. Approved by: re (cperciva) (cherry picked from commit fbac0abdc5ab1fe867ac85635662ef06b2ee9d10) (cherry picked from commit 6df22096ddb27edb169cfb6758d1dab130f9f683) --- sys/kern/uipc_mqueue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/uipc_mqueue.c b/sys/kern/uipc_mqueue.c index e26a21a6efe0..1c3eb9776eda 100644 --- a/sys/kern/uipc_mqueue.c +++ b/sys/kern/uipc_mqueue.c @@ -1459,6 +1459,8 @@ mqfs_readdir(struct vop_readdir_args *ap) sx_xunlock(&mi->mi_lock); uio->uio_offset = offset; + if (ap->a_eofflag != NULL) + *ap->a_eofflag = (pn == NULL); if (tmp_ncookies != NULL) ap->a_ncookies = tmp_ncookies;