From nobody Thu Nov 12 21:55:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQZ2N759vz71LSM for ; Thu, 12 Nov 2026 21:55:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQZ2N6MSWz4GTh for ; Thu, 12 Nov 2026 21:55:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794520540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ATGPsEF5dPfCPbgpKQJAGy3DUimK3RvI6CCHGFgmGvI=; b=rYoDnQnSJwUWabxquWTQEVGwiIDiWe9vd4+D5HB4KDt3fqFOZUKmJKCqHRekxbRUnr1Ruu i6cwWHRH7nDeS3x1xmupwv6h4YmBrv+72xLyAsENuO7+GGrnN479nMfHP4sbixsd6FhIHU 5BXR2+gaiEjqg4/7fMU88bYoBD4T7iiLqX6RWX3Vbjmj4StC6k74odgMRFmE18Tm7TYgdk 3Y92VUh5EUlyLTiCQdKRx8PB5f406B4RCnnWVSdNNZ6okIjtqZnKgphLXG6fI8jUDBL9PC bUznKObnJaHNeB1P1KvnEPr4rUtyXfzm4mnfkvXCzW13FZ08Nv63O5eJN2mumQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794520540; b=P59gPN4dWNIXjjmd5rqntSgykgKoCu3xHgIwE3pbyInBwq3tqsWnIB7zFRcbyhftoZuOxU ihfHexfVhy76oWDBX6Bw50ZN/34S/cavR0GKi/7AcWBRbbvfUd23bbLBo18UaFyDeWWvxB rEPmuxCj7biaS9eAiefhcRKwmR5Va15g0LStsGxR1v749hu/tIvEOPuQw7cKIBnW8XklPI DbfxhmUg2A+eC4XzghzoQwK5ScPDe1iTxDLazyZPaW5LkrATwyCWZbY3iVMnCfIz+et5LJ TWSQVTv47PvWq/2tmsBY0sD6XIE8sJyQVbFU5XvQV/juAP57LrE6lNmIQLn/Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794520540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ATGPsEF5dPfCPbgpKQJAGy3DUimK3RvI6CCHGFgmGvI=; b=e78ACud/zw0EzJ92LoUTtDUK5XoXJDmZ7yp9rWy51/VJBWNA+2OaFFJg/AMKKowdlyQ7rE myotyx2DnxilLknxo1vN0KJGtDk/J+ZPCRRXPGk/6JiWPFAd9fNGeuoXCj3ozmtL4u1hra uu0x7UGsMtqpT+u7nqtiA0GxeVI10k1DeDF2FMxKYLx81r1c7CA9pO+Eywv2AhU7ZEy1iH MH/2VMx8eBA1o/IgCdfRRkSmRch6GQ5qbPm1U4i+4aVHZfGjo51rtMRCW29pgBH+ue29zY B6Th+Cw+4hqdmXK+PLLYL++1+/XFWin2MaEmYhCHsF/cDNd25jUgj33a5zoWGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQZ2N5kPqz1KYT for ; Thu, 12 Nov 2026 21:55:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4ed5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 21:55:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: efa14ab698fe - main - routing: Fix nhop double free in rib_copy_route() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: efa14ab698fe5c3a1586aec006f98e3781f4af78 Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 21:55:40 +0000 Message-Id: <6af635dc.4ed5.314b2e97@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=efa14ab698fe5c3a1586aec006f98e3781f4af78 commit efa14ab698fe5c3a1586aec006f98e3781f4af78 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-11-12 21:34:06 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-11-12 21:48:57 +0000 routing: Fix nhop double free in rib_copy_route() add_route_flags() consumes the nexthop reference on every failure path, so nhop_free() in rib_copy_route() releases it for the second time. This is reachable when growing net.fibs while two existing fibs hold the same pinned prefix. MFC after: 3 days Fixes: 40503b792f7e ("routing: populate fibs with interface...") --- sys/net/route/route_ctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/net/route/route_ctl.c b/sys/net/route/route_ctl.c index ef58a2845424..4fd961689576 100644 --- a/sys/net/route/route_ctl.c +++ b/sys/net/route/route_ctl.c @@ -657,7 +657,6 @@ rib_copy_route(struct rtentry *rt, const struct route_nhop_data *rnd_src, FIB_RH_LOG(LOG_DEBUG, rh_dst, "Unable to add route %s: error %d", buf, error); } - nhop_free(nh); } return (error); }