From nobody Thu Nov 12 16:38:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQR0D2gbxz70sWc for ; Thu, 12 Nov 2026 16:38:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQR0C6lXrz4JfY for ; Thu, 12 Nov 2026 16:38:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794501499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NOZ6dTryneZ00PJinGRAK0G7a9gdI8dT2SVr0mlYI/8=; b=Ckh/q1E7XyKrM1gqhLdHI8KqGRN3J4FczYsq+yeN+Sj/m5OUJkJEiHf/VbWOvzCqqE3+Nd Ei67zqH1hPgCU8blUDopMpPTHrGYPgSSEc7V8g2Pe7gj0WowrxvCEpv1xydJiu26q/1eaa hI13maQ7kaXrgFsZV9yW+zVu1YEX5xqGZLyHLYZSLSYfjeFdQUFO0jXVVgLhwCeMHjRrx5 fz/uMfm9DvUHrN6D7SlRx4TFe79u+mWuhtbt/8jXHk8evskd249QavfsGcmaGG5Hk0z4nm U+D8xH2i/+4tw+3egBT4JCL4Uomha4RTI3EV5AO2TXAU0DiDBzQFs3qTDDliDg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794501500; b=yPWsLKRd/khbTXGl0EztJLPoiCQsBdK5twoQFzCzqXnpYDMAbm6y4KywcvqW3vmxg8u4Z6 yNsKyEwziHHgV+EESqNByn7XJHA0ffpbjQTYzM3kqE+k7HA9EvgXiMqpfniPcWFriP34xI piTOOO7nGnZpNF3As79p8MxNJqi6e0ekZEQkCInNIR7W7TdNWIyVfBjloI7n9UQ6eimuqF hh3V83/FdpkNBbJg3QgQBB9kGvCoBm9D4lSy12uXyhj5ntJDB1ugYQmzp1XUKVNmJ56x9v 2IMbvqoSR888vfMSiJ5twWCyWlXDuQS8W+PWP3asbmUziCOTsNptpYj1ptdDDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794501499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NOZ6dTryneZ00PJinGRAK0G7a9gdI8dT2SVr0mlYI/8=; b=OvN5MZvg3mO6+Td0mTs/IRUOrlkIuLNqt/+EVbAlrGX8DWLPavVVYQN6l2puw53LjAY24y LkXkdSlh49cLB4yIHG3P3H5IqIT3L/5GcMZwgHTd/m/ZOJP5H+/ycU4GgbPvr2b7lcc/ib kYf6xg3OxLbKkAGeOcsFdu3VazdT6caEOtdBMD0aT1XUcZwi+cY4v6nWsUDqT79qHizElU TJUquXhOyg6fnvXA/DoR5oquewoK3+j0g5uQLbWnnlPwigG2L48Q7D7wjGBpfnRZHdlPAj CNWSqN2DYGsw4P24Kotr+bRYMiSyuclX/Y8j9P8JMl9VjXQdCX7jeXKmxhV/7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQR0C5qJWz18vq for ; Thu, 12 Nov 2026 16:38:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3719 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 16:38:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 3fc4d02c4b02 - main - sound/midi: Pair kobj_init() with kobj_delete() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3fc4d02c4b02e1af0627720597352965ad87eb02 Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 16:38:19 +0000 Message-Id: <6af5eb7b.3719.27e9db4d@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=3fc4d02c4b02e1af0627720597352965ad87eb02 commit 3fc4d02c4b02e1af0627720597352965ad87eb02 Author: Christos Margiolis AuthorDate: 2026-11-12 10:40:55 +0000 Commit: Christos Margiolis CommitDate: 2026-11-12 16:35:49 +0000 sound/midi: Pair kobj_init() with kobj_delete() kobj_init() bumps the class refcount, so without a matching kobj_delete() it never drops to zero. MFC after: 1 week Sponsored by: The FreeBSD Foundation --- sys/dev/sound/midi/midi.c | 4 ++-- sys/dev/sound/midi/mpu401.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/sound/midi/midi.c b/sys/dev/sound/midi/midi.c index 694df4ef6aa7..790fdc05feac 100644 --- a/sys/dev/sound/midi/midi.c +++ b/sys/dev/sound/midi/midi.c @@ -134,7 +134,7 @@ midi_destroy(struct snd_midi *m) free(m->inq.buf, M_MIDI); free(m->outq.buf, M_MIDI); mtx_destroy(&m->lock); - free(m, M_MIDI); + kobj_delete((kobj_t)m, M_MIDI); } /* @@ -157,7 +157,7 @@ midi_init(kobj_class_t cls, void *cookie) outqsize = MPU_OUTQSIZE(m, cookie); if (!inqsize && !outqsize) { - free(m, M_MIDI); + kobj_delete((kobj_t)m, M_MIDI); return (NULL); } diff --git a/sys/dev/sound/midi/mpu401.c b/sys/dev/sound/midi/mpu401.c index 81ab529262e3..4c070952b595 100644 --- a/sys/dev/sound/midi/mpu401.c +++ b/sys/dev/sound/midi/mpu401.c @@ -148,7 +148,7 @@ mpu401_init(kobj_class_t cls, void *cookie, driver_intr_t softintr, return m; err: printf("mpu401_init error\n"); - free(m, M_MIDI); + kobj_delete((kobj_t)m, M_MIDI); return NULL; } @@ -158,7 +158,7 @@ mpu401_uninit(struct mpu401 *m) CMD(m, MPU_RESET); midi_uninit(m->mid); callout_drain(&m->timer); - free(m, M_MIDI); + kobj_delete((kobj_t)m, M_MIDI); return 0; }