From nobody Thu Nov 12 16:38:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQR061MZbz70scW for ; Thu, 12 Nov 2026 16:38:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQR055gppz4JFY for ; Thu, 12 Nov 2026 16:38:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794501493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+zuf1UxeXS1R+z+6Sgg9Rcfc2HnNxjmUG7+qKWa5D8Y=; b=MLJ3kVViAITWPeb6G3o8lLUfof/wOc7v3OjLrnu5H+BIWbpL6zxSTr/D2+CqNao3MGw+Fc Br7fMGrJ75jCnTYKwvfGHdTCmuvc+x84tlvxnk43Ft815z/jNT5CfVTxtTUU+MTKNP40FH G9h3y5AkpCaD0q9v+g1q9QdgALW6vURVv2zDDSQtV8h8gXmYHLW7wJgWuw2IbM4qJwFSaa 6JBO9buJbjGKmhZa58qF6vWwQPmrEw4xwiUiDLLqXoK5qRyrBCz8A8mWrTPIC/rVUBryFn XjlG77i4qBr5BW7erbzw8gzODPDso05Tai9Ou+BkiFRbJxZqMtMOzeHONhVpnQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794501493; b=C4ODo8qvUH6wjD+/kBViEelTy8i+rP5cdjNgttyZrzQ/XE4RTgveLtsIPhx29vx8Rvboqw H+nUGbTwuvMqPJA7HiXsZrPfCIXnpqGcNJqV6wWZHR5BXlI9sttEfHEHDarKCItUEGt/sz 5x3pk0VoUWIdx0QP/sGCbKZEprSylTjXwPzC+iu2Ty4wkvmmsT/J1Gl6qChFs0qG6AYuq5 0epX6D7IkDoW7V84g5cNMm6xAxPxll1ERQ1/CdD7sut/pmDDYtS1TKYfFQ5gOzz5tLQytj omcTqU+3+ZQ+hrsL8C3smGX767ppdGC/1yIGOmessyBea/C2zpeDmYybbGnd9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794501493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+zuf1UxeXS1R+z+6Sgg9Rcfc2HnNxjmUG7+qKWa5D8Y=; b=E+BeFP746JoLbqXpCtsRIS0qzlWzMF50dPkqiLf579WnT7Dm7MSxaFr2zEfQvbO/8zX7Ue BGeg4BordM2jBT4PV6JvG2iHeKYpw9wGCEVgCVZyISJRiiCRuVVRtXuDlSg0zRUtBDcdk7 EO9hyA5IIkbJP9Qvtr9UbHXWC+pbAo2jfkDps9/dcgSNj3C4HH8ZAdqI85LI6wRdXZabRb 1ET51qAqRA4XzkImnxAsTcwRFfsWYYRGX/q9rQNnhe2U7YA0jaZmHbD151lpVqr4Z5rHOC N41nzj6SOCePcXuKOs9ckt58V4vdAHv7/C8671LlIIpMygW6xihWdD0LaZP2qA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQR053qtdz19Xb for ; Thu, 12 Nov 2026 16:38:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2e8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 16:38:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: a41ab6befba2 - main - sound/midi: Clean up zero assignments List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a41ab6befba220c9acf9b9ee09931f598d4862ea Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 16:38:13 +0000 Message-Id: <6af5eb75.2e8.74715a92@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=a41ab6befba220c9acf9b9ee09931f598d4862ea commit a41ab6befba220c9acf9b9ee09931f598d4862ea Author: Christos Margiolis AuthorDate: 2026-11-12 09:35:58 +0000 Commit: Christos Margiolis CommitDate: 2026-11-12 16:35:49 +0000 sound/midi: Clean up zero assignments No functional change intended. MFC after: 1 week Sponsored by: The FreeBSD Foundation --- sys/dev/sound/midi/midi.c | 16 ++++------------ sys/dev/sound/midi/mpu401.c | 1 - 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/sys/dev/sound/midi/midi.c b/sys/dev/sound/midi/midi.c index a078c02dc767..03add9adea23 100644 --- a/sys/dev/sound/midi/midi.c +++ b/sys/dev/sound/midi/midi.c @@ -166,7 +166,6 @@ midi_init(kobj_class_t cls, void *cookie) m->outq.buf = obuf; m->outq.size = outqsize; - m->flags = 0; m->unit = alloc_unr(dev_unr); m->channel = alloc_unr(chn_unr); m->cookie = cookie; @@ -226,7 +225,7 @@ midi_uninit(struct snd_midi *m) int midi_in(struct snd_midi *m, uint8_t *buf, int size) { - int used; + int used = 0; mtx_lock(&m->lock); @@ -236,8 +235,6 @@ midi_in(struct snd_midi *m, uint8_t *buf, int size) return (size); } - used = 0; - if (size <= midi_queue_avail(&m->inq)) { used = size; midi_queue_enq(&m->inq, buf, size); @@ -291,15 +288,13 @@ int midi_open(struct cdev *i_dev, int flags, int mode, struct thread *td) { struct snd_midi *m = i_dev->si_drv1; - int retval; + int retval = 0; if (m == NULL) return ENXIO; mtx_lock(&m->lock); - retval = 0; - if (flags & FREAD) { if (m->inq.size == 0) retval = ENXIO; @@ -343,7 +338,7 @@ int midi_close(struct cdev *i_dev, int flags, int mode, struct thread *td) { struct snd_midi *m = i_dev->si_drv1; - int retval; + int retval = 0; int oldflags; if (m == NULL) @@ -367,7 +362,6 @@ midi_close(struct cdev *i_dev, int flags, int mode, struct thread *td) if ((m->flags & (M_TXEN | M_RXEN)) != (oldflags & (M_RXEN | M_TXEN))) MPU_CALLBACK(m, m->cookie, m->flags); - retval = 0; err: mtx_unlock(&m->lock); return retval; @@ -527,13 +521,11 @@ int midi_poll(struct cdev *i_dev, int events, struct thread *td) { struct snd_midi *m = i_dev->si_drv1; - int revents; + int revents = 0; if (m == NULL) return 0; - revents = 0; - mtx_lock(&m->lock); if (events & (POLLIN | POLLRDNORM)) { diff --git a/sys/dev/sound/midi/mpu401.c b/sys/dev/sound/midi/mpu401.c index 61a9d1be40c8..003a0d581973 100644 --- a/sys/dev/sound/midi/mpu401.c +++ b/sys/dev/sound/midi/mpu401.c @@ -140,7 +140,6 @@ mpu401_init(kobj_class_t cls, void *cookie, driver_intr_t softintr, m->si = softintr; m->cookie = cookie; - m->flags = 0; m->mid = midi_init(&mpu401_class, m); if (!m->mid)