From nobody Thu Nov 12 16:38:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQR0167gvz70sSx for ; Thu, 12 Nov 2026 16:38:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQR0132Zpz4JMg for ; Thu, 12 Nov 2026 16:38:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794501489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PIjk/wL5B46lzzeKhinIJiepkbXgQBf1YMnbDs9bXog=; b=FswAoRUgoHakI2IX+G4p0LoWg1cBL3076A/mYb5wNRTqQnQ6Rz7/rfSOg/QRpP3PDgrh/S XW2RQZB8OXWZ059W5LmxgKa2viGkJ6DrQ12O1POvQ8VCEfseXWWxgCw4zuwa8RMRdh+Aiu QZ0GT0k8ERiXkCQ1EAKviq6Mg4BMTZMY7eNaNvPXY3LunFcamllOCINnzgmUFvh8+NtC+y kCwi1Yb1gly+8XwKQBEtyPSlajdFJSEEboUrl+CXsChxxixKesZUNak+IEfgiQ0fWDtfNU x/kcgquVI50K1iAA12z/tCwHnxsqZ4gzdBhshcEspB5ykxbr73u30zAPKv2lpg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794501489; b=KkA+1P6EcrhSgnHCg7OUXyZ66mAZo9/Ln4iEKhV/w68Y0JXqhT0uuMmn0uwk3EBMNw2Abj imPd5VcvIktfMhrovSj7QdsXtIsSgmA4Ca+KViCl7f0Y4OPXRvPTw98Kj5ml3uvGs7BW1z 9uOaam714LE/dUrsFQsD+LAF1wiUT2yNv9KE+V65nDypTrIM11A7mKjSzhuH/9eGuWg3h+ GjlVOy4pSA5BTofdSFF/Dc27TWPpLMYiGhEjrhKRJ6bZGiCqATXZlLO3CrIqmrjMcg6P2H lMZ/nKoGB4hLqdCcI3l4jHUqF9E29/wFH8W5THhUjLDb6px7xss6cuNtMVI5Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794501489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PIjk/wL5B46lzzeKhinIJiepkbXgQBf1YMnbDs9bXog=; b=qEZ96lwmu7p/a1BywTg9Mceef2hGRu0dnWkjUyqn/ELqEoNQi0q35SGX/4GdZoViIwcTa5 ZEosoDCZKFOD/19Z6iA0EvgIjdGvpoAlgwQMZIypLHIPzfBzwi++rplelbwV0Dy7ZrkuD/ 7AD9Ft1QeAY+2mO4CSe1nO8lyITKy8Bh8evJ/e/TL7pju2ccRuySFA8yX4U0LGWlpVJFIt 2JcOJfm7moi3zy3pHbfMjZGCQdi2CtPcmbA1+3AEsfNex6u3RRXyOFc0YsGESNHYsV09ip BD2EPVqDEmyOhuEgUAbAlxmS8ssY2Ww6FYyr9saNpaTKSUn/ezOWhMchV2bFTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQR012RD5z19CH for ; Thu, 12 Nov 2026 16:38:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 215b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 16:38:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 961e18b07cda - main - sound/midi: Do not return from midi_close() with the lock held List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 961e18b07cda24e838098127e1079372851379df Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 16:38:09 +0000 Message-Id: <6af5eb71.215b.378b0cc7@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=961e18b07cda24e838098127e1079372851379df commit 961e18b07cda24e838098127e1079372851379df Author: Christos Margiolis AuthorDate: 2026-11-10 14:03:53 +0000 Commit: Christos Margiolis CommitDate: 2026-11-12 16:35:49 +0000 sound/midi: Do not return from midi_close() with the lock held This was already fixed in midi_open(). MFC after: 1 week Sponsored by: The FreeBSD Foundation --- sys/dev/sound/midi/midi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/sound/midi/midi.c b/sys/dev/sound/midi/midi.c index 6561bd8a6f52..dbec096e3f66 100644 --- a/sys/dev/sound/midi/midi.c +++ b/sys/dev/sound/midi/midi.c @@ -367,9 +367,10 @@ midi_close(struct cdev *i_dev, int flags, int mode, struct thread *td) if ((m->flags & (M_TXEN | M_RXEN)) != (oldflags & (M_RXEN | M_TXEN))) MPU_CALLBACK(m, m->cookie, m->flags); - mtx_unlock(&m->lock); retval = 0; -err: return retval; +err: + mtx_unlock(&m->lock); + return retval; } /*