From nobody Thu Nov 12 15:45:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQPq231WZz70nlS for ; Thu, 12 Nov 2026 15:45:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQPq22Lbrz3KRc for ; Thu, 12 Nov 2026 15:45:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794498318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=etDi/ZFKdEOtxBw/8GSwQm28EbSbr/CPbsIaO0F2lik=; b=JfNbkc+1K6y00Z2cZHHDuqGbooe4BEyag6y5R7ZHKxa2hYLbOHcFMD4+/xToS+GIOrOPi8 grmWYNZOt4SfK6Ypev9YqEEmvQ3MksqHumstEzZqaZSZOph3xR8Z17AeL7k4vSGD56KGLs ba9wknX9w9WQyqlAQJeVQRDj+7svD7GTieeHuzIWl7dszT4pRoOKKg5j+kz95t7NjJSfns Te4SvThbek9X325lNqHYxzFwXUMDt/iAP4zfutEWB/uwuTNdbu84MAeOCD9hx9C/wALdQV uzVcKam6tTqbupbHatxAXN42Nl+oD/hMYfI5KMu4fJ3ARQj9dldJyMoPSepHJg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794498318; b=ayUFw1ilK7x58XxHTxOAsIE+xeV84IWYzPXWrX6yaM/NrDJOHxacCCaynctbKcEH8uRn0x x/6ua46znTKErogOFZAYIMwPJaenbNcBH9bV2T7ayR6Wg7h0k1U61hRojwEve8tVEyNtzy Crv74b8/qQlRN527MBLArqz9X4cpgOB5iiE1DL8GVYAzzC81876sOvnCmqLS1jJqXSm42Q BBSTFoSJ5F0QtD1BRmbeAu6A0/HGSClNs8hPoc3YtclvPNJt6RaFm+8Tr5epjZMBPWr9tb l7MQSFAUX6YP9S516UTR6AHGO5NDcys0aYxH4YQF6QLd1kpWT4VaoJU3aGvf9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794498318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=etDi/ZFKdEOtxBw/8GSwQm28EbSbr/CPbsIaO0F2lik=; b=kAA5gKrHHDboqt/qI/t5QSR1W3P+UY+P4/WBS8WS9xwYDsIdGWevvgerZYJ6aWXsdU8vnO gZlDd5A36k6kvS8ybh4y2QqH7ild5c7f8rRl+3Yq65LbKD8ksQHlPk1sHtXBH/XsP+YvRN rfnx8azxsOrf0EbElHTXzGL4kXaeNw8CYb3jq4T/bwWp8a7wX+7m8D5Sa6uG8Lfdf0OQkr 5r0a/tdBoehd92YI6sU2jBZh2sp2lvGIJqBtAcUNb3yiSflGKAtDoPeAVCS5rIOy/Wt8Ja Q0qREcLPMo8N4Zrh6bktsmN2TlLFyH/ywskpelcCqD7mjOHDh9gubBfZT4hO6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQPq2210Wz18C1 for ; Thu, 12 Nov 2026 15:45:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d3c4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 15:45:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: cc33771bf771 - main - ctld: Use expand_unsigned for parsing unsigned NVMe option values List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cc33771bf77102291db1e50037a07c1501a24075 Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 15:45:18 +0000 Message-Id: <6af5df0e.1d3c4.6e201104@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=cc33771bf77102291db1e50037a07c1501a24075 commit cc33771bf77102291db1e50037a07c1501a24075 Author: John Baldwin AuthorDate: 2026-11-12 15:44:18 +0000 Commit: John Baldwin CommitDate: 2026-11-12 15:44:18 +0000 ctld: Use expand_unsigned for parsing unsigned NVMe option values Sponsored by: Chelsio Communications --- usr.sbin/ctld/nvmf.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/usr.sbin/ctld/nvmf.cc b/usr.sbin/ctld/nvmf.cc index 689c3404af1a..9940722420e3 100644 --- a/usr.sbin/ctld/nvmf.cc +++ b/usr.sbin/ctld/nvmf.cc @@ -124,15 +124,14 @@ parse_number(const nvlist_t *nvl, const char *key, uint64_t def, uint64_t minv, uint64_t maxv) { const char *value; - int64_t val; + uint64_t val; if (!nvlist_exists_string(nvl, key)) return def; value = nvlist_get_string(nvl, key); - if (expand_number(value, &val) == 0 && val >= 0 && - (uint64_t)val >= minv && (uint64_t)val <= maxv) - return (uint64_t)val; + if (expand_unsigned(value, &val) == 0 && val >= minv && val <= maxv) + return val; log_warnx("Invalid value \"%s\" for numeric option %s", value, key); return def;