From nobody Thu Nov 12 09:51:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQFzD70Wmz70KWt for ; Thu, 12 Nov 2026 09:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQFzD3nklz3Gjw for ; Thu, 12 Nov 2026 09:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794477112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lXGoGrV2XDRFo7NPr7FH3F26PhX3ImaDLgJKaQ20QUE=; b=WmqFuVISCUJdFt2mHOBVsiPeT71lzDf+ikhUoDNAE7fOvLalWC5PDtkB5hkoK6EwnAwd55 w6ctM/ar+zK+nTFVPJocKzf7Zlntb9y3kqHtVB1Vr16FnMpE4+UR1FaBlWwyI22fjJS/Nj J0msNVvX03VpQ6YRcLx/fKMaXVpbrNQQ6665AVJQoyTvXIPowaEQzHVixwcnAAUyo/CF0Z Z7cP3V+E0BiCETxn1h6Op4d5+BB8+ufKvcAzAgEpEFX28apQFQ/+ALfbqO5HIIUCC8YKFz XpOoeKeqmIm6lh+ksZUMEp9QGDSGbR/IhhEH5NfjTbVwgjlb7BtQhG9nuOgxPg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794477112; b=qQ6bgcRYGKdG+O5UVvP1QlMNsVIZWwwUdStU7f3V8zFmv0CdyLzzKf/XT5Ylxx2RdSgY6y zxHjvGYIP3+htCiZ2aqhmmr4dVuQ2a5tto7SCsj4Mub59YNsqfZ+bRw7dwuzIZtE7ma851 akcD5+XZTV9ygCPooQbleBz33NW2b3QrUsKGmBnTe3MCLLgv5nA92cvovMUb+fOpDKUvJ1 uNM3O//Vv+9WJ/DPiUH+qFk6w5acgJMAkfN2VlbMJmIRQWCM/HbTmhQtXqLt2jBjKdz6jc BzcK0XQmCPSjG77ru9KbqYlB4zP3eNU/h3ioUlhdfzR8m/dv3JFKdj7piuflMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794477112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lXGoGrV2XDRFo7NPr7FH3F26PhX3ImaDLgJKaQ20QUE=; b=UUCx4WDKB8O7YDffAmlKr8fO0GEic3EX+R6FP+5Mcy1Z+fu4eYWBZfPXyGUqZjPwhXn3HP R+KWx3yqX8JBMIC5zvAnBD3LVslFAFxjLypCWfp6LqItRnsW3FC8EAqnR/Mb68X8dp3p+x Cd+RYlSjneTiIF/Rxq8zAATI/21UpFjU1XI3JdjitUfhHk9LK9+7FtWAV1K7cw5sWDia4M LMFYPx3c7bYKuL6S8dC8wCaZNBJZRYfckHspyS4y7McTtKtd3KI+uNKuBiphH5HJS40d56 z3W9VfI5IHIs0Zdsn+O3V6BkpvW8epmbXteB56cjkQOmrb7MRj5X/FIxs9QyRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQFzD36W7zxj1 for ; Thu, 12 Nov 2026 09:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f95c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 09:51:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 256d6289a86b - main - aw_gpio: Fail when a pin cannot be mapped List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 256d6289a86b85c22e3509627e3b23078d54a947 Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 09:51:52 +0000 Message-Id: <6af58c38.1f95c.5d6cb86@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=256d6289a86b85c22e3509627e3b23078d54a947 commit 256d6289a86b85c22e3509627e3b23078d54a947 Author: Emmanuel Vadot AuthorDate: 2026-11-09 18:39:47 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-12 09:50:24 +0000 aw_gpio: Fail when a pin cannot be mapped aw_gpio_map_gpios() returned success without setting the pin when no entry of the pad table matched the bank and pin of the specifier, so the caller went on with whatever was in its variable. Return EINVAL. Tested on: H6 --- sys/arm/allwinner/aw_gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/arm/allwinner/aw_gpio.c b/sys/arm/allwinner/aw_gpio.c index 4f5d676c1f56..8a223bc4fb47 100644 --- a/sys/arm/allwinner/aw_gpio.c +++ b/sys/arm/allwinner/aw_gpio.c @@ -972,11 +972,11 @@ aw_gpio_map_gpios(device_t bus, phandle_t dev, phandle_t gparent, int gcells, if (sc->conf->padconf->pins[i].port == gpios[0] && sc->conf->padconf->pins[i].pin == gpios[1]) { *pin = i; - break; + *flags = gpios[gcells - 1]; + return (0); } - *flags = gpios[gcells - 1]; - return (0); + return (EINVAL); } static int