From nobody Thu Nov 12 09:31:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQFXJ0SGNz70HbP for ; Thu, 12 Nov 2026 09:32:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQFXH60x0z4tl1 for ; Thu, 12 Nov 2026 09:31:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794475919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=znx5ePPM7ppeGtCIewkiOKYooch0rJgyzI+tPcfalqs=; b=TeocFYJinWhDs0XkRsXExi6i2lQyuy5o8sigPFCKOjqk/yVQC9Go2p2a2J3lXegSdCBQdS GzkEJq9yOSoT406CXxrCRPUCBW181kf8z/zLVCw3/n5oDT9FTnfF0CVjUiAaEDT7cukiUB SUtHowUuxOLrwfhfBbfX1FZrT/o4NbSxYuCC6rA/ziEK/p+dzh+MMgXibtfPAHv4QYk4FJ SJh+UqxHb+fzcMSIShXlAT0jWUrHGRZpOGq2C4O5L9z5XYoFRMZUsvwKENZnUbCQxP4leZ y2yAITacvXaoEBRG9Z/lzwh0FqtDdxqJ7iHG4QSjzcDQZIIsGSKqcEkpCPSzXA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794475919; b=H6YU27/lQ5jgXq8o4MGHI/MSr30YTvQ5z06eEhZ6VSMuOFv5taS4gLwEXsOuXtaemXjlO8 J5qXpI8ghzBL5dL19XoXw7znpR/MvYbY9jchEZuKWqcgsmKplTMDYLjIFNBL3aiSQkF5Zj +jW+tXh3taQhYKQ1qUnouOjlpE3amHLaDdeybFrFDg3ij0WkfgVMcIROlyKjoAdysJg7g0 2Jgv660jEVEagbhrZZ1gZaRaxkRYaPYeV90tAkkSkFJgIWmsnQ1TcRWqlh0lg90wAUVd/f RFTnQ4iPU6tOsKO6s+JxEBX9bJMrz1hiqRKGrCK3iyFdgeYcgGFtQdfpX5pTfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794475919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=znx5ePPM7ppeGtCIewkiOKYooch0rJgyzI+tPcfalqs=; b=MHA3L9D81+dqLX7U0i5JtCttHoQjeT8xNHaaHtuZmttLBzG63K+b6JfTglfVDmSTof165U 9kQKN0aqu+EYtQB6Xi54WNYnsQHXVNUnNqkBADpb4R4bCrykzGy55e/R0pzgJw/W8INoUg KOLm/MR7hjS2Bqo2SCzmWbJ1yY8oOZLhFCdK9HAhXurLCgL2WDc3oMx54qrtTPYouuktDA 2/pf/HwaJJe0KXKmoV5+ISbER13Wu1IIWRQNqvlAkI/b+mCloXxD/SPumInPd6mRt3306p MB7HAaFnQ2wf0mCuMNWebLZiihwJDN3eQiDqCZXoCG7CZQgXQl9kYSNvcZ++IA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQFXH5cvzzxD0 for ; Thu, 12 Nov 2026 09:31:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d9d8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 09:31:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 97db601428e9 - main - axp81x: Always set the delay of the regulator methods List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 97db601428e9118aa45a8ac3da4f904fa21b25ef Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 09:31:59 +0000 Message-Id: <6af5878f.1d9d8.5bbad9c6@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=97db601428e9118aa45a8ac3da4f904fa21b25ef commit 97db601428e9118aa45a8ac3da4f904fa21b25ef Author: Emmanuel Vadot AuthorDate: 2026-11-12 08:48:46 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-12 09:31:28 +0000 axp81x: Always set the delay of the regulator methods axp8xx_regnode_set_voltage() and axp8xx_regnode_enable() only set the delay when they succeeded, so the callers could use an uninitialized value after an error. Set it first like the default methods do. Reported by: llm-postcr Tested on: A64 --- sys/arm/allwinner/axp81x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/arm/allwinner/axp81x.c b/sys/arm/allwinner/axp81x.c index 80e01fca8745..1c8c0e66e066 100644 --- a/sys/arm/allwinner/axp81x.c +++ b/sys/arm/allwinner/axp81x.c @@ -897,6 +897,8 @@ axp8xx_regnode_enable(struct regnode *regnode, bool enable, int *udelay) uint8_t val; int error; + *udelay = 0; + sc = regnode_get_softc(regnode); asc = device_get_softc(sc->base_dev); @@ -927,8 +929,6 @@ axp8xx_regnode_enable(struct regnode *regnode, bool enable, int *udelay) if (error != 0) return (EIO); - *udelay = 0; - return (0); } @@ -995,6 +995,8 @@ axp8xx_regnode_set_voltage(struct regnode *regnode, int min_uvolt, struct axp8xx_reg_sc *sc; uint8_t val; + *udelay = 0; + sc = regnode_get_softc(regnode); if (bootverbose) @@ -1012,8 +1014,6 @@ axp8xx_regnode_set_voltage(struct regnode *regnode, int min_uvolt, if (axp8xx_write(sc->base_dev, sc->def->voltage_reg, val) != 0) return (EIO); - *udelay = 0; - return (0); }