From nobody Thu Nov 12 09:31:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQFXG6wCMz70HHS for ; Thu, 12 Nov 2026 09:31:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQFXG5dPTz4tfg for ; Thu, 12 Nov 2026 09:31:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794475918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PjVDlVrRcp+o9wbvV5SbpOHuCorileqJ4zcNHa3EvFM=; b=auTTXp4r2mylSC285EhL6KJjtAlP7vxNm7a8F2aauIrgLX8WS5Yn0M5GjK3kUfKp2a25lX FnA3t68MiKKUfSnXG786zB+XoiD1rR0zlwrPE//WDFt+asl4bztPbYx7H4C1wDlQ2Xoc6Y LScUBu7sqjn7vFiP30zZQA7CrQEbDT0tL1H6RqsJX3WUPv1pUvHerna/v3mT1S3h7NzLfb CDd2+Robv2icFkfpvOdfFKCndSVpq/RPNwAqOGPmB6Z8AOZWJ4tapAihtqTdVTzMS9bZuF xn5K+e1ow26GFvdC8n4/2qMNZhqWAlWd9g2U9yy70b5vAC9bmVIxBNeGHKwmEQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794475918; b=LES7kSNAB9qBq0wQ4MwhUOzefcXrR2YZOCHwzpp0gpRwV3DEsP6fM7hmxT5Lsh0P200pT1 Q9V5vWS4C2Tki6JR4PrVnbVUHx/zoRlQddbdV1larCHJ9yn/oHxDnk1o9ozWC9OL1OAxlU PJs6+KXk2fzC2bpV6ihW3PzGW2doLt91pSLW9v22eOpZMf+qN8+wzxVAINelIPAH8II+W/ 5flQGODYJTmqu73PqvvePBHwCLG1JvkYH2hIDxOo3cj5Bpse/J2wcMkCGaXd7fKjM4MbSB 0cONBQXuq1Oi15w0uB2/lbmP9d18+OlPy6fRd9Q9JJwMATLrwykRXG7a4a/+mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794475918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PjVDlVrRcp+o9wbvV5SbpOHuCorileqJ4zcNHa3EvFM=; b=mSD9ZDCWVdWt41Tbhjoerv6CsaW5bTDGzVXjlezY+MG4OtDCRXn/sanqIfPiVOZdBbh11i Tz4kr/8jTYL7u2CcJ7Pc6zTVIegGRKcxZlfUn3oBMK70Fy+x1WZgmjZefg7o6UpLS2gFJW ijWnrMCTcu2O78hIAxfo1zOON+JVKfMH4blXiR0/TLsqN2MV0E7z+2H/PC+1AO/Woh/VrJ ++kwnrUzbHeg5hnHrStg2x4c6t0/vRHFaWRb8xD2Sek5S4P84MJ6Dw45zEaFn26S64tNRN 1kso5ThOO9jrqMz6+dIPndKMAkd8Y5CoScucKoYy/EsxKABBB1YFXeXP9xzV5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQFXG5J3hzxCy for ; Thu, 12 Nov 2026 09:31:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d9d3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 09:31:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 010f31a79c43 - main - regulator: Do not delay when setting the voltage failed List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 010f31a79c4313344a05df768ea31429ec7a9fd6 Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 09:31:58 +0000 Message-Id: <6af5878e.1d9d3.39d1342c@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=010f31a79c4313344a05df768ea31429ec7a9fd6 commit 010f31a79c4313344a05df768ea31429ec7a9fd6 Author: Emmanuel Vadot AuthorDate: 2026-11-12 08:44:24 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-12 09:31:23 +0000 regulator: Do not delay when setting the voltage failed regnode_set_voltage_checked() called regnode_delay() with the delay returned by the driver even when REGNODE_SET_VOLTAGE() failed. A driver does not have to set it on error, so the delay could be a random value from the stack. Only wait when the voltage was set, like regnode_set_voltage() does. Reported by: llm-postcr Tested on: A64 --- sys/dev/regulator/regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/regulator/regulator.c b/sys/dev/regulator/regulator.c index 6b49c6e93aae..b59710b8aef0 100644 --- a/sys/dev/regulator/regulator.c +++ b/sys/dev/regulator/regulator.c @@ -827,7 +827,8 @@ regnode_set_voltage_checked(struct regnode *regnode, struct regulator *reg, max_uvolt = all_max_uvolt; rv = REGNODE_SET_VOLTAGE(regnode, min_uvolt, max_uvolt, &udelay); - regnode_delay(udelay); + if (rv == 0) + regnode_delay(udelay); REGNODE_UNLOCK(regnode); return (rv); }