From nobody Thu Nov 12 01:29:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQ2qJ3wglz6yCNT for ; Thu, 12 Nov 2026 01:29:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQ2qJ3NQVz3JnG for ; Thu, 12 Nov 2026 01:29:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794446956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W8Vjom4gTM0wdb7vIGeci/nEaD/D0AwyauRHHxnlFac=; b=Cp0gQurESH/N/iJ4hMCT8Y7jIsLBugFKlbaf0YJNyhqNrl8WQs+thQBaQafUotkf8dqCmR vyEQhQNnnQI/28cmX4rQjcfCCqvVrwqx/4yWnpeghT2sZjDmEIy8gJhceKeYUPLlWCOM+k yZI7w3S++R0GUThwJJqsb7Bklkz/MjNmEQa2VRy0yG0ysvp8klWFmwBiXYIAW1kruANCQq aspg9E5Whc7oqNrlmt/im0cdjujln7NJKuS0I+E+4ufmJN+a2uWI77sXZ4Rvdf+Ext6rBK TB4i/iGZo7R1WO2h4L6goJ/ht5wsAyG8dCglOkg9IfjvPOxFXO98G9uoSbSDcw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794446956; b=yUs3JO2dAsOdx79zR1PKCLvIqQ3hVDdFBXx7+FI/7QaJnczBe+s2Eal3lzY3E5IAw6hAdP w6t3iDikt9ix3khJuwxz65HENfbjiIvR/SdQzPhYpVaxirWk+5kuGa6mHCx1xkNUjUq19z da3BVwMvOUWMuxZKJZuFnOSCCX8Nkt9hOBVitDXtu5BrNUevmFulv/BRgkRBY3MkUUMOWv N1eQemozC2MZR/S6Tsrk4gdjaowvkwReQtJU9om0EWVqan48sKcHHlw57SHcnsaRPhTU36 sPXwN/zcXvNQEto6g8bbxdD/OyIWHJf6WXllsfNyoyR7JUZqkKOh4FTz+I2BIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794446956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W8Vjom4gTM0wdb7vIGeci/nEaD/D0AwyauRHHxnlFac=; b=dr95pTjnCT/LmNjFKjgBz+owyFAykfC6qlm3LIpF/BEveGQCTgm4rq2JaakEok4eqi9EiZ hZpDFrUT+RyjQJdDVh2w0biMh8FFGIZYGzT75JjKJSxj7pFh3XM5fx20taX6CRAs6oOSAU Fhqpou4vGgsJtSOQsYzSjAHlWMSdz9CeDaUkpWjgl4Q86sXRTC/k/1lJVMJybiXElNu1A2 g749D4DM3KWYajjndyMziUex14afaq3tG4N3jFuvwoSQuWlzdIEll7JhLEdbBgmjiEZgW3 E6lkO619uFnYZTEWL3dBOVHFclRttaSzgs7FoImjHzhY0Ne3+22bdAHu0Nrb7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jQ2qJ2m67zgjx for ; Thu, 12 Nov 2026 01:29:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id b929 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 12 Nov 2026 01:29:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Osvaldo Janeri Filho From: Maxim Konovalov Subject: git: 1681aa4cd5e5 - stable/15 - bsnmp: zero-fill the destination on a short ASN.1 IpAddress List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: maxim X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 1681aa4cd5e536c8b340bbaa12369ffa06136f15 Auto-Submitted: auto-generated Date: Thu, 12 Nov 2026 01:29:16 +0000 Message-Id: <6af5166c.b929.7570f2f5@gitrepo.freebsd.org> The branch stable/15 has been updated by maxim: URL: https://cgit.FreeBSD.org/src/commit/?id=1681aa4cd5e536c8b340bbaa12369ffa06136f15 commit 1681aa4cd5e536c8b340bbaa12369ffa06136f15 Author: Osvaldo Janeri Filho AuthorDate: 2026-10-29 18:05:14 +0000 Commit: Maxim Konovalov CommitDate: 2026-11-12 01:28:10 +0000 bsnmp: zero-fill the destination on a short ASN.1 IpAddress asn_get_ipaddress_raw() meant to pad the 4-byte buffer after a short copy, but the loop bound was the already-reached len and never ran, leaving addr[len..3] uninitialised. Pad to 4. This is harmless for the in-tree consumers (bsnmpd(1) and libbsnmpclient) which zero the PDU before decoding it. Reviewed by: harti, maxim Approved by: harti MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60923 (cherry picked from commit b5e57452b62e7c185706ed8b2a86e9f8ac483357) --- contrib/bsnmp/lib/asn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/bsnmp/lib/asn1.c b/contrib/bsnmp/lib/asn1.c index f1f9267c0226..5f2419e8ba1a 100644 --- a/contrib/bsnmp/lib/asn1.c +++ b/contrib/bsnmp/lib/asn1.c @@ -777,7 +777,7 @@ asn_get_ipaddress_raw(struct asn_buf *b, asn_len_t len, u_char *addr) asn_error(b, "short length for ip-Address %u", len); for (i = 0; i < len; i++) *addr++ = *b->asn_cptr++; - while (i++ < len) + while (i++ < 4) *addr++ = 0; b->asn_len -= len; return (ASN_ERR_BADLEN);