From nobody Wed Nov 11 16:49:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jPqJ749NRz70ScZ for ; Wed, 11 Nov 2026 16:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jPqJ71hS0z4mx5 for ; Wed, 11 Nov 2026 16:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794415799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x7yJM7wf723r/NdAlR4JpFEcO+kp36u/qFzHPw3KZ1I=; b=yhG5YkzGK3WJTbpweVeAJBSPoBHwlGxpIGLPumjmoKbOpVNp0GQPeapEweU7CFTgdBHst9 RgZnh6HjEGvVtEeWxsLxhbw/jH1K/YcAEpGibZFHEaPdQqAFPPIsNj+fB/gjGUukFg7gK4 L7e7eWj/QZn2s6EffT6ZHlT0OtFaxyuCgTUEvt7pOsWbo9wv6ewZ0spFgCozL7Whv9NC6A 8HrcDdcavzR8gojNECFK9FVsbL1PjDFmtol/HHlMK0FDLpTrlclbMFOqsr7Swj6F3zKo3N TNwhnHYOkJjWNi0I1FX+xE4M/WPwrJrt0zc5MS11XMa9M9H3xmM4MZQlQ2EUoQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794415799; b=CwvD3Ro5W9P4oL5tPMZp9HxeYIffEDkJWbM8Fa6CeYqx2jnbxCyxDiBUmdmtYrdCT074RM QSf73KN6no7eUCQF16BHUyR4aqPpvxwOqJtZzRBMOt89RFxP5RABoxrIINdGJBaGCd0GVW g40DFL8r7H0u0GiByre9+8Pr4OyFisZrIIShEiXGlQ2xdH2KSyraWjimMPL7Gilk0YWdiN E/TgcEvOD4qc3tnwittJLu9e+MNntXBePEfhyVbbTPPwYooQB09N3taBGq6tRtiWFE8Ylo SHw/ftpooLQfL9NMGAg3K+Cu9mW6zwLvVc7U2uvoX3kOkw/gUmRNCPfucxVZNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794415799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x7yJM7wf723r/NdAlR4JpFEcO+kp36u/qFzHPw3KZ1I=; b=TK9i2M8GxgNcRMu3RmuRrMI4cz/LTsrudqIXXcu6VSo/U/HLcysaVECDSfLg0W9Juw0s19 FHzEj0hOMoKMLE3A4MYOKfCYTt+dFP2A3ElPjRe6gv9pGEeftW9Y0U+/UfCVW8imUTBn+P bRzhz4fPav5g77o/KNGH5y8aI+8TjkvCo0ITFJlOpDJBb/brN8QyiNCrsW7uuHqiRSJMIc CLkXSj4l5FPcCOA3o31C9iGRjk2SLmevy+BsKGt2duypt19CmUnRiBcFfq07NyJDLuMsI0 Rtkbk4LrXFoHvxWShDymz+bX0YVpOZdrAaw80o65mgU24iZovv2aeKavusCfFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jPqJ71G7WzMqv for ; Wed, 11 Nov 2026 16:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1bbd9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Nov 2026 16:49:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Wanpeng Qian From: Mark Johnston Subject: git: b3860403a7cf - main - bhyve: nvme: initialize the AEN condition variable List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b3860403a7cfbd32e4b21f214c2d3a46ef1a27b9 Auto-Submitted: auto-generated Date: Wed, 11 Nov 2026 16:49:59 +0000 Message-Id: <6af49cb7.1bbd9.f791dc6@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b3860403a7cfbd32e4b21f214c2d3a46ef1a27b9 commit b3860403a7cfbd32e4b21f214c2d3a46ef1a27b9 Author: Wanpeng Qian AuthorDate: 2026-11-11 15:06:53 +0000 Commit: Mark Johnston CommitDate: 2026-11-11 16:49:43 +0000 bhyve: nvme: initialize the AEN condition variable aen_cond is used with pthread_cond_wait() and pthread_cond_signal() but never initialized. That works where a zeroed pthread_cond_t is initialized on first use; elsewhere pthread_cond_wait() fails at once and aen_thr() spins with aen_mtx held. Signed-off-by: Wanpeng Qian Reviewed by: markj MFC after: 1 week Sponsored by: keelos.dev Differential Revision: https://reviews.freebsd.org/D61424 --- usr.sbin/bhyve/pci_nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 50ad8ea21f88..58af9df027a9 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -853,6 +853,7 @@ pci_nvme_aen_init(struct pci_nvme_softc *sc) pci_nvme_aen_reset(sc); pthread_mutex_init(&sc->aen_mtx, NULL); + pthread_cond_init(&sc->aen_cond, NULL); pthread_create(&sc->aen_tid, NULL, aen_thr, sc); snprintf(nstr, sizeof(nstr), "nvme-aen-%d:%d", sc->nsc_pi->pi_slot, sc->nsc_pi->pi_func);