From nobody Tue Nov 10 16:12:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jPBWN03qTz4wDHH for ; Tue, 10 Nov 2026 16:12:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jPBWM6Ktdz4ZGm for ; Tue, 10 Nov 2026 16:12:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794327151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iiik1DGcnnL1vZGtUpITN45SXJIlKuiHz8OPXZacg0k=; b=BTFz3gdl0qyWGGPX8340VvDineNxqeW/Jld2aBdWbB9TEH1BVaUDHhNFWxeTR7LHiGQwlR pWERHzTeUa/hPOX8Y/eLL8n/OX2AeNRg2p9JElYwuc5GLKuzQ5XOVqr0S5XSrECw3cPDR9 vgs1sxli8yZCtXVxYph1skIcNnTSoAeY7zaq9U3+Sw3H8PIQ1dqeJe4LOuPtDYpXZIL6lj TWlWgVaZuJMSkORiBam85mbD4sY2YI3k28XJ6KnJebrshcjKJOPdqwgTs0pvWmb5yV2kcS lXbuOnJyKnCZkkdiQHY25ySY1wXBxYuIOrG3ayHfjX5c0pgd5sILpu/G/H90cQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794327151; b=oidUBwNj+kOUs5kwB6IXNtaJhSExdMYFWfCb8Qvdbz5oLYnaPZp5dNaFW8Hm3w07UwjTl4 7uWFT2mp+1WiAE3d/NEIPjJ/q9ipWXC3FjwM3fYW20gY/7E8Avbx7SnUDUnGB6CwU37K77 lhrK3cQkJluZFHcyaMjYULULjB6cKXqalARlgRvqUC71KIrcl+VzLlBAZSKR4ho1EXuOa7 P2SCgaEmrlL4nQVdPtc68ogfj9H3D4hNPMWTMun1QJxsLykA9U/h6I2HgZUIc+wW6q/4Ae Y0GgRuapeITnByZMcwx+NUseVh+ti5E1Nn9pQQeB9wHo84FcHPCBWIhciDXsFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794327151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iiik1DGcnnL1vZGtUpITN45SXJIlKuiHz8OPXZacg0k=; b=DX2rS3iYbsRPtDkwWZylXtdE4EdG9zQNRXn6xdwnTb5HtgKs4YNVkGf6bbtmTDNj+4zmU3 6umz8HaCN31H5xvHQ1xwpDiKoGxnT1a2vWWnm4wBRwIpBUqCSjY+xnN9//ablq50nJ5/Dq sW6iAIWlelWQVAbBJE3NwgzEdouqQaX+t4AbxwfGN/dyWwd2CWcaTB7mmzjXRsJnrI4Ccj AuKW0s5wPQaO/hxCxLJUKali7u9R4byaxxSjyLDvHJ72HuUl8OZMORBec5Z8cJpAOG2/sM QAnwGfQVlRSirb9oM/ah+RNsPrUWOkVzW/kKg5MsHCXZFIII5YqAGnJcYuG/pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jPBWM5j3yzc8R for ; Tue, 10 Nov 2026 16:12:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id b453 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Nov 2026 16:12:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Abdelkader Boudih Subject: git: 2764bc54d5d3 - main - asmc: do not enable the sudden motion sensor on the MMIO backend List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: seuros X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2764bc54d5d35838c2aeccbfd2632625067283a5 Auto-Submitted: auto-generated Date: Tue, 10 Nov 2026 16:12:31 +0000 Message-Id: <6af3426f.b453.60c3528d@gitrepo.freebsd.org> The branch main has been updated by seuros: URL: https://cgit.FreeBSD.org/src/commit/?id=2764bc54d5d35838c2aeccbfd2632625067283a5 commit 2764bc54d5d35838c2aeccbfd2632625067283a5 Author: Abdelkader Boudih AuthorDate: 2026-11-10 16:12:06 +0000 Commit: Abdelkader Boudih CommitDate: 2026-11-10 16:12:06 +0000 asmc: do not enable the sudden motion sensor on the MMIO backend The interrupt filter reads the PIO interrupt port, but sc_ioport is NULL under MMIO; the capability test only probed for keys, which says nothing about the backend. No MMIO-capable machine has a sudden motion sensor anyway. It existed to park the heads of spinning disks. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D61383 --- sys/dev/asmc/asmc.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c index 3f43ff6d45d2..5714e2e58c49 100644 --- a/sys/dev/asmc/asmc.c +++ b/sys/dev/asmc/asmc.c @@ -557,13 +557,17 @@ asmc_detect_capabilities(device_t dev) uint8_t len; char type[ASMC_TYPELEN + 1]; - /* SMS: require all keys used by asmc_sms_init() */ - sc->sc_has_sms = 1; - for (unsigned int k = 0; k < nitems(asmc_sms_required_keys); k++) { - if (asmc_key_getinfo(dev, asmc_sms_required_keys[k], - &len, type) != 0) { - sc->sc_has_sms = 0; - break; + /* SMS: PIO only, the filter reads the PIO interrupt port. */ + sc->sc_has_sms = 0; + if (!sc->sc_is_mmio) { + sc->sc_has_sms = 1; + for (unsigned int k = 0; + k < nitems(asmc_sms_required_keys); k++) { + if (asmc_key_getinfo(dev, asmc_sms_required_keys[k], + &len, type) != 0) { + sc->sc_has_sms = 0; + break; + } } } @@ -1001,7 +1005,8 @@ asmc_sms_intrfast(void *arg) uint8_t type; device_t dev = (device_t)arg; struct asmc_softc *sc = device_get_softc(dev); - if (!sc->sc_sms_intr_works) + + if (sc->sc_is_mmio || !sc->sc_sms_intr_works) return (FILTER_HANDLED); mtx_lock_spin(&sc->sc_mtx);