From nobody Tue Nov 10 13:42:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jP7Br1Fkrz6ySlg for ; Tue, 10 Nov 2026 13:43:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jP7Bq6XFFz3Mp3 for ; Tue, 10 Nov 2026 13:42:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794318179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=12Gv8Ovci70StYHTsfARTR4k5ZGjTk1rnmTYrx6oidU=; b=F5PyYLqiB3Oogshpf54vHI3cwCuiaMuvx3fKYrl0ujW6dhS4KE9J3ibTpRaAb2bUlNRwlz MFbv4+pvfPYC/M1Vht3F6kObBwnYukdPSMosMmu+0WovoIhsH4+845Z+qo3dJu1eDVNLeg X4bnlf5g9LDO3dC1zW18RdZsTiwbkhE2IM58T9bAd6ZYlnRwZhiqoVl365sp5deBfp/4Ka Knxd7ZtAW878f5IulvVgJyOmN223UtHYh4SjqHCMkGNdA0jSsSQk4VzXvI1PTJaNi2oIIh pQ3GsSHJC+YrlIPvzMV1obEQzUb56gw70WelHiP7pTD6Bu+6z8prwhXcFzXknw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794318179; b=ZN6WSuQ71KnaNP9lNxR587246cP0/udZtz7Y5IH5r63kHIMYSB3hJOSGh0hHzM2Iv7u692 7WbMJygnuK2lw59qnYd/pmcZLI4kPKRcv8xQ27SH61+jdBCdm4B68cnHnZ++zAgo40jtrv kZOuHU4Ft4+vhcdMcSqlKsh59uRkLe7lhPolPzkUeQ5ir9GOv3OkCeeVUe1MHkHk8aJOpW VunT3fUvJpNazwJiSAshr/N/UYxBr698R7fP9AFSFrH6d8QA9j7P/gDib0o3aDDiJmWTX/ 1FpbEHdVezuWCmn+6WTh/zURGuUnEnmofed5kvK+otfFLrIdiF7ygSemt89lEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794318179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=12Gv8Ovci70StYHTsfARTR4k5ZGjTk1rnmTYrx6oidU=; b=NyJ6lzav0UKFg5IElD0K/kFOAecD7egsw/oTFoxYHt5LXDcG/DLOY1zc38zpP0NxDpHZCE 5T8BBd0OCZq8C0AdmqhfCTn5x84xSLS3ff+HSqUwzmHKfhSLKuWWS15d19qX8ygQaTKG4N Mtj4yTssgMHVZkkYsU9uPtf9NVJYP4d9gncNksXzNuvLdTSlp7bE0sTfn+p4JH0hmHBqHr FQ4pY0zRs0u93a4IrzHED6D9VGzzpDFjTXr3dggRFR/ctpnDZrts3hdPM7baEcG5mecqhb 8s+f1wwYBEwRT5WFwfsJ0m5b2TqpbyqNoEAdPo/OKL2TqMOMS7Eae/CYqrvUuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jP7Bq68dmzVMT for ; Tue, 10 Nov 2026 13:42:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1baf4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Nov 2026 13:42:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 7ea71c136c20 - main - axp81x: Do not change the voltage of a regulator in range List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7ea71c136c209e1aea05afb08f59c8917cff8325 Auto-Submitted: auto-generated Date: Tue, 10 Nov 2026 13:42:59 +0000 Message-Id: <6af31f63.1baf4.58b8900f@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=7ea71c136c209e1aea05afb08f59c8917cff8325 commit 7ea71c136c209e1aea05afb08f59c8917cff8325 Author: Emmanuel Vadot AuthorDate: 2026-11-10 08:02:41 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-10 13:42:45 +0000 axp81x: Do not change the voltage of a regulator in range axp8xx_regnode_init() set every regulator described in the FDT to its minimum voltage, even if the firmware had already set a voltage in the range. For a regulator that is in use, like the one of the CPU, this can make the system crash. Only set the voltage when the current one is out of the range. Tested on: A64, H6 --- sys/arm/allwinner/axp81x.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sys/arm/allwinner/axp81x.c b/sys/arm/allwinner/axp81x.c index eb1852895bf3..ed70d5477e0e 100644 --- a/sys/arm/allwinner/axp81x.c +++ b/sys/arm/allwinner/axp81x.c @@ -710,6 +710,7 @@ struct axp8xx_softc { #define AXP_UNLOCK(sc) mtx_unlock(&(sc)->mtx) static int axp8xx_regnode_set_voltage(struct regnode *regnode, int min_uvolt, int max_uvolt, int *udelay); +static int axp8xx_regnode_get_voltage(struct regnode *regnode, int *uvolt); static int axp8xx_read(device_t dev, uint8_t reg, uint8_t *data, uint8_t size) @@ -756,13 +757,21 @@ static int axp8xx_regnode_init(struct regnode *regnode) { struct regnode_std_param *param; - int rv, udelay; + int rv, udelay, uvolt; udelay = 0; param = regnode_get_stdparam(regnode); if (param->min_uvolt == 0) return (0); + /* + * Do not touch a regulator that is already in the range, the firmware + * set it, and some of them are in use, like the one of the CPU. + */ + if (axp8xx_regnode_get_voltage(regnode, &uvolt) == 0 && + uvolt >= param->min_uvolt && uvolt <= param->max_uvolt) + return (0); + /* * Set the regulator at the correct voltage * Do not enable it, this is will be done either by a