From nobody Tue Nov 10 13:42:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jP7Bk5yFcz6ySjN for ; Tue, 10 Nov 2026 13:42:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jP7Bk4k1tz3Mn4 for ; Tue, 10 Nov 2026 13:42:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794318174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LeSWgtQsArgqls7peF9WG/+KsDTAjLSqryIQ7yuWj4k=; b=EHG8NeorPuNOJPFl5JzpB0qqE5B7qvMN2EMcyTBmUNgj3j+gPSnx/O4gWvVvfF8X9BSD3P 49U21r0Muu4P7MPwWfQ1Urs7SJm1WQzl22WYxoA8vCMoGEIMJXr8ryD7OLlBrvkk+ffMov b2nF7AgDcUBGCYDgBdG4rXHcFntnWjULmoixmVJZfYsbU8aD/6bmGmAMx/tN7WEr965vPP lvLB359SHROcoNGFkeKePWNGEZwe5eocYUhr+xiWRPFyTKwZc06TbMLfEWhvagY2qFTVOD uDUncKzSeWq9vSvW0auK39v6zUeqBhZPb4wy+lnoD3rfJwJSxMkwbuvesnIKzQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794318174; b=VW/AHepHZjPM7BZH72q6UntRYX4ic97lRCRLkzcH4uFiBAjyzT0ljql5zhWgGixDXq+jxq Tt2CFyNaqDUd4/6KJt/iB83DE40pwPfrZvXrNqd/1boa/+DQdbzGnjb3Au6iaoiJpKmd7K cn6oXrb67JQYCBukW1txVgD6jK9d7xjB21Ghs7aI0bE2qjjZOxDceoijdhhnDO8vbsMEjX 3E+k3pzLgyHBb9DlbYwwf5ytrFmq9eGGLRyNkMga+LrBuqbkf8Tc3YOKI246esv3jw9Dux rP65mjvmD8HQAibY52J5KYU31bL+VvRCt7vdNFsAQpPVkRtexYQL7lSCR0z6zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794318174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LeSWgtQsArgqls7peF9WG/+KsDTAjLSqryIQ7yuWj4k=; b=wtRIj5vMIsPGCnkz0ut6TsMCV18rdp8PZn+f0P0dG/qA6Ptz+4rNAx3tXC/S2SR4e74MH8 xVP2G3jHOOXKKM/1G0cXQQ2YHdPL7VZqSwfbQ6uwNkXsiYs3EBDVW2+dJK6pL9QdAIibQ0 Ec7TO/n4X5oeFd76Bq7889A4OOxk8HcF66fNV/nkHn0xchKxbH+0IIt7XFqqdjIQaGoQ3k rAEcyMoMqbfhjt3k3txoYeIckb7gYjcyNW6Lx+Nt0v3Y60AeDe/WfY2n3GOFIdVrl5gI2l GaCp3GjwhxGPknNlGF7AVa6TVxonevTk4M59ZKOAeAn9Umk+Jo29wpLRkyRyeQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jP7Bk4PPCzTfX for ; Tue, 10 Nov 2026 13:42:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 194fc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Nov 2026 13:42:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 07448cd0c634 - main - axp81x: Fix the register accesses List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 07448cd0c6341793406fa0d7a2f33401be01c7a3 Auto-Submitted: auto-generated Date: Tue, 10 Nov 2026 13:42:54 +0000 Message-Id: <6af31f5e.194fc.46a6d7e3@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=07448cd0c6341793406fa0d7a2f33401be01c7a3 commit 07448cd0c6341793406fa0d7a2f33401be01c7a3 Author: Emmanuel Vadot AuthorDate: 2026-11-10 07:54:22 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-10 13:42:45 +0000 axp81x: Fix the register accesses The register pointer was written without IIC_M_NOSTOP, so the controller sends a STOP before the read message. On the Allwinner H6 (twsi) this makes the reads return garbage without any error. Set IIC_M_NOSTOP on it, and send the register and its value in a single write message, like the other PMIC drivers do. Tested on: A64, H6 --- sys/arm/allwinner/axp81x.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/sys/arm/allwinner/axp81x.c b/sys/arm/allwinner/axp81x.c index 2983ff09e296..b7d286276294 100644 --- a/sys/arm/allwinner/axp81x.c +++ b/sys/arm/allwinner/axp81x.c @@ -717,7 +717,7 @@ axp8xx_read(device_t dev, uint8_t reg, uint8_t *data, uint8_t size) sc = device_get_softc(dev); msg[0].slave = sc->addr; - msg[0].flags = IIC_M_WR; + msg[0].flags = IIC_M_WR | IIC_M_NOSTOP; msg[0].len = 1; msg[0].buf = ® @@ -733,21 +733,20 @@ static int axp8xx_write(device_t dev, uint8_t reg, uint8_t val) { struct axp8xx_softc *sc; - struct iic_msg msg[2]; + struct iic_msg msg; + uint8_t buf[2]; sc = device_get_softc(dev); - msg[0].slave = sc->addr; - msg[0].flags = IIC_M_WR; - msg[0].len = 1; - msg[0].buf = ® + buf[0] = reg; + buf[1] = val; - msg[1].slave = sc->addr; - msg[1].flags = IIC_M_WR; - msg[1].len = 1; - msg[1].buf = &val; + msg.slave = sc->addr; + msg.flags = IIC_M_WR; + msg.len = sizeof(buf); + msg.buf = buf; - return (iicbus_transfer(dev, msg, 2)); + return (iicbus_transfer(dev, &msg, 1)); } static int