From nobody Tue Nov 10 13:42:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jP7Bg60Mkz6ySjH for ; Tue, 10 Nov 2026 13:42:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jP7Bg3hCvz3Mdx for ; Tue, 10 Nov 2026 13:42:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794318171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=alspnHPJB8Zxhh+0zygGC1C9J+VxN/eE9ibmMRVcd5w=; b=FXUzzP6sTtKLFyDsR++Z1VLgR37IWYZxG7db0mWZJLgzhz8t6HR4f68bWpPiBxqV0NBP+E rHJbdombj3fMv8mCYhzGIsG37mJ90AophyjNuSo2W5sWxcrgQxa7Xu06bPXt6d6uYkKROI F0m//GsIdedu1VXMk40nEyu7QMXGRWUfLV4AcrjuwCTGa2qeLFludkYlUKxdNTynB98FYR Dz9NfVT6ec0Q0u/PBaBml6e8eqdpiFU0EbWRaZpROnXsHCgwtmTbH4VSsVaSew64nxm7oe nsTM4M6tC70JvO5+irQJo2sLIg2bxrX4wv5W49IqOl9/QJL4YgAkROBCJzN6Fg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794318171; b=C/uXv7+3xBehpXSMXXzr+mYB5kYBqQiicEazZaw/5OSDGY2vqcGItMGPjPBUXkvurbLcLW 2dVt53woZCkga0qiavLPw4myNeoiP/gehUyUvmoxDhCt4bYAEwEsVUlPXIo44cG8Wk9Thi BA3NEAoK2TUZwmSqohMMydlf0Lcg6onWkM7UqwzZHOSCVJpQR6siHBlIAo9vwGYy9f+WZz GhTkLns/n0ubKjnin5ReeTFEMkAvezUCawauUr+u7vpFeukf6hlaEJ9rc7zQZYOSkz3lHv GutGtlEm63/X4Yy38O+qhlqeVsz+6M+200pITl+voUsL6asGEzSFDkYryi2TfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794318171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=alspnHPJB8Zxhh+0zygGC1C9J+VxN/eE9ibmMRVcd5w=; b=pPGh7dC3S1j7lNGOSxhxnq2jwxr4pmxsUk6kM/KfnU61nH0tH5/HhfYBPgbE812/3jwCst ge0nL46K+B6tNY4fST7l1tAmIsvhK6Ch+usOu+oHxFpC7lHR4onWQrN3Ls5ypOfthU/D8Q 1jwAEa0XpJPG8DNOepAi9GplHa/REnUliSbmJwwbBoOeBccSWchNKpgEBE9qTZ+B6VYY/h ys3d1vaCf0wIHdnSjmUBM/tahq3eDPwZePO/Uj5GrPfFe7AV8dtqoR/g0X76tnD2WwajJm sVxARSlWYe5/HokrZow4Eww+jTLP/qAzNOB1oUNKGFKEa7QVeQZy00euEmc0bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jP7Bg3LD4zV7D for ; Tue, 10 Nov 2026 13:42:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1a558 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Nov 2026 13:42:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 09624daf6485 - main - aw_rsb: Accept a write in a single message List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 09624daf6485be05dee9d6110b0488589da06e20 Auto-Submitted: auto-generated Date: Tue, 10 Nov 2026 13:42:51 +0000 Message-Id: <6af31f5b.1a558.12e2fdcc@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=09624daf6485be05dee9d6110b0488589da06e20 commit 09624daf6485be05dee9d6110b0488589da06e20 Author: Emmanuel Vadot AuthorDate: 2026-11-10 08:34:49 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-10 13:42:44 +0000 aw_rsb: Accept a write in a single message The driver only took a write as two messages, the offset and then the data. A write on an I2C bus is a single message that starts with the register, which is how a driver that can be on I2C or on RSB, like axp81x, does it. Split such a message into the two the controller needs. Tested on: A64 --- sys/arm/allwinner/aw_rsb.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/sys/arm/allwinner/aw_rsb.c b/sys/arm/allwinner/aw_rsb.c index 7ff4d754127b..5a20284a5f8e 100644 --- a/sys/arm/allwinner/aw_rsb.c +++ b/sys/arm/allwinner/aw_rsb.c @@ -273,6 +273,7 @@ static int rsb_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) { struct rsb_softc *sc; + struct iic_msg wrmsgs[2]; uint32_t daddr[2], data[2], dlen; uint16_t device_addr; uint8_t cmd; @@ -280,6 +281,24 @@ rsb_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) sc = device_get_softc(dev); + /* + * Also accept a write of the offset and of the data in a single + * message, which is how a write is done on an I2C bus. + */ + if (nmsgs == 1 && (msgs[0].flags & IIC_M_RD) == 0 && + msgs[0].len >= 2) { + wrmsgs[0].slave = msgs[0].slave; + wrmsgs[0].flags = IIC_M_WR | IIC_M_NOSTOP; + wrmsgs[0].len = 1; + wrmsgs[0].buf = msgs[0].buf; + wrmsgs[1].slave = msgs[0].slave; + wrmsgs[1].flags = IIC_M_WR; + wrmsgs[1].len = msgs[0].len - 1; + wrmsgs[1].buf = msgs[0].buf + 1; + msgs = wrmsgs; + nmsgs = 2; + } + /* * P2WI and RSB are not really I2C or SMBus controllers, so there are * some restrictions imposed by the driver. @@ -288,7 +307,8 @@ rsb_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) * a write, containing a single data byte offset. Data will either * be read from or written to the corresponding data byte in the * second message. The slave address in both messages must be the - * same. + * same. A write can also be a single message, the first byte is the + * offset. */ if (nmsgs != 2 || (msgs[0].flags & IIC_M_RD) == IIC_M_RD || (msgs[0].slave >> 1) != (msgs[1].slave >> 1) ||