From nobody Tue Nov 10 10:28:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jP2tl2SBnz6y9Rm; Tue, 10 Nov 2026 10:28:47 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jP2tl0fBVz4Y7S; Tue, 10 Nov 2026 10:28:47 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794306527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vZQIkzqgzHYE3Q8+6Kv5TSMQoj3W3VcJpW+byH9yDiM=; b=KmgI0gZh1M0c5YM3/tEnEi72KLXuzNhfyyZBFn6lqWMQPn1f0pHGtT0/ez/QDibZQ4W2N0 ZIGiqSFytoNl47lDNBbZtmFl7FdxaWopFnBiYzSubjfQaYSUWG5sVx/XIXeIB02ST5Fkjl IwO/nOXtofu2flQpPoa+iTRefFjW9pBth/ct/d0ytWfCbVFyHwpv9lZPKo0WR+U1n7dFuG ETzLqJJ+X+yLRkZ2jy5JE34GNsW2gZOh7Knwt6VagF7kqFvZeYxs0oHE6HSXb1xlfJvfe/ btdminA0BhKaznGqEyRkr3ZlO2pbT6bW2SUlKfWBkATQPPxNhBUqqo1J1N55cA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794306527; b=bNNkMedQ9KI1oWv+wY29j5wVjGIIeUvhaqpY7aR6r5H41Dyimwd9uIGTBLw0erm+aDTOJQ llcb3fvTKzU9HxikUVK0C503Rpx8nNyFpYTFA5sCgckyKGbKS4s+kS7l+eHXTSCrybAA2M 4EnULsHJ/RE9UwYd1dxmKrhlFGXYrNyw22JEMyNs5wllmEn+oMNDZ2G7ayuWxyV+q6MRkq /qAUtV240X1L1BksnPB61t9L5s5tvgT7A+9Sv+rdLNI44rGpvOBW6YQ5erIJH8fsgBiSkP HDd26JT6eWSOM0mtqbei4r5YMkkhpzpdh1t7r6ShSHLzDP34WN7vkg+7vqHdMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794306527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vZQIkzqgzHYE3Q8+6Kv5TSMQoj3W3VcJpW+byH9yDiM=; b=Hc/EOwEEN75UYtWb9SnrEE9S4Eww9pcteALA8NSqGXDZ9DnefxRV20uPIGM8N/WJaune/9 ftBtF+xKe5ZG63uqj2i7KMECiJ4DEy/LMKIjv7NcuQ/nBgEqF47/wSEzhvM18Q1/cU2yxw QB2+2GaVL2iDOHEQyu8byvillXeLm323UBROhSSgRXTzurQj7MF05sMX4JS/VuXGNWSVX9 h4JFeaSih4ZaX5GEYAnTsQMyCtZP0GR2YBc17Ug9Wc8Ujfex91nzvshI4iNQDzlON1QgqU SefP94lSQGgqA8X9xkb5gAJWLLjHcgb4V59sWog/jjIZQiIv9LTknUzCSQePrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2a02:c6a0:4015:12:4cf2:43df:d016:dec1] (unknown [IPv6:2a02:c6a0:4015:12:4cf2:43df:d016:dec1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jP2tj6x06zpFh; Tue, 10 Nov 2026 10:28:45 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Message-ID: <43e365e3-b9d4-4860-bf83-4790c16b7681@FreeBSD.org> Date: Tue, 10 Nov 2026 11:28:33 +0100 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: bfe4be85a935 - main - tpm_crb: wait for idle and locality release after each command To: Kevin Bowling , Ed Maste Cc: Olivier Cochard , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <6aecdfb7.18847.3d7dee3c@gitrepo.freebsd.org> Content-Language: en-US From: Michael Tuexen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/10/26 00:51, Kevin Bowling wrote: > On Mon, Nov 9, 2026 at 4:14 PM Ed Maste wrote: >> On Thu, 5 Nov 2026 at 14:57, Olivier Cochard wrote: >>> The branch main has been updated by olivier: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=bfe4be85a9354b92135e105028f2e1b3e0307ada >>> >>> commit bfe4be85a9354b92135e105028f2e1b3e0307ada >>> Author: Olivier Cochard >>> AuthorDate: 2026-11-04 21:05:22 +0000 >>> Commit: Olivier Cochard >>> CommitDate: 2026-11-05 19:51:20 +0000 >>> >>> tpm_crb: wait for idle and locality release after each command >>> ... >>> + device_printf(crb_sc->base.dev, "Failed to relinquish locality\n"); >> On a Framework 13" AMD Ryzen 7840U I'm now seeing this message emitted >> every 10s. > Can you try the following to help dump what is going on? Sure. I get: Nov 10 11:23:06 fb13 kernel: tpmcrb0: Failed to relinquish locality: LOC_STATE before=0x83 last=0x83 LOC_STS=0 CTRL_REQ=0 CTRL_STS=0x2 > > --- a/sys/dev/tpm/tpm_crb.c > +++ b/sys/dev/tpm/tpm_crb.c > @@ -553,7 +553,7 @@ > tpmcrb_relinquish_locality(struct tpmcrb_sc *crb_sc) > { > struct resource *res = crb_sc->base.mem_res; > - uint32_t mask; > + uint32_t before, mask, state; > int timeout; > > if (!crb_sc->has_locality) > @@ -562,6 +562,7 @@ > /* PTP 1.07, Table 37: the other fields mean something only if valid. */ > mask = TPM_LOC_STATE_VALID | TPM_LOC_STATE_ASSIGNED; > > + before = bus_read_4(res, TPM_LOC_STATE); > bus_write_4(res, TPM_LOC_CTRL, TPM_LOC_CTRL_RELINQUISH); > > /* > @@ -571,14 +572,19 @@ > * pause so a release during it is not reported as a failure. > */ > for (timeout = TPM_TIMEOUT_C;; timeout -= tick) { > - if ((bus_read_4(res, TPM_LOC_STATE) & mask) == > - TPM_LOC_STATE_VALID) > + state = bus_read_4(res, TPM_LOC_STATE); > + if ((state & mask) == TPM_LOC_STATE_VALID) > return; > if (timeout <= 0) > break; > pause("TPM locality", 1); > } > - device_printf(crb_sc->base.dev, "Failed to relinquish locality\n"); > + device_printf(crb_sc->base.dev, > + "Failed to relinquish locality: LOC_STATE before=%#x last=%#x " > + "LOC_STS=%#x CTRL_REQ=%#x CTRL_STS=%#x\n", > + before, state, bus_read_4(res, TPM_LOC_STS), > + tpmcrb_ctrl_read_4(crb_sc, TPM_CRB_CTRL_REQ), > + tpmcrb_ctrl_read_4(crb_sc, TPM_CRB_CTRL_STS)); > } > > static bool