From nobody Mon Nov 09 19:14:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jNfbP5Y1Vz70LJC for ; Mon, 09 Nov 2026 19:14:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jNfbP4Y9Sz4TQB for ; Mon, 09 Nov 2026 19:14:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794251649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vymHPB5VIojo2mm46Jkx9cqEVwwSqFlIPHfV+mA3UFQ=; b=QOHvEpDNHCqSe1cAd/QFfsdZHPKB+1JIPhhthTUafGjqytvyMSGtROka0lJtULAp51gJIT A8nIl3KoIFpHbPt4nPqt4ma1E13kIpfhOmly8Fvz0xBeVIk0xky6H5yMOGcQPxFcOgcUID FSW8CjEo1mPm5L9vRZ9rqTaP1BE1Z5U+STZC3gQwnALQg/YNsOxdm07SD4O9/n2tKRsmc1 uEI5K1dD2cn170Xwk6uYA6fRsFKSz8iPZEh7qpydesViqPzN7tHZy1eO4UQUrT66FiUigk byVdtCsFGA4Zjz/a8KIBKr3ZgvOWRW8P4B3cj2fsoa7x3z86Jj7wm7prdHGUbg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794251649; b=XUGHoMpNbJlzwgJ7er+5HjZMmQPwsGaS8gyjQQyezmfzP31phR9VWdAxqevVF8KJniGywL ZqWjSaIYjtFaDg0hVd1/6mHagkMYBK7KLAAk2wuQBKvuvHwjYyK/AAuBz1lIelEziPeoYd uahHv6QDRZM9onm6/TE0VPKxLyKlnkQc0i4WnKxOFoNaN1rJFv/sy4lKZZ7vFNHwbReDFz W60Sg4JFM+WQJZU0BbSx8ALy41ujspDuvWjdfXkg8GCjTfNMeLeM+72Ag+iO1dImtyLsQo 6ABgTLVZZCpmHOCHPw+epwPhRcyawWwrwO1RvY4VrzIcl/lA9TBOrwnFvLz7Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794251649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vymHPB5VIojo2mm46Jkx9cqEVwwSqFlIPHfV+mA3UFQ=; b=Xq+kQIxdl95zqURUBDypDVnNzqmodsOJpEyvZFYffuO3DI7xElnawaPiWvghJyqYV+9aPD BdYQMUUlw+KMNb0GF1LG6fmCTvmPC3lFVEsRnbv20ZJeW8tJcDErUqXknFyqD1Z78jH1wf VPI62KDmvqrOd1CnvUHHyocYnEFqbjBN9tgIIzF6BuGXMgfgfgL0z3qRXhcUOHDzoSFwI3 rOx8Vpd/b+3CxuFljCLd5436AKWSv4tMu59s2a6DmipbwU9TUoenvRtwBuYH80d+oaj996 OBufGIqGuTJtWuZO9LRme5tGcdBYKQNCP6j8PNtAOBSZXHCoqBgNCtVumEZKAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jNfbP46hDztjb for ; Mon, 09 Nov 2026 19:14:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id d63d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Nov 2026 19:14:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kenneth D. Merry Subject: git: 86b9d629c68f - main - nvme: Fix the data length in the Reservation Report command builder List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ken X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 86b9d629c68f6dc63543b9c0a6da6c96c857f3bc Auto-Submitted: auto-generated Date: Mon, 09 Nov 2026 19:14:09 +0000 Message-Id: <6af21b81.d63d.6c4dfa98@gitrepo.freebsd.org> The branch main has been updated by ken: URL: https://cgit.FreeBSD.org/src/commit/?id=86b9d629c68f6dc63543b9c0a6da6c96c857f3bc commit 86b9d629c68f6dc63543b9c0a6da6c96c857f3bc Author: Kenneth D. Merry AuthorDate: 2026-11-09 18:46:58 +0000 Commit: Kenneth D. Merry CommitDate: 2026-11-09 18:59:13 +0000 nvme: Fix the data length in the Reservation Report command builder nvme_ns_resv_report_cmd() put its length argument, which callers supply in bytes, directly into cdw10. The NUMD field is a 0's based count of dwords, so the command asked the controller to transfer nearly four times the size of the supplied data buffer. In practice controllers limit the transfer to the length described by the PRP entries, which is why this worked in testing, but the command was incorrect. Convert the byte count to a 0's based dword count in the builder. Reported by: llm-postcr Fixes: 7a9e4375316b MFC after: 1 week Sponsored by: Spectra Logic Co-authored-by: Claude Fable 5 --- sys/dev/nvme/nvme.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h index 34929ee58f5e..ee39a101f48c 100644 --- a/sys/dev/nvme/nvme.h +++ b/sys/dev/nvme/nvme.h @@ -2274,7 +2274,8 @@ void nvme_ns_resv_report_cmd(struct nvme_command *cmd, uint32_t nsid, { cmd->opc = NVME_OPC_RESERVATION_REPORT; cmd->nsid = htole32(nsid); - cmd->cdw10 = htole32(length); + /* NUMD is a 0's based count of dwords; length is in bytes. */ + cmd->cdw10 = htole32(length / 4 - 1); cmd->cdw11 = htole32(report_type); }