From nobody Mon Nov 09 18:36:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jNdmW3cX3z70H8R for ; Mon, 09 Nov 2026 18:36:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jNdmW1kVrz4HJW for ; Mon, 09 Nov 2026 18:36:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794249419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1FC+RD5kbUpSbTpzQl3upLoLxXizUXJYWo+Xe9qDid4=; b=PYhdwf5lKmHl3cZbkgriM/s57oLVfn5sgD8Wt8QG2rkvBS1/UCjigYp5UcWkS9hoSI6Zbv umcuHmunOIlihcqz6SZOKovmfVKrR/7Mu4aAqBUXZS8gdN7a3w4GDlm3BDheJAJdBoE626 ppR0N72b6cCuSVBsr0UQ1vYMqyNlkdgWHaiPTEJLau/+TZ01GACBk0KAIllRdqEInZi9Qv J0og0guUquLaRgO6Kmy1O/YH8vlRnQKSYhItnlG8CDfrzGB/XzqtNQvi/bOphirusbGj4z VHNAzGw+7LAP7HN0VwRWJ628lFvS4NQTki1OZXrRLuGc617KSOW7eyQ6S/2F0A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794249419; b=b6aj4Gqt89iYaBr27chg1Z2RgMdabS5jRsjW9QzfaWNn92fNSymDSyON+dc2PsCnAs9vld Q/Qj5MsI3wMWrCPISaPYaHRPrZPRSUu1tPd88cDimR8fCRDD77fz1hZpcix4y0Btj6EzIG KKoHB95emOJYreqcD6BqVPFLJGtmMTMKyehHl5YQqBKol2dzZwfC1kU8nzQHlEbo7GIXrG MyHxk98TVwSO/fzixyON55TWPEYkhapfFxT3hFtnTxxQaYzwGPVaqQ3PLmlFfD1UL4uNER E+8AjI7QgoewUbd1Mr+nei6NIS6yiZYBREQ+bECDoAsaw0aHbqNtd4FFmZfASQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794249419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1FC+RD5kbUpSbTpzQl3upLoLxXizUXJYWo+Xe9qDid4=; b=msnkgxpalrWBuRyGC1MI7+6LnTNBqF3q7TauK+nLpIbvdZOaDEZpn3yEIE/7McVZi9fbuZ ZDdrWZMAJevyNT5Q4snA9viQ4yIvjrOv8wYC8T/LGZI9QuE7bn19/eVOpyMSipcPle3k8A Pe9dE92zvb07HbGVdF53sxNyEutJkBDfDpwIgd67nKrttOE7A6uBLX9I3apAxpt+PQK5rF C2DLcS3wlKmNpkF5vvka5SeOR+u3MBU10fadQs3OIOF0ow0b3Pa7DLEHxr/3WL2fFLpdyE 1kGDwWO16QFJhFTX/z8vBla0D8gMmzEav57TLKk7Km+EGX9rqAvXDWeyzedfdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jNdmW12VHzswW for ; Mon, 09 Nov 2026 18:36:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id b17f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Nov 2026 18:36:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Abdelkader Boudih Subject: git: b391f3f3e007 - main - asmc: Fix style(9) issues List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: seuros X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b391f3f3e007c067a7e4475d91d981f91add0596 Auto-Submitted: auto-generated Date: Mon, 09 Nov 2026 18:36:59 +0000 Message-Id: <6af212cb.b17f.66ad3eef@gitrepo.freebsd.org> The branch main has been updated by seuros: URL: https://cgit.FreeBSD.org/src/commit/?id=b391f3f3e007c067a7e4475d91d981f91add0596 commit b391f3f3e007c067a7e4475d91d981f91add0596 Author: Abdelkader Boudih AuthorDate: 2026-11-09 18:35:57 +0000 Commit: Abdelkader Boudih CommitDate: 2026-11-09 18:35:57 +0000 asmc: Fix style(9) issues fix operator and comma spacing and three long lines MFC After: 1 Week Approved-by: ngie (co-mentor) Reviewed by: ngie, imp Differential Revision: https://reviews.freebsd.org/D61302 --- sys/dev/asmc/asmc.c | 5 +++-- sys/dev/asmc/asmc_debug.c | 5 +++-- sys/dev/asmc/asmc_pio.c | 2 +- sys/dev/asmc/asmc_sysctl.c | 7 ++++--- sys/dev/asmc/asmcvar.h | 2 +- 5 files changed, 12 insertions(+), 9 deletions(-) diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c index b91a0315e65c..cff1b3bf3311 100644 --- a/sys/dev/asmc/asmc.c +++ b/sys/dev/asmc/asmc.c @@ -81,7 +81,8 @@ static int asmc_backlight_update_status(device_t dev, struct backlight_props *props); static int asmc_backlight_get_status(device_t dev, struct backlight_props *props); -static int asmc_backlight_get_info(device_t dev, struct backlight_info *info); +static int asmc_backlight_get_info(device_t dev, + struct backlight_info *info); /* * SMC functions. @@ -236,7 +237,7 @@ asmc_attach(device_t dev) /* Probe SMC keys to detect capabilities */ asmc_detect_capabilities(dev); - /* Auto-detect and register voltage/current/power/ambient/temp sensors */ + /* Auto-detect voltage/current/power/ambient/temp sensors */ asmc_detect_sensors(dev); asmc_sysctl_add_fan(dev, sysctlctx); diff --git a/sys/dev/asmc/asmc_debug.c b/sys/dev/asmc/asmc_debug.c index 2826ed5cbfca..29d7983d1a8e 100644 --- a/sys/dev/asmc/asmc_debug.c +++ b/sys/dev/asmc/asmc_debug.c @@ -145,9 +145,10 @@ asmc_raw_value_sysctl(SYSCTL_HANDLER_ARGS) return (EINVAL); memset(sc->sc_rawval, 0, sizeof(sc->sc_rawval)); - for (i = 0; i < sc->sc_rawlen && hexbuf[i*2] && hexbuf[i*2+1]; i++) { + for (i = 0; i < sc->sc_rawlen && hexbuf[i * 2] && + hexbuf[i * 2 + 1]; i++) { unsigned int val; - char tmp[3] = { hexbuf[i*2], hexbuf[i*2+1], 0 }; + char tmp[3] = { hexbuf[i * 2], hexbuf[i * 2 + 1], 0 }; if (sscanf(tmp, "%02x", &val) == 1) sc->sc_rawval[i] = (uint8_t)val; } diff --git a/sys/dev/asmc/asmc_pio.c b/sys/dev/asmc/asmc_pio.c index 12847d4979ba..d39dd55bd103 100644 --- a/sys/dev/asmc/asmc_pio.c +++ b/sys/dev/asmc/asmc_pio.c @@ -218,7 +218,7 @@ out: /* * Get key info (length and type) from SMC using command 0x13. * If len is non-NULL, stores the key's value length. - * If type is non-NULL, stores the 4-char type string (must be at least 5 bytes). + * If type is non-NULL, stores the 4-char type string; it needs 5 bytes. */ int asmc_pio_key_getinfo(device_t dev, const char *key, uint8_t *len, char *type) diff --git a/sys/dev/asmc/asmc_sysctl.c b/sys/dev/asmc/asmc_sysctl.c index 38ef894a978f..6a6e482e9d63 100644 --- a/sys/dev/asmc/asmc_sysctl.c +++ b/sys/dev/asmc/asmc_sysctl.c @@ -56,7 +56,7 @@ static const struct asmc_cause asmc_cause_table[] = { { -2, "power-supply", NULL }, { -3, "temperature-multisleep", NULL }, { -4, "sensor-fan", NULL }, - { -30, "temperature-overlimit-timeout",NULL }, + { -30, "temperature-overlimit-timeout", NULL }, { -40, "pswr-smrst", NULL }, /* power supply watchdog reset */ { -50, "unmapped", NULL }, { -60, "low-battery", NULL }, @@ -823,10 +823,11 @@ asmc_mb_sysctl_fanmanual(SYSCTL_HANDLER_ARGS) val = (buf[0] << 8) | buf[1]; /* Modify single bit */ - if (v) + if (v) { val |= (1 << fan); /* Set to manual */ - else + } else { val &= ~(1 << fan); /* Set to auto */ + } /* Write back */ buf[0] = val >> 8; diff --git a/sys/dev/asmc/asmcvar.h b/sys/dev/asmc/asmcvar.h index 41c963021e9c..7d9495536552 100644 --- a/sys/dev/asmc/asmcvar.h +++ b/sys/dev/asmc/asmcvar.h @@ -51,7 +51,7 @@ struct asmc_softc { int16_t sms_rest_x; int16_t sms_rest_y; int16_t sms_rest_z; - struct sysctl_oid *sc_fan_tree[ASMC_MAXFANS+1]; + struct sysctl_oid *sc_fan_tree[ASMC_MAXFANS + 1]; struct sysctl_oid *sc_temp_tree; struct sysctl_oid *sc_sms_tree; struct sysctl_oid *sc_light_tree;