From nobody Mon Nov 09 16:08:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jNZTW3SZLz702F4 for ; Mon, 09 Nov 2026 16:08:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jNZTW1Dlcz4lT6 for ; Mon, 09 Nov 2026 16:08:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794240527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M5IkHmflKt+tUMXMqej2gy7SIoyiqLUl1k3KnBmJKDY=; b=PfbjBGCW9I6DjVs+KJ+9u9y/PqWzY8B6ezcW59R8NsNbD5izyR6TjvnzRKCc8XqRAu+vYh lTrlsVU+mahuHGrMX3KDbSUs6JnJ8HzyhoCEnwItRRIb9EF3UEnyRgMjYiOEOMH3GhzyiO MrN0PzA7aRsVKeHnkYlVL2uePirQ3mr1aeqKQC26cu+bJ8UPyarExhkdOR0LQA0xGwGfKg /sJXXvtEGM5bECwFN3d9J/Iqiw9YWLZ60VGSEHncrwESKSbPTJlsJC21vfeDoHt2fTEUiH ikNzA/VAOErYGLlBC13vLGFNJJ5ATx2JLlrAlbkKQgFjqWVNOrVenmvG+o8xUw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794240527; b=gVms50SNFlI6CsYKalhQCyXt0YhQds05Q1Q5OHd1O7vt+DiBIDy5A7dH64hcZx64XzkIQ6 kBQO9cRrNBOTBPfIIJzXwR37SWCqvvDfvSP2P/fSpoqunWk069DpTzRRg5FPrrMtIC7aul 7KbMvkgzSYnJxaurGRycA6WMWg5HEXJ+dfut60Gj/vzGCxh3qmD9BX8EzyDaX4NxBBZOKA WexGoBdt/L9B+j7PvrLjryur/AcxvBbFUCOJfx3Zfh0fGlFsnUpZE9QjREoivGocMhbWC+ VneFp5nL98ivSZnv8/rytvHPP+Q/Na+b0PBtfDy3vyiwLi59i7D8Pv9YwWj3Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794240527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M5IkHmflKt+tUMXMqej2gy7SIoyiqLUl1k3KnBmJKDY=; b=e7QouStgGlz7uR6GSjkwxD4gzlb8jhb5FbIYdzniC0Oke/tmDkB2Y+JklofucbyT56H3sh GIvniqXE/9WKoCK+CJFIA3kT3A3i44Gx1OqgKcTOr/UdJkFlCgtbh8ygJClPt0uhjjEQNo aiss2bSj2FdZhUdllLojM7pnO4wZ2dXJV+xrJRKnO1CV4VLMvDfASvp7LECkTu4vTeR3zJ uaRkP3DX7GIKjZl1OG/cx4uHw4W7hCBgvA8oXhDZb9xBLABhYjZl+YYgfu5lO6WWPwf9dn VUdEtb6pCQyooRWlN0ltXQpibCd+umsU9JGA9aN7INkC2SRMrnjQd8NBZoimDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jNZTW0vwnznVc for ; Mon, 09 Nov 2026 16:08:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21ec6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Nov 2026 16:08:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andre Silva From: Mitchell Horne Subject: git: e67b4c879ae1 - stable/14 - hwpmc: release a PMC whose ID could not be copied out List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e67b4c879ae16264915de6b5945f7b41bccdd14c Auto-Submitted: auto-generated Date: Mon, 09 Nov 2026 16:08:47 +0000 Message-Id: <6af1f00f.21ec6.2a6b05@gitrepo.freebsd.org> The branch stable/14 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=e67b4c879ae16264915de6b5945f7b41bccdd14c commit e67b4c879ae16264915de6b5945f7b41bccdd14c Author: Andre Silva AuthorDate: 2026-11-06 15:20:08 +0000 Commit: Mitchell Horne CommitDate: 2026-11-09 16:08:04 +0000 hwpmc: release a PMC whose ID could not be copied out If copyout of the newly allocated PMC ID fails, the caller cannot use or release the PMC. Release it in the kernel. Reviewed by: mhorne MFC after: 3 days Sponsored by: Advanced Micro Devices, Inc. Differential Revision: https://reviews.freebsd.org/D60562 (cherry picked from commit e5a48c8e0dd026ba953cf401c4dec02f76078aa2) --- sys/dev/hwpmc/hwpmc_mod.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/hwpmc/hwpmc_mod.c b/sys/dev/hwpmc/hwpmc_mod.c index 31f1805412db..a5725468e47f 100644 --- a/sys/dev/hwpmc/hwpmc_mod.c +++ b/sys/dev/hwpmc/hwpmc_mod.c @@ -4280,6 +4280,12 @@ pmc_syscall_handler(struct thread *td, void *syscall_args) break; error = copyout(&pa, arg, sizeof(pa)); + /* + * The caller never learns the ID of an unpublished PMC; do + * not leave it (and the row it holds) behind. + */ + if (error != 0) + (void)pmc_do_op_pmcrelease(pa.pm_pmcid); } break;