From nobody Mon Nov 09 16:07:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jNZRZ6d1Yz702BK for ; Mon, 09 Nov 2026 16:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jNZRZ4DLrz4j66 for ; Mon, 09 Nov 2026 16:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794240426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C63fBVYvzA+clzidcVVDbMUWFjjeC3eAMZhvtn4MjSc=; b=qSmScFyAiAO42yACDjXzJt1keRMGgRTIIvISAVYN1VmWk4HmbdgBxJrjWPmNZCK0upEbQS vIGuKN7HALHoIZng4Dyau5IBNYy++K+1flBURilgYvRvwp7Z9g5WqjDymllGaWvTZk2UOa in12x0pxQYJTui+Y7E6Qsqbqme2Dxfy/AH6B4wfT80zcYKe1xDlC+TYb8F9wqShXQJBs3l xDyUbNX1J8ji49W3qQEt4AMXbjSeQNaw8a+Ic5zR0nohEpLjECSFJJ7eC0FfyWme1+EO5z wOPcg6j1sjDyzsupYmeiZRF0W3oZKPl/jOWflN0vWQPJa/nGFQAHN3V0ctG8Aw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794240426; b=DwAU/oGhjpgDg+HZVStSBTaOMZl3QGLaC/XAHNck9JrQrPhFrp2xaV6NdqqvEkr7WG1dbb Nx0eEXVIKLxvzVzroQSD0NJLYRi+jSYuOw4zgqdB+2paIjtdeOccdpmnKHvzQcfZJwQmKV enYebNThbQW9UaXjSE+Qv97hw7f+CU5pOk9Y7o8qcWBdy2OVX0hwVBtFkLsrKK+saAivmk 1Pm+bYEu27pFmZeYZaMgkwXEg21SD+Fjq6QKRGzz2zhogZWFMssXbwX0tHD7Kbu4rjhrvs TaCp7c2TqSzEODzq7J4u4BwPrRUKXv+d52unLlCUFGWhrt9LdlXTgmyTsglalA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794240426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C63fBVYvzA+clzidcVVDbMUWFjjeC3eAMZhvtn4MjSc=; b=szN71ZJgR496K5TDXC7Srqs18K9c8wqe1+b6zQRcoSemVUUfW4QFQikFHXDjO8eysEqrmn cetCeaYKmbs2T8ViSHJsmCwPtWnGc3evtZXdNYERmV79+A4esLnwC6SDUE4DTEIA+PSXZu Qnymcv+HAKFl95jKmPRcHEF0zo1f0hBRye7QTXYNtQkHrTrKK+H1E1uwXRRdJ9t/kTpkKd QwdrHVCk9/hnDoDu7F1oKO2ijeWMSi+p9XHnVWWbTNaK4b9R3le2yUCHGNPx1SlKFplpqJ NoiBxmJPDv93HFkkBPFQuzjKWUBur+3c50uJTGc+D5QUwsBQhGAwVThk+5ocWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jNZRZ3NDsznVZ for ; Mon, 09 Nov 2026 16:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 211e6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Nov 2026 16:07:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andre Silva From: Mitchell Horne Subject: git: ebecf6848945 - stable/15 - hwpmc: release a PMC whose ID could not be copied out List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ebecf68489454f475fb30680bc9d179f1c614e7f Auto-Submitted: auto-generated Date: Mon, 09 Nov 2026 16:07:06 +0000 Message-Id: <6af1efaa.211e6.2a8c7340@gitrepo.freebsd.org> The branch stable/15 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=ebecf68489454f475fb30680bc9d179f1c614e7f commit ebecf68489454f475fb30680bc9d179f1c614e7f Author: Andre Silva AuthorDate: 2026-11-06 15:20:08 +0000 Commit: Mitchell Horne CommitDate: 2026-11-09 16:06:46 +0000 hwpmc: release a PMC whose ID could not be copied out If copyout of the newly allocated PMC ID fails, the caller cannot use or release the PMC. Release it in the kernel. Reviewed by: mhorne MFC after: 3 days Sponsored by: Advanced Micro Devices, Inc. Differential Revision: https://reviews.freebsd.org/D60562 (cherry picked from commit e5a48c8e0dd026ba953cf401c4dec02f76078aa2) --- sys/dev/hwpmc/hwpmc_mod.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/hwpmc/hwpmc_mod.c b/sys/dev/hwpmc/hwpmc_mod.c index c5771f8a0fe7..7ce83ad85bed 100644 --- a/sys/dev/hwpmc/hwpmc_mod.c +++ b/sys/dev/hwpmc/hwpmc_mod.c @@ -4277,6 +4277,12 @@ pmc_syscall_handler(struct thread *td, void *syscall_args) break; error = copyout(&pa, arg, sizeof(pa)); + /* + * The caller never learns the ID of an unpublished PMC; do + * not leave it (and the row it holds) behind. + */ + if (error != 0) + (void)pmc_do_op_pmcrelease(pa.pm_pmcid); } break;