From nobody Sat Nov 07 04:06:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jM2Y93m3cz6y3R5 for ; Sat, 07 Nov 2026 04:06:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jM2Y91kZLz4r8N for ; Sat, 07 Nov 2026 04:06:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794024397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AKhK4gc/x7lOrieOR24bd9HoeD4kv55GozLveQnQlNM=; b=CFt2PMRZs6ggU3nlk8ARQazUSYh6tBTc35S3XqvyW/0lf1QlvWusWUoiHVhSLEPM6JuZbU OLVb8+SCDdgRTKXgBOFAs/k9bDAY91P9CxhczyCPdL6jQgbCHkRbgP7ltJP3Hpufd/rEdC QNwPOgPQKYRNSOqHXGfyAeZLQRbhsDSAkkaVmwj/AXyrg1e/etWaIuflatyAmEHLOkSgcI C5KJC+wy2CgoMf19il1yuPxcLwZcQPd2SZZj4AAf/ykKQ0aSKh6+pIPb4g25WWlcwcg4eN t4YrvyBOADSJCGVzeYZMBUXgq4291p1fuO3QKG/Pc+Eg5pgN7xkgjZI/QD/vFg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794024397; b=Zc/oum1norgl0d51ItJT00VOTy2Q8+Hu9sA6CmaKGKXH96RtE2GtPBsFLluHdkvK9nUAW8 YgY6+dDz89zEB0OmYUy0z2tyygvZmbAXyLVgw1PhxbfLp1fZrYqujrCYcMmgunaSciThPG 4jwMJ7DqWPNavcpiZgDa1US3JHzRBRlKG6SMs3MIuIhMwB66nt2MPqVdK1AJ576Tr45Asw KmZit3L6rQHRnhdZZGn8VleXXN7wlr2HIFiHP4nJAmgD/pH2ctJEeAw2pz1J9s+/N7jcbl HmLwNNnXjQP7YtEfJAZTd+si5x4LGyKTz6L7dX5SnF9YybS5YH3A9kIDsPs0uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794024397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AKhK4gc/x7lOrieOR24bd9HoeD4kv55GozLveQnQlNM=; b=eb901s0wGEVjk6Gazczk3DgXAS9vDiJUL8Zr3wi08HmujAGERUeohgXXfd29OpAgBSbftr 0JVL2HUGfSXu01V9JNYpiI+Rv0KsvoHleZvmZxEJaquk0/HxJZrvBF2Ad2b0FPOu7+VEuR 95BiVMzoxaIt7CWmfJiLB4G4ih6QZ3RLDiun4TJbT5KurmisCv3a2CurqpAy/ZxXI8xm5z 7jt+HauPUAmEYdDLFUNqlwCN+xibE38OMrDoi12lL57yqo4igGBIdvLziK6LJMEkH39Sm/ hknfRa2alpwNQCNs0IAo8yCXC78J0R80UW94QpmaI8w2Pz6+nVJK8gDSlom9fg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jM2Y91Mv1z166H for ; Sat, 07 Nov 2026 04:06:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3017b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 07 Nov 2026 04:06:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Justin Hibbits Subject: git: 934ffa4c7d8c - main - powerpc64: Don't ignore lookup errors in kernel linker List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 934ffa4c7d8c24c4eb81dbcc0c85a2fd29b4ea17 Auto-Submitted: auto-generated Date: Sat, 07 Nov 2026 04:06:32 +0000 Message-Id: <6aeea3c8.3017b.48887b69@gitrepo.freebsd.org> The branch main has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=934ffa4c7d8c24c4eb81dbcc0c85a2fd29b4ea17 commit 934ffa4c7d8c24c4eb81dbcc0c85a2fd29b4ea17 Author: Justin Hibbits AuthorDate: 2026-11-07 03:20:26 +0000 Commit: Justin Hibbits CommitDate: 2026-11-07 03:41:15 +0000 powerpc64: Don't ignore lookup errors in kernel linker If a lookup fails for a R_PPC_JMP_SLOT (PLT relocation) ignoring errors results in an address of 0 gets written into the jump slot, leading to a NULL pointer jump when attempting to call the function it points to. Fix this with proper error checking so that a module will fail to load instead of crashing later on. --- sys/powerpc/powerpc/elf64_machdep.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/powerpc/powerpc/elf64_machdep.c b/sys/powerpc/powerpc/elf64_machdep.c index ade4c0420b4a..4f59f0c4bff7 100644 --- a/sys/powerpc/powerpc/elf64_machdep.c +++ b/sys/powerpc/powerpc/elf64_machdep.c @@ -363,7 +363,9 @@ elf_reloc_internal(linker_file_t lf, Elf_Addr relocbase, const void *data, break; case R_PPC_JMP_SLOT: /* function descriptor copy */ - lookup(lf, symidx, 1, &addr); + error = lookup(lf, symidx, 1, &addr); + if (error != 0) + return (-1); #if !defined(_CALL_ELF) || _CALL_ELF == 1 memcpy(where, (Elf_Addr *)addr, 3*sizeof(Elf_Addr)); #else