From nobody Fri Nov 06 19:54:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jLqdg5B01z6yf47 for ; Fri, 06 Nov 2026 19:54:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jLqdg34H9z4FMC for ; Fri, 06 Nov 2026 19:54:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793994887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y5Aug8MSR1qe733FyKP9P1N6Y5HLDEH+PUQlSsHLhWM=; b=bLvgv79NnGMQOU8KK/pn+Qh0I/HKTSZjCiBRq1foN9wlWVa5aPKynIu42V85ke9LWtLJDQ 2NKcGJnKUguU78hdafFM7DlcbC59BBG61DsyQq6/iXDjh8t4VJdD/KDGRJ+0W+DuisWkje zMbn0qZ88iPmIjtC1e/3LsrCp3W8kgWDunY+Xwk8l4Xg6xSllCUoecMkH30djjbvJsp7bw 2MLjnw5pWNygprSD/TAHpV0gMm4zwhQgldYbQJ2qalHbwPlFHMzHCv/OanIcnOm1oSBZkR bAVaDPaxuqg1zFShnOPdq513SV/SfK2miyVgQKtBzxOdV8MekwNiUmxSy/rTIQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793994887; b=lxsTawtczkyauJTehrRXHGo5mWfRl7wg+4XPq1UsIdvlqKa74sa64Ejf3I6YatXpiINGQE TzoJzHg8DBy5GlZ3PaXxVt8GNIG/sBchBYnXX4/sP85fbAzGIjvziyJZ8+a3xMih/ooLE2 R25zWy/p0bL3AmieozQo/TLyx9D29Pm6UJlwEPy1lM5keQPlu+DSnA7g6Ltf+vs6FqxjK9 5JF/ho4LHoWal4/3RpSEd0JxRkDxpT9IMI5pPv9lp+p0xcwu1w+EACdOKXCn0eMRcsUSy8 iHNK7fYvr0SkE2HdGycZONsdg0L+3IPDJDHxJIkVQLUoh53MQzjBNlYWxhsENA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793994887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y5Aug8MSR1qe733FyKP9P1N6Y5HLDEH+PUQlSsHLhWM=; b=X82vgGu1QRNYvm81PNo0L5pdaTCdCzpm6rgsCOMolh/svxudzKFMy28OVp1aw/RkrJFapT ghnxsDK/STakRKp6pbaj4OXAtxHzVKIVUDNCj6uk4cgl8bmkfeChvZHgzJKfSauS6iCxWo QhSG/Vp6ayI9SMHv2dUKsK982tJKZJuT7iDk/5EdmtDRRu9iIFN4d8JSaZX5WsdywXlvJy QPcvpQlnG6QnbGex5YJmR4Fii3psP24udJwkv3SAOAgEZy+T+Q1MFvhPiQMcKYnNUVAH4p 2dl3DuF4v0gcPAxKiOwVBZR5ABnmaVhYpCpOtWOWUCKl1ARjo2x2eDWOjSZK1Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jLqdg2k4tzrGZ for ; Fri, 06 Nov 2026 19:54:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e884 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 06 Nov 2026 19:54:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Osvaldo Janeri Filho From: Mark Johnston Subject: git: 8afd77acc6b5 - stable/15 - bhyve: fix integer overflow in qXfer packet parser List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 8afd77acc6b514937873f5217a9e10b9c1a0a422 Auto-Submitted: auto-generated Date: Fri, 06 Nov 2026 19:54:47 +0000 Message-Id: <6aee3087.1e884.773e61d0@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=8afd77acc6b514937873f5217a9e10b9c1a0a422 commit 8afd77acc6b514937873f5217a9e10b9c1a0a422 Author: Osvaldo Janeri Filho AuthorDate: 2026-10-19 18:53:05 +0000 Commit: Mark Johnston CommitDate: 2026-11-06 15:52:19 +0000 bhyve: fix integer overflow in qXfer packet parser doff + dlen overflows unsigned int when both values are close to UINT_MAX, causing the wrong branch to execute and passing an unbounded length to append_binary_data(). Rewrite the comparison to avoid the addition. Reviewed by: markj Fixes: f81cdf24ba54 ("bhyve: Add support for XML register definitions") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D60847 (cherry picked from commit 5ce0ab7355264d38fcde4684f0a64347ec0f5234) --- usr.sbin/bhyve/gdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/gdb.c b/usr.sbin/bhyve/gdb.c index 983e7deb61c9..d137db643bae 100644 --- a/usr.sbin/bhyve/gdb.c +++ b/usr.sbin/bhyve/gdb.c @@ -1841,7 +1841,7 @@ gdb_query(const uint8_t *data, size_t len) start_packet(); if (doff >= xmllen) { append_char('l'); - } else if (doff + dlen >= xmllen) { + } else if (dlen >= xmllen - doff) { append_char('l'); append_binary_data(xml + doff, xmllen - doff); } else {