From nobody Fri Nov 06 00:01:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jLK8L14V0z6yfn6 for ; Fri, 06 Nov 2026 00:01:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jLK8L05Hvz4pjX for ; Fri, 06 Nov 2026 00:01:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793923266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eH6nJuehzYGDBKyuS5yAfFqKEowE34k2F54Ybuy0YXw=; b=SQEjjT0ivce8Tg/D5ZJTwfdZoGqoKdFDJyC+M8IMDEQzZqECYkeUlj4CLqUKhy/nqdu9PJ mQtH6J5T0qWUm6yG4se0HsThznhd7sOLjKRmJkiUXxzQZtmr7DMRD9d2JJYJ0cidYfbcf6 y8+6dRhqlhq4xPOn3vHOsW4TTqc6ZwNBD6JFfhaDEzmMeH9wX9eM1k+Y3dxz8i3SWpP4v6 8ZEIFG7F8Wg0iyCq5Kr5VLWe2B+4WpKtQki7JrrtrznkbmMhVm32XkKOsJ205NgQUP2lU+ 1t4/3dntdowgpFrYPZbQ3Z5CZcxXO5Qirrin8d6BPYrPGU8CZ4MPQXtpS4O01w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793923266; b=HIfC2YpdLhJ/vC+xJOo6UzM2v+wzdqEOIt7NdNrSqWK2Gb+TXSPzZAwDsh4ZWbmNF/n+We j49eel7/JPWtE5O6YbjNkobAocLQcgvkTZdXmBWVk8Ur73NcbFRP5JDVWrp6hgLAeydaak PMpHVB/3PkuTyC/xvLd1PT6sMBb5FrjY7Q+eV1KHfrrysEvWQWFvDMWmYZT4bf5wxfLlvm Qt+PXQY+XgvreU8/WYKg3Y+XDr+OGSLnqpMmpQL/MM5LC3eGQ2WYg+QSOn52zCOzYDChxf rFIUE9TXHH3x/Vxjb+Qgu89AQU0FzleQTXUCpRqb7Zaz6th8jbYDqGq7IYAhMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793923266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eH6nJuehzYGDBKyuS5yAfFqKEowE34k2F54Ybuy0YXw=; b=txq/ngTTM3bKOZRsLyTMKEL59UCdqDGQDu+2nwRXHWD1Vnqoi1jYIeP2zXp/3NUonsIfvJ Pkh7qwkFse9mbVyWFhpZOsiIBneQr9+0sQZ+eCoL1nmXavDrZjMfAQGlfOmk9pDC+NYeE3 Gi6PUKHekXR8H4t2zZ3pyzeKQS1fcbIXgQmp8yZdRp8cOICzF01jTnMgP28lCLtjaEC/s1 RclayNVO/vxa09Z0KBbdFFmTgo7Sn+TcPSHBUvvBj2RRk8WMft2B+eLmrFZWdhRaiqv26h 3bLkjbZbIeY4rCXm/wve5aGaD0cnR5P+oI5LyuWUIp1aY5bN/8IJff7yRCsCnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jLK8K6nXpz1BF9 for ; Fri, 06 Nov 2026 00:01:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c548 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 06 Nov 2026 00:01:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Vinicius Ferrao From: Rick Macklem Subject: git: cf59649539e6 - main - xdr_mbuf.c: Add a check for the return value for xdrmbuf_getbytes() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cf59649539e653db8285996af2b161be9693a49d Auto-Submitted: auto-generated Date: Fri, 06 Nov 2026 00:01:05 +0000 Message-Id: <6aed18c1.3c548.2428d146@gitrepo.freebsd.org> The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=cf59649539e653db8285996af2b161be9693a49d commit cf59649539e653db8285996af2b161be9693a49d Author: Vinicius Ferrao AuthorDate: 2026-11-05 23:58:56 +0000 Commit: Rick Macklem CommitDate: 2026-11-05 23:58:56 +0000 xdr_mbuf.c: Add a check for the return value for xdrmbuf_getbytes() The xdrmbuf_getlong() function failed to check for the return value from xdrmbuf_getbytes(). This could have resulted in a failure during NFS RPC message processing. Reviewed by: rmacklem MFC after: 2 weeks Sponsored by: VersatusHPC --- sys/xdr/xdr_mbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/xdr/xdr_mbuf.c b/sys/xdr/xdr_mbuf.c index 6cb72f8fe1b4..27ff71848574 100644 --- a/sys/xdr/xdr_mbuf.c +++ b/sys/xdr/xdr_mbuf.c @@ -151,7 +151,8 @@ xdrmbuf_getlong(XDR *xdrs, long *lp) if (p) { t = *p; } else { - xdrmbuf_getbytes(xdrs, (char *) &t, sizeof(int32_t)); + if (!xdrmbuf_getbytes(xdrs, (char *) &t, sizeof(int32_t))) + return (FALSE); } *lp = ntohl(t);