From nobody Thu Nov 05 17:25:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jL8Ml0Cbnz6xkb4 for ; Thu, 05 Nov 2026 17:25:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jL8Mk4l7vz4mH2 for ; Thu, 05 Nov 2026 17:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793899522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HYNy4Pgq51XRkqvTXzrYy+OXjEu/NklY7rBaGAH7l+Q=; b=hkPEVJS9ZNlAjs4X0JA9xSIvvB9+l4cQZDUWy8cMHgxQ3KrW2BZyKmRdu+Cn33VJbjyiRA 0/PLyEZWSATs4mR2QQyzX360jpjhNGu+smUtzS2mQn9ONuM1Pmxtj/8ZS7gFgDBPi6yUYh sVghOdw35GKUoYxVyNH7vD7djSPm2xuFrNBXlKJlyB8JuB59t+9W1rolyCt/MiySMyNic3 PC1F2dJcY6G74mLaxelcRjKgwBbQg9VGN5oSMfch1fkY7/gZ35xZxGOoI0M3ZikgloV6g9 eDx/fFQ6PTS1Pf0a5016kTJt2+D4GP2ARUbLEBViVoPfmtc50AU6ZT1vdDznHw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793899522; b=RIxz0ElcxkQdsBm7NN3inDgtWSX1t00yF93aN68uMVGwE0fdKdmea1O0bvOwE6dkU7ANi1 80hwjClhu3Yzv3UnChnZey7IzzVRiuwdFt8LWVaqRxmM9lzEZXcamlCI529C7uJdlDZkwa zmFztmgs/xTNKHAuxTRl0c8QnS91SvdwXb/eOAFcaF639NMHzsXZjW3MRSnWN+wDPdTnR5 qvwNSNBEiSWx9hP8nFED2n7W4SKHjFYMD4WF+8dEufRly/Mk3O3gbPRpI+QpsmOwXFQlOa 7eC9KEoLl0bXWXVKinEnUje7XCJhnDiDH/t2eSisvxrbSmo4bbUmm/Snl+Hipw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793899522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HYNy4Pgq51XRkqvTXzrYy+OXjEu/NklY7rBaGAH7l+Q=; b=qPmyPEw7PWrh+eUkBEy2ns7xVc5uFh+5NX4LoRYHh0OsFOLbeFzzBs5pUy09tkU+jsA3cd mK9gV3MfZzZMlOvhiitCyDwWLTgsoGWYlg6q3aL9TZJJMJRQ8G8KLZ1TIAZVCVsxhawLZv YPsOU8vjDch50wWSgG7ktkVDn2uD3XmsutyNLwEbTLuR3DSnxXwa8wLgeQJgs/0KC0Z8QO 1fqDVMmDd1gRsozVXw39ITVYRZIElPTlXAFpYgFYvu4dh9pzx60t3VoNtQ0seY469ucEjn xtuMuB2l62LJz7+azgE1ZTj6Km0xrbBPVAT2KQHxnv35YO+Q75ftUFX2Yw6x8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jL8Mk420Xz10nr for ; Thu, 05 Nov 2026 17:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3a819 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Nov 2026 17:25:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 843cb77850d9 - main - e6000sw: Write the value, not the register, in Clause 45 writes List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 843cb77850d991c349fd384fee6402b6af5d7f74 Auto-Submitted: auto-generated Date: Thu, 05 Nov 2026 17:25:17 +0000 Message-Id: <6aecbbfd.3a819.71b852e0@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=843cb77850d991c349fd384fee6402b6af5d7f74 commit 843cb77850d991c349fd384fee6402b6af5d7f74 Author: R. Christian McDonald AuthorDate: 2026-11-05 16:55:24 +0000 Commit: R. Christian McDonald CommitDate: 2026-11-05 17:25:03 +0000 e6000sw: Write the value, not the register, in Clause 45 writes e6000sw_write_xmdio() loaded the Clause 45 register address into the SMI PHY data register a second time, where the value to write belongs, so every Clause 45 write stored the register address. Its only caller, e6000sw_serdes_power(), runs at attach for ports 9 and 10 of the 88E6190 and 88E6190X to power one SERDES interface up and the other down. It wrote 0x2000 to the SGMII control register and 0x1000 to the 10GBASE-R PCS control register instead, so neither interface was powered down and the rest of each register was overwritten. Fixes: 9aba06377d26 ("Add support for the Marvell 88E6190 11 ports switch.") Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/dev/etherswitch/e6000sw/e6000sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/etherswitch/e6000sw/e6000sw.c b/sys/dev/etherswitch/e6000sw/e6000sw.c index 248a13952d35..1d8241eddcec 100644 --- a/sys/dev/etherswitch/e6000sw/e6000sw.c +++ b/sys/dev/etherswitch/e6000sw/e6000sw.c @@ -763,7 +763,7 @@ e6000sw_write_xmdio(device_t dev, int phy, int devaddr, int devreg, int val) } /* Load data and start the C45 write operation. */ - e6000sw_writereg(sc, REG_GLOBAL2, SMI_PHY_DATA_REG, devreg); + e6000sw_writereg(sc, REG_GLOBAL2, SMI_PHY_DATA_REG, val); e6000sw_writereg(sc, REG_GLOBAL2, SMI_PHY_CMD_REG, reg | SMI_CMD_OP_C45_WRITE);