From nobody Thu Nov 05 15:12:14 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jL5Q66ScYz709cn for ; Thu, 05 Nov 2026 15:12:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jL5Q63Rwxz4CMS for ; Thu, 05 Nov 2026 15:12:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793891534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gKIre6vSVsTmBgX16Pwy49EotNHVfCygI32ugZj0QNg=; b=mteIDbi5MJS++XuwGRTwM0+/Q/Yy1qemyj2jKxtrICPb9bgcwO/rnoMbjmncUswaILv/56 mM/4n3jl0Y3N8M3zcxO9cV64Rt6cvx8cT3tBWo9DpiBAR49FrjodjIeX0iHM2Yjh6s1Xu0 DRzX7sggZsAbN9DY8XnX4iEGSLsWHSaNRdoA9j0mz5FnpZGlC0CMo0BhxhbNEvOaT3aq33 b+dlZEFlFcu5IFY0L49ggRCXAuAlSowg021fJ4Q8EnwMMLSORippdKQYrAdm5aMdMMxiqm lV9QO142Zmv3kyygWTFdLwbxfImxD6SmdHPwOBj6YDtLxNLHy/fYn9NI5tubUA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793891534; b=hTT2rVGRoaoDXEs1fe1IoX0al4NGVyHSl0h/N3K3jmxA+payfe9uxO5sbmqPodK5ICwfIS dd2QONhSg16EeQgAeNbXm/gN5wPsQA+jjv6zaKtdsl3mTtPUo3N6bVJp66qPwHOVSSXYyh xN92ZQEjd4x7+dC7EsYEFdr5lsReK20ZAL04dNVisISv8YqM6qnIQaVIORDg3/uMc2UJ8W jzpAA9sVgC6BObhvIq0zl5zyr62HrHgb3M2/YWpLv9894sMwzAb9o7N+ojBO93LvEsB/9T 2iHjgV4TlTYaJ1NBUqkSiBcyyVWDgswHw2meFhi1voew2xt+bM9M2/wTV0pzug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793891534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gKIre6vSVsTmBgX16Pwy49EotNHVfCygI32ugZj0QNg=; b=wG1K+qJzMDke8rBz4q1OwmqUqBomCx/sZ0IIBjxGk+Ivx6bixv4ig/qSKAQg6W7uYIYAAZ jvyuR6qjfnl2NJtN18mHu/iiFeR2sqwRx/YJtwyJD15aKNALhnGBACL58gPOFpyehxJt/R 7fzW54zhjdqGiQDXk4HJp8m2DIGaVSHF/iiXlTvSCR/nv1UqYHeHMrxtvXyPyioa0fbzFI ergvR8PRImNS6N/V+pQEEP1x+GHE+dZSXrHjHDXDSPKvkCVBZhbUPe8x8PRlkmCKNG5AQR RgC9FomGPr4rXeztilm87m2PaMhGpfSaoSQ+o/UGCX7ZCeZnfAhgtWeVdFcgNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jL5Q63637zwB7 for ; Thu, 05 Nov 2026 15:12:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2257b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Nov 2026 15:12:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 23c80630ed1c - stable/15 - libfetch: Use C locale for dates List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 23c80630ed1c21ea4b8f0239ddd41d6f6de14cc9 Auto-Submitted: auto-generated Date: Thu, 05 Nov 2026 15:12:14 +0000 Message-Id: <6aec9cce.2257b.6d0a806e@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=23c80630ed1c21ea4b8f0239ddd41d6f6de14cc9 commit 23c80630ed1c21ea4b8f0239ddd41d6f6de14cc9 Author: Dag-Erling Smørgrav AuthorDate: 2026-11-02 12:27:46 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-11-05 15:11:52 +0000 libfetch: Use C locale for dates MFC after: 1 week PR: 299084 Reviewed by: arrowd, kevans Differential Revision: https://reviews.freebsd.org/D60901 (cherry picked from commit 581d5098ec2c9738db8a98bb1ef3c36ca33033b9) --- lib/libfetch/http.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c index 8fe98c57446d..feb88f9c1452 100644 --- a/lib/libfetch/http.c +++ b/lib/libfetch/http.c @@ -77,6 +77,7 @@ #include #include #include +#include #ifdef WITH_SSL #include @@ -121,6 +122,15 @@ #define HTTP_ERROR(xyz) ((xyz) >= 400 && (xyz) <= 599) +static locale_t +fetch_time_locale(void) +{ + static locale_t loc; + + if (loc == NULL) + loc = newlocale(LC_TIME_MASK, "C", NULL); + return (loc); +} /***************************************************************************** * I/O functions for decoding chunked streams @@ -854,20 +864,20 @@ out: static int http_parse_mtime(const char *p, time_t *mtime) { - char locale[64], *r; struct tm tm; + char *r; - strlcpy(locale, setlocale(LC_TIME, NULL), sizeof(locale)); - setlocale(LC_TIME, "C"); - r = strptime(p, "%a, %d %b %Y %H:%M:%S GMT", &tm); + r = strptime_l(p, "%a, %d %b %Y %H:%M:%S GMT", &tm, + fetch_time_locale()); /* * Some proxies use UTC in response, but it should still be * parsed. RFC2616 states GMT and UTC are exactly equal for HTTP. */ - if (r == NULL) - r = strptime(p, "%a, %d %b %Y %H:%M:%S UTC", &tm); + if (r == NULL) { + r = strptime_l(p, "%a, %d %b %Y %H:%M:%S UTC", &tm, + fetch_time_locale()); + } /* XXX should add support for date-2 and date-3 */ - setlocale(LC_TIME, locale); if (r == NULL) return (-1); DEBUGF("last modified: [%04d-%02d-%02d %02d:%02d:%02d]\n", @@ -1647,8 +1657,8 @@ http_request_body(struct url *URL, const char *op, struct url_stat *us, if (ims && url->ims_time) { timestruct = gmtime((time_t *)&url->ims_time); - (void)strftime(timebuf, 80, "%a, %d %b %Y %T GMT", - timestruct); + (void)strftime_l(timebuf, 80, "%a, %d %b %Y %T GMT", + timestruct, fetch_time_locale()); if (verbose) fetch_info("If-Modified-Since: %s", timebuf); http_cmd(conn, "If-Modified-Since: %s", timebuf);