From nobody Thu Nov 05 15:12:12 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jL5Q46jyxz709lM for ; Thu, 05 Nov 2026 15:12:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jL5Q43wSmz4Bs9 for ; Thu, 05 Nov 2026 15:12:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793891532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h3rU1n7YSqoKuG7WjOp+1q+38oTL4Y2bhUVFRTBzED8=; b=jT2z2aB/vtJAsux5ib0Yr+S8hb5BBFoBHNHMRyDAFSIujVyZ6bDjpxOWVUw3xxbguDvIqI sg+hLnYCYwAlUybwZ7N0iqIDEhoYP18is+y79VGiRPyVNmu2+aP8HqT22q01sIf3cET4M9 Sld/HFMQopFyi0HD40HkiCzHw0g+odeA91abXtNOzsEu9f/jjmsOMJPJnfAP4/u9rodt9R 3fWlRT2/rJI/jaaeYysTKMIdCdO4/kH0TWxxtmN7lt0q/8WZ8nHyqcaEEel3GbFq/jwINz 6UUrHNjYu5lQEhvn8hYVAXv9lds0jym3n92/WOH1Un90p6X118sRYeSx2tcJCQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793891532; b=KA2kEM8TiDRTwrsHk2xjlpeTLMBKvEEQB+WJnwPYJF7B3DDZ1MR1cpkw/zEoB0WYj7dXBp BzlUCa9cTMX+bRkOqmw0YcGXNTOSQk6x1ZYC5NkuoqmmZKNonH2/KcnFdE/GiFXZ/cF/IW 2MQCP/LpeuWDrwcIFCd6fknV0MXsUJmcdfF0Zr3GEIWOHOG0ui1ECJFiJ86zEfIekhppE3 hC3U+SIFHYdLigLDcCeCirjXirw2qW+Zmy9g75pbtmEkAMsuE0dQ/Y6k/b5jfMfmpaj9DZ OH8uo67LzdAEsUq7p54BD7MvK2WWbw1xeY9m+pKE3VnjUwA6wJ1+2Cpr4XpCZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793891532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h3rU1n7YSqoKuG7WjOp+1q+38oTL4Y2bhUVFRTBzED8=; b=nBfndy3aFcDLJDovwA5y0pzjpnGt6ehlW7xeNrBx5PxDEKI5RBxW1dAjjAkWGD5gYr2eXF Oq46xhSn3mgh8QWqk+EsbuMJf+f/RfOglKhzIv3vzVif6TB7uijq93oYeaOarqaABoHI7P ybhEET/Q8w04qyiS/xbcr6ytGsovRdOXlU5QPCt6BV36dr2hY0hR2cIW+Uu8/4CkwQzQ2Z CXEbna9FxJ1CqdtrYSApr7K/bdCNHy7RCLA4sofGtytgROaJmQ/4hlMZHW6kdG1k87a2Ha yYo/uPQdau6SznfxicbzzbNnXsjd2TodlxNs9GrAzOt+bRhfS5tAMCVP0GG34A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jL5Q41pQpzwQ0 for ; Thu, 05 Nov 2026 15:12:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 23d46 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Nov 2026 15:12:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 7a25d6d6d202 - stable/15 - libfetch: Plug leak in 304 Not Modified case List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 7a25d6d6d202809e114f20c9900eb27ea2f79121 Auto-Submitted: auto-generated Date: Thu, 05 Nov 2026 15:12:12 +0000 Message-Id: <6aec9ccc.23d46.7510a73f@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=7a25d6d6d202809e114f20c9900eb27ea2f79121 commit 7a25d6d6d202809e114f20c9900eb27ea2f79121 Author: Dag-Erling Smørgrav AuthorDate: 2026-09-30 16:55:18 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-11-05 15:11:52 +0000 libfetch: Plug leak in 304 Not Modified case When we get a 304 Not Modified response, we need to go through the error path to properly free any resources we've allocated instead of just returning NULL directly. MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D60016 (cherry picked from commit b212f565fb1a34fdcd2f5c9530164ff4718a1a9f) --- lib/libfetch/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c index c5415b875155..8fe98c57446d 100644 --- a/lib/libfetch/http.c +++ b/lib/libfetch/http.c @@ -1986,7 +1986,7 @@ http_request_body(struct url *URL, const char *op, struct url_stat *us, if (conn->err == HTTP_NOT_MODIFIED) { http_seterr(HTTP_NOT_MODIFIED); - return (NULL); + goto ouch; } /* check for inconsistencies */