From nobody Thu Nov 05 14:52:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jL4zN48Vzz707KX for ; Thu, 05 Nov 2026 14:52:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jL4zN1b4Yz3GtQ for ; Thu, 05 Nov 2026 14:52:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793890352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V/eB6sHSxj6pxqrIC7IQAzgF9qW2tHmNU25MwHXsUXA=; b=hBvidh5+EI/6Hc3amYr2ALX8m8yPzdoHEiWMru7+o5HoNH/3qGUV8S3D4YWLrfy0XdBMJ0 1MDXPCdNFPV+cFzyXBEsMU/AmLj2ZerWT4gdsRqWLZJp1BYA0Pa8c0rQB+JYVriqgUkjOY ZUDYsruRWMxRxczXsdRxm6oLoMbRX3tDmZVIVaHPI5XfLN35mY0KkzN8DBwYXzpQf/cbd7 8L0nml/aoVQMnIYYTVTez2icfeDervFvPKYcjm1fziGawpmnxDjwuVyrUCQav7LBxltywc 5xl6p6RAehSTHEDAeOr7c2Ze7AaYFGYUwg3L/6eUM7Th50a9Hv+7CgwiJZt/Ow== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793890352; b=RmJwX8BOKAlVBVZhl267Yul2ONeysdrnqNZHhjRGLzK0OXiTTNN1aKtosz5oySd3/tO0xL Cd1s5xVKOcfzvB2W4b1gtc5mgZt80Pfx9zG5ZDnwdesKIHYWgstymFjIlndP/kfaMgxMgv FZE6uuRMfbmOsZ6gTV1cmPf/Y2eg0eEGVEgPUn4QJUoQWmrEvwIMVOKVjykrGtjtiswyXc A1fzJonspNCsLn9rEjMuumM6/3av9bGmcuw/Y0Gfr38deUXX9zSqz7bcgvbFD4Q8uC+F1e 8lHE45MgSGq+LBM8tC9ul+vbEucDGLNlZcFw/wM5sZAxwewbvz3uC0bo9ZIAKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793890352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V/eB6sHSxj6pxqrIC7IQAzgF9qW2tHmNU25MwHXsUXA=; b=m+ne1kBqgxG9ijU5kNptTc6iDOu5g/tYvXCv6n5euu/rZ63shuSRxLxnpLtEucHFXkcOCF BivC/ITLkGDmM87E7697jLoVeyocSccKM0ByvA9WNGQPOaOpepvMcMGuIbV0p7AOkll7It lYjA1W6+8b0jL7TPbvEOemnznSCDSlKyxMEfGYRVXhVenwWL4HUiH2a0gEyqrhR8PxH+03 6AIHRnql6H+f/KXEr4gc14Ni751OYxX5z8jVAgkvorsIxk+qa55a7atavQKLWG56hiOQhv 302utcZBqmveotZs+DKRKkjXLhhrGCkUCQJhGxI/oFw3k4DNwO/zJ1iQw9Qvww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jL4zN1FRkzvf7 for ; Thu, 05 Nov 2026 14:52:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22db4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Nov 2026 14:52:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: d61de53d18df - main - sdiotool: Fix writes being issued as reads List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d61de53d18df34e60660baebe92ea8a1d204d1e9 Auto-Submitted: auto-generated Date: Thu, 05 Nov 2026 14:52:27 +0000 Message-Id: <6aec982b.22db4.581a7a14@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=d61de53d18df34e60660baebe92ea8a1d204d1e9 commit d61de53d18df34e60660baebe92ea8a1d204d1e9 Author: Emmanuel Vadot AuthorDate: 2026-10-22 16:39:03 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-05 14:52:08 +0000 sdiotool: Fix writes being issued as reads sdio_write_1() passed 0 as the write flag to sdio_rw_direct(), so every write was performed as a read and the value was never sent to the card. Pass 1 so that the data is actually written. Reviewed by: oh Differential Revision: https://reviews.freebsd.org/D61026 --- usr.bin/sdiotool/cam_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.bin/sdiotool/cam_sdio.c b/usr.bin/sdiotool/cam_sdio.c index 0cd8eeb0485a..46be0c6b4268 100644 --- a/usr.bin/sdiotool/cam_sdio.c +++ b/usr.bin/sdiotool/cam_sdio.c @@ -212,7 +212,7 @@ sdio_read_1(struct cam_device *dev, uint8_t func_number, uint32_t addr, int *ret int sdio_write_1(struct cam_device *dev, uint8_t func_number, uint32_t addr, uint8_t val) { uint8_t _val; - return sdio_rw_direct(dev, func_number, addr, 0, &val, &_val); + return sdio_rw_direct(dev, func_number, addr, 1, &val, &_val); } uint16_t