From nobody Thu Nov 05 14:52:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jL4zK6zbCz7073x for ; Thu, 05 Nov 2026 14:52:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jL4zK1xVqz3Gt3 for ; Thu, 05 Nov 2026 14:52:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793890349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jdhuefSbtQVcUQa2snL3ttGOVTnH1ayJCNA9kYHkOFU=; b=F0LPeserKufL6ylJUS3nSCVAqtRcyaJ8S1rKfh3y/eP5FDnRhskI1N6TRWjRHMZaI1Uw97 WEPjqmkBOTPHkMFztwuppUXC5WD2Heis625rF8VCnUu+tOKyihUMWjkXGpKRY6ooNWq0BR ZWIiap0dXfqfsbh1kgZ1lJUeYbHFbUDCrmPOeRfC3qTKOGEDl3AX7VfElZ4Ihi8V4PpaMf joniTI5rToJ3F6J1w6GojcEyUSs/19U0sAtRpoUyiePlytPzCRIrAgpHZKvSf7M4izvDyQ /+zeIRDqUrhIOZT24ZYENTmpUT7hNsDYmYVMKQzVW0/3X5efS2HJWtBgN0wiVQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793890349; b=PgECxDqYYEZHMhaxKN1Rz2Fj2hTexngpO+M3ZSfIoUuwKbVYoL3VOXZfAI7NTMji7CG88S /78/aGHY1A5LmjPNwnkWzUU1KFQGc16LQhZ/i6GsrAEu3MjVrdQj6Ecer/yZpslR9hQ6+p 9ACUNFOVgIg7saDT6yixo2JWyId6nTqFmcM9Glr58HCUFIPNztfDkTwPPK5AKPlE/CMSPC r86i25EsrCggJM/H6mmwPoA0iV1kfrfpvBBk6j4dMvB/bzTtdM3mQmVm4IH9cjy6YLJf+4 1FW4RaXg84mBq2trIWdicCg+EFyYVYa2EgRbnv582e7PCCe8kYrdwd2GJgyH/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793890349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jdhuefSbtQVcUQa2snL3ttGOVTnH1ayJCNA9kYHkOFU=; b=ktyOwmZXi2Jq0/hsFaRwqtQV5Agbc9/KDmKzonqe+OArsmye9sKjbXwVPzkefjPQsxD1Y0 UQ6IE4g4DG2Dhfgcsb3aTYjhthPWIiCLr/ZUx9G0xpWL2gi+DBfN4ax+VDBWbrdJq6K49c VLBZxQah/HoMMXAkYqXqhvUEYB6hAfTWLIETRTT49HG3787Q5vT765DkrLHozmTPsMlK47 j2gdGuhyqFwVc60xs//PYWNPUhUMHwFj5X/XhI/Dk9U+T37ufBbuWHpogppJ+xivxRKGXS S4zvWNm5vJnSRCfqCeExOw0miknwnBJjxDZyQooD8OLY9Aedn77zYrAsSlLJ1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jL4zK1c7wzvcS for ; Thu, 05 Nov 2026 14:52:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 23325 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Nov 2026 14:52:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: c67a07eb2cf8 - main - sdiotool: Remove the unused -f option List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c67a07eb2cf8efb6ea626225ca2883f8c5aad910 Auto-Submitted: auto-generated Date: Thu, 05 Nov 2026 14:52:29 +0000 Message-Id: <6aec982d.23325.45995be@gitrepo.freebsd.org> The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=c67a07eb2cf8efb6ea626225ca2883f8c5aad910 commit c67a07eb2cf8efb6ea626225ca2883f8c5aad910 Author: Emmanuel Vadot AuthorDate: 2026-10-22 16:39:07 +0000 Commit: Emmanuel Vadot CommitDate: 2026-11-05 14:52:14 +0000 sdiotool: Remove the unused -f option The -f option was parsed but never used. Its argument handling was also broken: getopt(3) binds the argument to the last option letter, so "fu:" made -f take no argument at all. Remove it. Reviewed by: oh Differential Revision: https://reviews.freebsd.org/D61028 --- usr.bin/sdiotool/sdiotool.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/usr.bin/sdiotool/sdiotool.c b/usr.bin/sdiotool/sdiotool.c index 448fe830f7dd..2682891fd4b1 100644 --- a/usr.bin/sdiotool/sdiotool.c +++ b/usr.bin/sdiotool/sdiotool.c @@ -486,7 +486,6 @@ int main(int argc, char **argv) { char device[] = "pass"; int unit = 0; - int func = 0; __unused uint8_t *fw_ptr; int ch; struct cam_device *cam_dev; @@ -495,14 +494,11 @@ main(int argc, char **argv) { //fw_ptr = mmap_fw(); - while ((ch = getopt(argc, argv, "fu:")) != -1) { + while ((ch = getopt(argc, argv, "u:")) != -1) { switch (ch) { case 'u': unit = (int) strtol(optarg, NULL, 10); break; - case 'f': - func = (int) strtol(optarg, NULL, 10); - break; case '?': default: usage();