git: 9c85482ca5dd - main - clk: rockchip: Add a mux flag to select the closest parent
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 05 Nov 2026 14:51:09 UTC
The branch main has been updated by manu:
URL: https://cgit.FreeBSD.org/src/commit/?id=9c85482ca5ddbc1b9f6ae7f69d7dd1bdc07429a5
commit 9c85482ca5ddbc1b9f6ae7f69d7dd1bdc07429a5
Author: Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2026-10-20 11:04:15 +0000
Commit: Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2026-11-05 14:50:11 +0000
clk: rockchip: Add a mux flag to select the closest parent
Add RK_CLK_MUX_ROUND_PARENT for muxes whose parents are fixed rate clocks
that can be shared with other consumers. When a rate is requested, pick
the parent with the rate that best fits the rounding flags and never change
the rate of a parent. Without it the request is passed up to the shared
parents, which refuse to change.
Reviewed by: mmel
Differential Revision: https://reviews.freebsd.org/D60890
---
sys/dev/clk/rockchip/rk_clk_mux.c | 51 +++++++++++++++++++++++++++++++++++++++
sys/dev/clk/rockchip/rk_clk_mux.h | 2 ++
2 files changed, 53 insertions(+)
diff --git a/sys/dev/clk/rockchip/rk_clk_mux.c b/sys/dev/clk/rockchip/rk_clk_mux.c
index 97c1ad6f2f1c..40eeaf61b962 100644
--- a/sys/dev/clk/rockchip/rk_clk_mux.c
+++ b/sys/dev/clk/rockchip/rk_clk_mux.c
@@ -161,6 +161,55 @@ rk_clk_mux_set_mux(struct clknode *clk, int idx)
return(0);
}
+/*
+ * The parents are fixed rate clocks (possibly shared with other consumers),
+ * so only select the one that is the closest to the requested rate according
+ * to the rounding flags and leave its rate alone.
+ */
+static int
+rk_clk_mux_round_parent(struct clknode *clk, uint64_t *fout, int flags,
+ int *stop)
+{
+ struct clknode *p_clk;
+ const char **p_names;
+ uint64_t pfreq, best_freq, diff, best_diff;
+ int p_idx, best_idx, round;
+
+ round = CLK_SET_ROUND(flags);
+ p_names = clknode_get_parent_names(clk);
+ best_idx = -1;
+ best_freq = 0;
+ best_diff = 0;
+ for (p_idx = 0; p_idx != clknode_get_parents_num(clk); p_idx++) {
+ p_clk = clknode_find_by_name(p_names[p_idx]);
+ if (p_clk == NULL || clknode_get_freq(p_clk, &pfreq) != 0)
+ continue;
+ if (round == CLK_SET_ROUND_DOWN && pfreq > *fout)
+ continue;
+ if (round == CLK_SET_ROUND_UP && pfreq < *fout)
+ continue;
+ if (round == CLK_SET_ROUND_EXACT && pfreq != *fout)
+ continue;
+ diff = pfreq > *fout ? pfreq - *fout : *fout - pfreq;
+ if (best_idx == -1 || diff < best_diff) {
+ best_idx = p_idx;
+ best_freq = pfreq;
+ best_diff = diff;
+ }
+ }
+ if (best_idx == -1)
+ return (ERANGE);
+
+ *stop = 1;
+ *fout = best_freq;
+ if ((flags & CLK_SET_DRYRUN) != 0)
+ return (0);
+
+ if (clknode_get_parent_idx(clk) != best_idx)
+ return (clknode_set_parent_by_idx(clk, best_idx));
+ return (0);
+}
+
static int
rk_clk_mux_set_freq(struct clknode *clk, uint64_t fparent, uint64_t *fout,
int flags, int *stop)
@@ -177,6 +226,8 @@ rk_clk_mux_set_freq(struct clknode *clk, uint64_t fparent, uint64_t *fout,
*stop = 1;
return (ENOTSUP);
}
+ if ((sc->mux_flags & RK_CLK_MUX_ROUND_PARENT) != 0)
+ return (rk_clk_mux_round_parent(clk, fout, flags, stop));
if ((sc->mux_flags & RK_CLK_MUX_REPARENT) == 0) {
*stop = 0;
return (0);
diff --git a/sys/dev/clk/rockchip/rk_clk_mux.h b/sys/dev/clk/rockchip/rk_clk_mux.h
index c6c261294b68..2d0e0e7ed923 100644
--- a/sys/dev/clk/rockchip/rk_clk_mux.h
+++ b/sys/dev/clk/rockchip/rk_clk_mux.h
@@ -41,6 +41,8 @@ struct rk_clk_mux_def {
#define RK_CLK_MUX_MASK 0xFFFF0000
#define RK_CLK_MUX_REPARENT (1 << 0)
#define RK_CLK_MUX_GRF (1 << 1)
+/* Select the parent with the closest rate, never change a parent rate. */
+#define RK_CLK_MUX_ROUND_PARENT (1 << 2)
int rk_clk_mux_register(struct clkdom *clkdom, struct rk_clk_mux_def *clkdef);