From nobody Thu Nov 05 07:07:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKtfQ5xP7z6yZZR for ; Thu, 05 Nov 2026 07:07:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKtfQ4PMcz3Jlf for ; Thu, 05 Nov 2026 07:07:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793862430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZEsS7ecPODU+OmuRbaAsH8sWIwsvlE5E7c/NZaVrtzE=; b=STL7NoWLbeeH+QEEyYW//VC7NvXZkyY/e5Aka/m6noARntCxaKSJSw41de2Phvxea5HBBt E1d98oFgKLjsVfT9E7qW3pgrfOkDhMhEGtuWBi1gghyIib9zI0/IOUdFc18DtnbjnVePuP kc7B1E980fNz5pwSV2kOD5J2jFRFjAq7njrasIgU6VO72HE6NqYiQU7DfxmoEFWBREllwt PXCYKwo8cVeS1OARhtJA9ekxOFUHcgl0odCoJToW+x/JSkNq/jsL5LCHPIgtOpoAGfy8fr dQjen4i6fXLMBTwkgTDCVVWxp48JWWx15AxqXhtwOZDoAVftTzkF2AbNBO6+hw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793862430; b=xwjg19R17YaeqYpkhGCh/VBkGjRhUeQeVxf4TukgtH0v5kX/cCR1YNq+LzDpqpybDh3h04 UQbDSlCw0atpuFI5xCMuWY3o5ZZD6AKq1E7WaXwbO4WUZ9zu89RsURIE+uLyrhOQ2oiI0p 4i4lipb08wOun5oqG/NnrplTcbBPVaioNVriNWcXE7yHsHAOATsR7Egb+vRY1T2XtaVJLQ PtdB5e6/UyQlbc6hAzuAHx8zgiapdXvT8tEKZCPhM1p60SndNZ/c7/WYwbVCAkMxXgA8hx BMeBSfl5SHU5lNQNBX1+Xwh/Y4VTBSjRIwKMKsZYp0MpridYN2VxsVPLAcZpow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793862430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZEsS7ecPODU+OmuRbaAsH8sWIwsvlE5E7c/NZaVrtzE=; b=atVQ14wEYVGmiW2APjMHhLvpf+SUMiPFF5JwzVqd1p8MQxd9kWB40/eyJxpG5xQNClhoJF 5HgHf6RIBL48MY6ATVBd044mVHx90M4ff5E4kjcvO4iYIqYfedyY40T8OJ4l3KDGeijYKs NnXQen5xWnNYDaT4bUEX1OXMAkWRMznA0Sx0ZmV3k8der4D4OXfdp6EmYUSlezUeh0VfuS wcWXt0bTKtq79j2nczSV4OQsYGQVJbYXmy3e5y5yUtkgJkpv46R7CmkGoD0QE2Ax4Gq8Me /vU1c/WwqFwJvmxzvL/gXEWXnjS/2DSQlB03dqmM4mGRd6gFW/fbMQUMGp50dg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKtfQ44VMzfxB for ; Thu, 05 Nov 2026 07:07:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3eb1e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Nov 2026 07:07:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrey V. Elsukov Subject: git: 2877241e2643 - stable/14 - ipfw: fix off-by-one error in bdel() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ae X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2877241e264321b3ab7f86330c30a23f5ffa8eb0 Auto-Submitted: auto-generated Date: Thu, 05 Nov 2026 07:07:10 +0000 Message-Id: <6aec2b1e.3eb1e.66da08d5@gitrepo.freebsd.org> The branch stable/14 has been updated by ae: URL: https://cgit.FreeBSD.org/src/commit/?id=2877241e264321b3ab7f86330c30a23f5ffa8eb0 commit 2877241e264321b3ab7f86330c30a23f5ffa8eb0 Author: Andrey V. Elsukov AuthorDate: 2026-10-28 11:13:53 +0000 Commit: Andrey V. Elsukov CommitDate: 2026-11-05 07:06:46 +0000 ipfw: fix off-by-one error in bdel() After deleting an item from a sorted array, bdel() moves the tail following it, but the size of the data to move was calculated with an off-by-one error, causing memmove() to read one element past the end of the array. This can happen when the table is full for ifidx or numarray algorithms. Obtained from: Yandex LLC Sponsored by: Yandex LLC (cherry picked from commit c6b08de0e4c797929f4609d86395d494ac695c68) --- sys/netpfil/ipfw/ip_fw_table_algo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netpfil/ipfw/ip_fw_table_algo.c b/sys/netpfil/ipfw/ip_fw_table_algo.c index ccc1a8098585..9a48edb2e1ae 100644 --- a/sys/netpfil/ipfw/ip_fw_table_algo.c +++ b/sys/netpfil/ipfw/ip_fw_table_algo.c @@ -2061,7 +2061,7 @@ bdel(const void *key, void *base, size_t nmemb, size_t size, if (item == NULL) return (0); - sz = (caddr_t)base + nmemb * size - item; + sz = (caddr_t)base + nmemb * size - item - size; if (sz > 0) memmove(item, item + size, sz);