From nobody Thu Nov 05 07:05:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKtcm0Hnrz6yZXX for ; Thu, 05 Nov 2026 07:05:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKtcl6rKBz3JkH for ; Thu, 05 Nov 2026 07:05:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793862344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vXN9tG57MEuMUpPKWeXtaQB1Pr0s5lZMy5se818XO8o=; b=d7uMUJdPUyRg4Pd1DXOJY+FSmCQ5nqcUR5Vg35N5EXkcjN/8P5DOlmLI2iQZPq/usGsgTA hAdiPTSKDbh1Oo8h1MeuEjXuAoRKQGQ74Lls51wrNs9jcBWW5IVk490CkbkhmPJW6v4OQm KKEXN5HxrAFbhZgcJUki0JzZBt0Hdej9xUsT0RTy6KxEz+GXmLnXwwQoT/X/Ujwa5BBCxz Eseg8L/EcsjaIcdXO0rRlh3shUgCd43gav5wsBPgXekIzmIUGN9Jhd1sqRaK6VqXUJqLZL 8QSMsiYDkCTwxDanZKShwORYTjj6ALYmukPMPUeMfwqOV+KYIo+T4PVPDN8Veg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793862344; b=uNhpaOvqZXb2hxqHqE0QIArHv9lmYjDPe/Z/FS9HiaO3/ZmN0+/ggErMfLzkjeH/pH5kQq O8gNn+FPl4QgW+L/Hy3L83sGStIMOhZDqnOvO2/Ge77+RCRCaTMkfrq3jHkt/nK+Y1WD+O s93fMuaZPM2E/UhjGylksXLGUoTNJcSnOfDEbJr+NxotHLk7aGhndPy2v8MOHXILfjG/dX pk7lHhRFrp/6pSDmUPLR/HdV5yZcBoP4pLxNIyWHcDpmDs3x/+DdQabDji/ENH96BpHWGO 4iWwjuYt0wLmKYhEM3xlAsa+RYLRrXoC5JgsuNVN2oglW2uEqTKGXTS1DnX6pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793862344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vXN9tG57MEuMUpPKWeXtaQB1Pr0s5lZMy5se818XO8o=; b=YvqSD0lPxSbhYCKHUqutNVRI3HTXr4tMEUI0D7osbCs31/gth/dP2UxMYBX1/dSrXWuUcD 6/FTJ2HiOSjz/61UdBYnVnJJ5HzlOl2UqRKd9LwTTf2rD9nVRqnBbPW6dcVffLtx4FfbuA MwktcSzfxEFVKlczYMhfDrS7YdMYBa+cTYvyaiV8FllyHwNvxypR2wAvdQwP5FCdFiuTKB IZc1Ps1B5jDdC1Q5zzdpB67WEPjDqHWor/fXwzs2QcDD0E28xHnVj5gDi1lrVCrrkrWcEy fB4+H9ABDGfApyc0khjHt5UUuZ1CjCpo35nfT39jBqpProbGWC4R9KKQ8H6xKw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKtcl6WWTzgfv for ; Thu, 05 Nov 2026 07:05:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ea45 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Nov 2026 07:05:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrey V. Elsukov Subject: git: 3bcfea696902 - stable/15 - ipfw: fix off-by-one error in bdel() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ae X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3bcfea6969029f67e788e31e2dfc58c43de089c5 Auto-Submitted: auto-generated Date: Thu, 05 Nov 2026 07:05:38 +0000 Message-Id: <6aec2ac2.3ea45.44a674a8@gitrepo.freebsd.org> The branch stable/15 has been updated by ae: URL: https://cgit.FreeBSD.org/src/commit/?id=3bcfea6969029f67e788e31e2dfc58c43de089c5 commit 3bcfea6969029f67e788e31e2dfc58c43de089c5 Author: Andrey V. Elsukov AuthorDate: 2026-10-28 11:13:53 +0000 Commit: Andrey V. Elsukov CommitDate: 2026-11-05 07:05:02 +0000 ipfw: fix off-by-one error in bdel() After deleting an item from a sorted array, bdel() moves the tail following it, but the size of the data to move was calculated with an off-by-one error, causing memmove() to read one element past the end of the array. This can happen when the table is full for ifidx or numarray algorithms. Obtained from: Yandex LLC Sponsored by: Yandex LLC (cherry picked from commit c6b08de0e4c797929f4609d86395d494ac695c68) --- sys/netpfil/ipfw/ip_fw_table_algo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netpfil/ipfw/ip_fw_table_algo.c b/sys/netpfil/ipfw/ip_fw_table_algo.c index 515c420ed663..23642c657227 100644 --- a/sys/netpfil/ipfw/ip_fw_table_algo.c +++ b/sys/netpfil/ipfw/ip_fw_table_algo.c @@ -2063,7 +2063,7 @@ bdel(const void *key, void *base, size_t nmemb, size_t size, if (item == NULL) return (0); - sz = (caddr_t)base + nmemb * size - item; + sz = (caddr_t)base + nmemb * size - item - size; if (sz > 0) memmove(item, item + size, sz);