From nobody Wed Nov 04 23:30:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKhWK0RKyz70Kbg for ; Wed, 04 Nov 2026 23:30:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKhWJ3XBPz3K7F for ; Wed, 04 Nov 2026 23:30:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793835020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vkbl7cudkJlf9DqV3/IatE1bPAa+IlKj49IVzP1VopU=; b=Jen7LWCn5dR6E72G5e1f3qE1TrDPn6jPsljrOE40oihKYRVSVrBwcgyXBd+BQ91VuLvt7A jJWlRJCBU6edL1H5KJ04LEAA7je4cVFIvX2kpw2wIm45o8JjsG8XjKoZn/Q09HY8/01vMD hrg5Pmvn0HAutQS2DOZTjYd7WfaXRYZH3VZkZ1Ff6wEAwjwFCw1HT35SRM9SZN9S0O4NSS CsXlVnxDNvmbvJEaWDrMTvq840w2FwxuTAqgGjeLH93BsmZEjSd3zk7m/MLgIbRycGOEqs AD1nBMmiaQverdsWQepDEo/SJjiA4ij3kdfR4Wpy9PR6gRLuqpQ9Bh20+if7GQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793835020; b=A6Cjq3Z9XUs2R2rN7sRJ/Qb8nYGQD4lq3i1YCsTPI8DT9lBi2NAOwqyrUPF/KYz9hLp2Sc A8drV81GT3tItap8oxj5/mhDXBTjTKolRdI8NRyZLrzrhbb4BnlL6L3VO09S3sRYuuPPoA QEmlZ7ZClAUUsnkAZ8jLw7p8IugHZVz5F9Kumf0DNJj9l12Ko06Y50L5+KLl66U/4gIYjq m8wwQ2stzRosW4Q6JeN6aCyNQY/2kbKHPQmVGTN3WB0DtYRZ2Yt/EPIX9c3qY+0V7ttL1t v/UYts62lK0+lbq6HU8IPx0x0X18u/YWQPN9hPEKKm4DUQg+XnowIHPUF8px0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793835020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vkbl7cudkJlf9DqV3/IatE1bPAa+IlKj49IVzP1VopU=; b=GxiigGK4ZDAyxhqiQgUPaFauHcT8A3WOPZeLyIoj03mrZ4WBE46AuidDUP7QAWeEZFWtlk Xr36ZFXo5mlqaLyQNh64dGcPj7FLxmOzRZfg2w6J61EH6d59J2BVVbPTyfYrt11+tlcI32 5smd5Qzy2VNsawvPJJy7+f3Pz4l4EvpXmAur3PouBYxT1Hdp74xocd5ZSJmlJMWudrstLo Gviue8duWoc+Q7VqQVauTn5lCZgbep9QqCsoT3FeonSPyL8dJuEsIsGpLGZ8hi5ggnww4L TX3RDvydaDLRIun9tg8HojS0166Jc50AsmRXqy3wFZwMl2Qcnf8AOL9opjFukQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKhWJ3CBhzP03 for ; Wed, 04 Nov 2026 23:30:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 363be by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 23:30:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Tim Hostetler From: Mark Johnston Subject: git: 9d48e88e0236 - main - gve: Page-align DQO descriptor and completion rings List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9d48e88e023634e12530bf9db4a2e85d022b93db Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 23:30:20 +0000 Message-Id: <6aebc00c.363be.5578d926@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=9d48e88e023634e12530bf9db4a2e85d022b93db commit 9d48e88e023634e12530bf9db4a2e85d022b93db Author: Tim Hostetler AuthorDate: 2026-11-04 23:25:00 +0000 Commit: Mark Johnston CommitDate: 2026-11-04 23:25:44 +0000 gve: Page-align DQO descriptor and completion rings Currently, gve_rx_alloc_ring_dqo() and gve_tx_alloc_ring_dqo() request CACHE_LINE_SIZE alignment when allocating DMA memory for the DQO TX/RX descriptor and completion rings. The device requires stronger alignment than cache line alignment, which was incidentally being met due to how the kernel allocates memory. Explicitly meet this requirement by requesting page aligned memory. Signed-off-by: Tim Hostetler Reviewed by: markj, Jasper Tran O'Leary MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D61211 --- sys/dev/gve/gve_rx_dqo.c | 4 ++-- sys/dev/gve/gve_tx_dqo.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/gve/gve_rx_dqo.c b/sys/dev/gve/gve_rx_dqo.c index cf914913da09..0d1c0eb149db 100644 --- a/sys/dev/gve/gve_rx_dqo.c +++ b/sys/dev/gve/gve_rx_dqo.c @@ -103,7 +103,7 @@ gve_rx_alloc_ring_dqo(struct gve_priv *priv, int i) err = gve_dma_alloc_coherent(priv, sizeof(struct gve_rx_desc_dqo) * priv->rx_desc_cnt, - CACHE_LINE_SIZE, &rx->desc_ring_mem); + PAGE_SIZE, &rx->desc_ring_mem); if (err != 0) { device_printf(priv->dev, "Failed to alloc desc ring for rx ring %d", i); @@ -114,7 +114,7 @@ gve_rx_alloc_ring_dqo(struct gve_priv *priv, int i) err = gve_dma_alloc_coherent(priv, sizeof(struct gve_rx_compl_desc_dqo) * priv->rx_desc_cnt, - CACHE_LINE_SIZE, &rx->dqo.compl_ring_mem); + PAGE_SIZE, &rx->dqo.compl_ring_mem); if (err != 0) { device_printf(priv->dev, "Failed to alloc compl ring for rx ring %d", i); diff --git a/sys/dev/gve/gve_tx_dqo.c b/sys/dev/gve/gve_tx_dqo.c index 0561092105fa..95490eb1de4c 100644 --- a/sys/dev/gve/gve_tx_dqo.c +++ b/sys/dev/gve/gve_tx_dqo.c @@ -173,7 +173,7 @@ gve_tx_alloc_ring_dqo(struct gve_priv *priv, int i) /* Descriptor ring */ err = gve_dma_alloc_coherent(priv, sizeof(union gve_tx_desc_dqo) * priv->tx_desc_cnt, - CACHE_LINE_SIZE, &tx->desc_ring_mem); + PAGE_SIZE, &tx->desc_ring_mem); if (err != 0) { device_printf(priv->dev, "Failed to alloc desc ring for tx ring %d", i); @@ -184,7 +184,7 @@ gve_tx_alloc_ring_dqo(struct gve_priv *priv, int i) /* Completion ring */ err = gve_dma_alloc_coherent(priv, sizeof(struct gve_tx_compl_desc_dqo) * priv->tx_desc_cnt, - CACHE_LINE_SIZE, &tx->dqo.compl_ring_mem); + PAGE_SIZE, &tx->dqo.compl_ring_mem); if (err != 0) { device_printf(priv->dev, "Failed to alloc compl ring for tx ring %d", i);