From nobody Wed Nov 04 23:30:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKhWH70Cxz70KWD for ; Wed, 04 Nov 2026 23:30:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKhWH42g4z3K5F for ; Wed, 04 Nov 2026 23:30:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793835019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HONRCMnSWlsD3nRx1FCjBkYxef2bW/kwxb22hsWV5KY=; b=PacrtE71Ys1rtyJ2w4v1meRIMABfegy5bHkddKJKMv+PooKf2OtJgWFNuVUeisQl8A6Kzp bmgTUEvetuoZ9ITC+CuRbAk7LTgAQlwZ4CvD7+OfIZIPY6RKiGK8G4vp9ShzuaANEQZa07 Yif2rrhyJzz09XH3Uw9RV1j7XW9xqPlBmCUXXNOrRsEV7rSewJaCUkYznf1sQHKoO1pHUA R1/zP6Xnwb7olUB928IFhuROXwliECtC8rupXn+mnZtZ2JWqq8xogdMZPb/vB3W+i28K+k eqooLLCwEkG2bbltAOcHYhOlZyOzQWfeht7MbduD9ZxWYzquMLz8Bd7tSEld1g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793835019; b=gQEswsP0/dJxToc56REfnVJ1asOdyikhtCUFulV33+f37t8zT6nP21SPzO6J7JIpRdbO+9 cduw07O3O3sI7G6QLWMreCRz/BErC73WIkwMi97k0wEB1Iphh0lFnnLfwMveBOG4fvdOiS tuKLfkCCyVUrxJdZKcal5D7HAtI/0shSV5E6LgommwhPL0MrnhFA0zHWY+ybugFixoGHMN 6fzE6eJgWKUxsj/IYrtJZJEBdctYum0k0x0OlcG3eq/sBkKjSw42QZ1Og4oQvkT+takmcQ nkwpRL96WOK0BgZaX2RnW/BC9r0g8JmIDq+Fjp/4rHR6BillHIQejeGxMn1QGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793835019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HONRCMnSWlsD3nRx1FCjBkYxef2bW/kwxb22hsWV5KY=; b=NkwufriAEbHbTQcq0LLCTQv3PmykCs/LZzI8LqgOcI+g9rW1t0ig2QhZVXErLDuJoiZx7y XVLCw5N2HcjBQ6T7EZI42wE6KeanmtVyXqjm19hy8Mz2gnGlitvb/aoCqZ/b78WGk2T+ZP 8uua2RIasfVz/zUZEjukoHUYLAC1NyyMoQ1iEGHimY5iz32cORBdqYcxaeAJO7TF2y0XsR EcxMXESO4IiEwpj79eqInDkNToUYoUviCXR64WVeVQccomDJ1wdNCCDwPRIDcSBHVuwtsO YOfNrtobTnEvh447tFBH++q87EAzxQ+bwDmHL+Fykv2dkaFXUCzFSYHl+niCSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKhWH2qz7zNZc for ; Wed, 04 Nov 2026 23:30:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37116 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 23:30:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Tim Hostetler From: Mark Johnston Subject: git: 64ea2b980884 - main - gve: Fix AdminQ buffer DMA sync directions List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 64ea2b980884adcc774b04b2c0d206ced711bd76 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 23:30:19 +0000 Message-Id: <6aebc00b.37116.73291d0a@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=64ea2b980884adcc774b04b2c0d206ced711bd76 commit 64ea2b980884adcc774b04b2c0d206ced711bd76 Author: Tim Hostetler AuthorDate: 2026-11-04 23:24:59 +0000 Commit: Mark Johnston CommitDate: 2026-11-04 23:25:16 +0000 gve: Fix AdminQ buffer DMA sync directions In gve_verify_driver_compatibility(), the driver populates the gve_driver_info buffer for the device to read. Sync this buffer with BUS_DMASYNC_PREWRITE instead of BUS_DMASYNC_PREREAD before issuing the command. In gve_adminq_describe_device(), the device populates the gve_device_descriptor buffer for the driver to read. Sync this buffer with BUS_DMASYNC_PREREAD instead of BUS_DMASYNC_PREWRITE before issuing the command. In gve_adminq_get_ptype_map_dqo(), the device populates the gve_ptype_map buffer for the driver to read. Add the missing BUS_DMASYNC_PREREAD and BUS_DMASYNC_POSTREAD syncs around the command. In normal GCP environments this did not cause a functional failure because the underlying platforms are DMA cache-coherent and bus_dmamap_sync() inside gve_adminq_issue_cmd() still provided a memory barrier before ringing the AdminQ doorbell. However, if bounce buffers are used, the wrong or missing sync directions would cause the OS to skip copying between the driver buffer and the bounce buffer in the expected direction. Signed-off-by: Tim Hostetler Reviewed by: markj, Jasper Tran O'Leary Fixes: 54dfc97b0bd9 ("Add gve, the driver for Google Virtual NIC (gVNIC)") Fixes: d438b4ef0cfc ("gve: Add DQO RDA support") Differential Revision: https://reviews.freebsd.org/D61172 --- sys/dev/gve/gve_adminq.c | 6 +++++- sys/dev/gve/gve_main.c | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/dev/gve/gve_adminq.c b/sys/dev/gve/gve_adminq.c index 43952308098b..bdb6cfb56ed7 100644 --- a/sys/dev/gve/gve_adminq.c +++ b/sys/dev/gve/gve_adminq.c @@ -502,7 +502,7 @@ gve_adminq_describe_device(struct gve_priv *priv) GVE_ADMINQ_DEVICE_DESCRIPTOR_VERSION); aq_cmd.describe_device.available_length = htobe32(ADMINQ_SIZE); - bus_dmamap_sync(desc_mem.tag, desc_mem.map, BUS_DMASYNC_PREWRITE); + bus_dmamap_sync(desc_mem.tag, desc_mem.map, BUS_DMASYNC_PREREAD); rc = gve_adminq_execute_cmd(priv, &aq_cmd); if (rc != 0) @@ -703,10 +703,14 @@ gve_adminq_get_ptype_map_dqo(struct gve_priv *priv, .ptype_map_addr = htobe64(dma.bus_addr), }; + bus_dmamap_sync(dma.tag, dma.map, BUS_DMASYNC_PREREAD); + err = gve_adminq_execute_cmd(priv, &aq_cmd); if (err) goto err; + bus_dmamap_sync(dma.tag, dma.map, BUS_DMASYNC_POSTREAD); + /* Populate ptype_lut_dqo. */ for (i = 0; i < GVE_NUM_PTYPES; i++) { ptype_lut_dqo->ptypes[i].l3_type = ptype_map->ptypes[i].l3_type; diff --git a/sys/dev/gve/gve_main.c b/sys/dev/gve/gve_main.c index fc88b3dfd014..ae5e99dadd6a 100644 --- a/sys/dev/gve/gve_main.c +++ b/sys/dev/gve/gve_main.c @@ -88,7 +88,7 @@ gve_verify_driver_compatibility(struct gve_priv *priv) "FreeBSD %u", __FreeBSD_version); bus_dmamap_sync(driver_info_mem.tag, driver_info_mem.map, - BUS_DMASYNC_PREREAD); + BUS_DMASYNC_PREWRITE); err = gve_adminq_verify_driver_compatibility(priv, sizeof(struct gve_driver_info), driver_info_mem.bus_addr);