From nobody Wed Nov 04 21:21:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf5019gz703rn for ; Wed, 04 Nov 2026 21:21:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKdf45qmBz4XB7 for ; Wed, 04 Nov 2026 21:21:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vz0aqhAs/iWmDxpss8Dq8DUnf2mS8U7agUytvL+xovs=; b=i9/cP/NibYM0Ym8I5u5PevxFQ6RQF53/Bh8kiogXbVftAScS3/bXYC1HvH+iiEFaAd6EGx VZkoT7Hp8bys8g3+K+hx8HPUmoaP2RcPTL5A4z9YvKKDm8ytMoOgFM9602CwzbxvR8s/Nk JVxcR0huqobZoY+vB6aBVFGO8JasQ/nzJk5zGfhuPZBz/OuutGaY/rGG2Y4Jm5ijdEGWzE L+yl1fWd8FEgwfEB+V8aliUV5edyZ2JgUaMzT3e8n+9aDqMgRjzafhLgMUn8zwj04Pw482 mz9eiJuNghYl3jUvnfIrJQ8RPfhkrkHUowkhYqvVR8s35WkdIbRq/hOZa+dVZA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793827260; b=xrAueEEvPIR5eY4GcNfAgIawxO1fXdwoMVtj1J+B4sm/Q/PTl98Gqj8FV943kr3zV34ovN ZmJgFxJMzM+8UGnouqlxVOBNbP/cjvyl/lJJmATOFKdyTbUPfX0J7LxbmYUneH+xyeWoOq KmGBALfbvTq5HK7SlcH20MFX3+hCf0h7xwPhgnJ3rFMWp7zRa/PM87/ZmDxwAAeBfSXGOf wX4rjex7ipcF7bP0Pw03Ge+3IPXbuZUF4TNnTC2CCJ9Zq6lKAjIP3Tb5tjlnjvlkc4I+jd DNzLXWIDjk/D8agzELZmmRqQRCEcNievXayghLRMJjI8vLao4tfGEM/RZ0/CIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vz0aqhAs/iWmDxpss8Dq8DUnf2mS8U7agUytvL+xovs=; b=OcQpYtfkEo0QeMwSEy001I+gue1ljSpKCZbFl+qi3szzBCjfxyfGDW22o1TvWwpHf+ZHMB rmll3XnyGlH3Di8U7N2lz3SLLP//+w/FPrgZqt2dUr5lfJ6RArcyqPCpkrT9bnCGZVKE9n bfCzo8Rb/OxKaY2kNbtKZ95dWUvRwyyhU0y6qXP8o+t+egN46l9CJEVAr7LLKmGrSpBeoR 9blpda2WpAUZItjlehlLxdwwrMwBqmUPfD/M5swimE8MHzE3eeZIFsSWZyEVG4acoB8lRr /ddtADRP6TePOKcizw/S0gYtfV6PDNb6NmzZDKEls9XjHVmR8zUpdPeXfj5x1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf45FzJzKHv for ; Wed, 04 Nov 2026 21:21:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 214f2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:21:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Arthur Kiyanovski From: Arthur Kiyanovski Subject: git: 0c72405ee99e - stable/14 - ena: Fix RSS sysctl panic when the RSS table is destroyed List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0c72405ee99edf8916fac5ca8643b54d6a9c06d2 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:21:00 +0000 Message-Id: <6aeba1bc.214f2.208e5cac@gitrepo.freebsd.org> The branch stable/14 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=0c72405ee99edf8916fac5ca8643b54d6a9c06d2 commit 0c72405ee99edf8916fac5ca8643b54d6a9c06d2 Author: Arthur Kiyanovski AuthorDate: 2026-10-30 01:38:44 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 21:18:02 +0000 ena: Fix RSS sysctl panic when the RSS table is destroyed ena_set_io_queue_count() destroys the ena-com RSS state but left ENA_FLAG_RSS_ACTIVE set. The RSS sysctl handlers gate on that flag, so they ran against state that was gone. This causes 2 types of issues: 1. Kernel panic when reading dev.ena.0.rss.key or writing to dev.ena.0.rss.indir_table 2. Returning a stale cached RSS table when reading dev.ena.0.rss.indir_table, or a bogus 1 when reading dev.ena.0.rss.indir_table_size ena_set_io_queue_count() is called in 2 cases: 1. The io_queues_nb sysctl. 2. Device restore when the device comes back with fewer MSI-X vectors than before. Clear ENA_FLAG_RSS_ACTIVE when the RSS table is destroyed. The handlers then fail with ENOTSUP until the next ena_up() rebuilds RSS. This both fixes the panics, and stops returning cached and bogus values. Note: A plain ifconfig down does not destroy the table, so the sysctls keep working across a down/up cycle. Reviewed by: cperciva Fixes: 56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") Fixes: 2d4d2ed3fef6 ("ena: Reinit RSS table on device restore when queue count shrinks") MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61057 (cherry picked from commit eb65bcbf6cb5b8ace59504ea721ff1802e912296) --- sys/dev/ena/ena.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 767cccd3918f..04f9193f1bce 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1302,6 +1302,7 @@ static void ena_set_io_queue_count(struct ena_adapter *adapter, uint32_t num) { adapter->num_io_queues = num; + ENA_FLAG_CLEAR_ATOMIC(ENA_FLAG_RSS_ACTIVE, adapter); /* Force indirection table to be reinitialized */ ena_com_rss_destroy(adapter->ena_dev); }