From nobody Wed Nov 04 21:20:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf40TjQz7040d for ; Wed, 04 Nov 2026 21:21:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKdf34nZpz4XCm for ; Wed, 04 Nov 2026 21:20:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o/092f9DEWTyva/4iea5Vy6TpRs+/VoqGsQwNGYltiw=; b=R71w5RV8cLTenxk0JVu2el7/Bwz11VgLxLh/EQZyRs/bP/kV7LveuPNaEGZtaS7KwkxtRN Xq2YGv+9CGifoD3UgvJhszjJRCK8QXGGhANlL8JGjeneDGj+G+mDdZoswUUxXh84Va5Cvc ABO97WhrwHoxcL7uGfvcv//zfCZjwuecSmadoszsNs+02AkU92NvYFds0L25j8kkAVK31N A3pF0uvPhAdYPrEEkEDXNp1ZcO/qoTcPu+vBtzT700jMIBduPm+xrhC9qqQHWaHkvv0bH4 LiCFGJsREGlKAML+I8yq6hZIxLc3baYGzBXeDhR5NXbelulmeIQDNmDcOuyTEw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793827259; b=Oz7lw4lThwWVkXPdHaM2LIFTYoOp5Ky1PMAhjo6Fw6okUvQ3kAqACcP4O4CFHfqOLe0rPJ hlPcGuy7I50Feod8pg9ie8ZRFQcc5jLh7kHwTuESz9vXnZRkiOO2HulZYU55d85iXRtYu3 de9YhK6Un8DG1NZMzP1gJ0g+Sb1dLlD4u26u4orfKWVncZxPxKeiAXzKBErpjt6eDCg0ca y+uwu+Jhmvs5xoFdPf4IJFyMbQvyKk7sWXPrXvVNm09E4mDwB7oQ8udTZdp4nb3uBVOCjh vi2xZrYpnvaCatBQBIucbPNV0YZBizxLozPCDVUC41tHL0ISALRn98WDusAL/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o/092f9DEWTyva/4iea5Vy6TpRs+/VoqGsQwNGYltiw=; b=mMjo1jbnZRgkZSoy0lJbd54ULIpidmkX2J+Qmk7u1k48j7X5bZqtSomqqZtcY2+uyiW/tj VHyziXy7i0Q826yNOH9mKgES5CsdOzbvONmNJwm2wQD05H7HluxF192JedVIh8v9moMveo vXxwJL4ljTJnNod7yzt6zncMOOnVA8tzcZI5U8+QDNShSot3L2KgQHpPd2T082j9nnZZ3o O23oWX2PNJ7nsoD0N6MRFY4eVMn341XKw90PBVBTz0wVgDU33V06MbP38niWU3wnh/jJ5N dF+D6DA+MYZDSD39jXODwjg1pAuQNxeF0B/3KYckFnmhIBOpwKV1MBJK7ZyMVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf34P97zKT1 for ; Wed, 04 Nov 2026 21:20:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e86f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:20:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Arthur Kiyanovski From: Arthur Kiyanovski Subject: git: 9edaecd7e89a - stable/14 - Revert "ena: Reinit RSS components during queue count change flow" List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9edaecd7e89ab87a5182498da0ee73c69b06f63d Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:20:59 +0000 Message-Id: <6aeba1bb.1e86f.6cdd8094@gitrepo.freebsd.org> The branch stable/14 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=9edaecd7e89ab87a5182498da0ee73c69b06f63d commit 9edaecd7e89ab87a5182498da0ee73c69b06f63d Author: Arthur Kiyanovski AuthorDate: 2026-10-30 01:38:44 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 21:18:02 +0000 Revert "ena: Reinit RSS components during queue count change flow" This reverts commit 2a27dd0076c5. Changing the IO queue count destroys the RSS table, and if this is done while the device is down a new table is not rebuilt until the next ena_up(). That leaves 2 problems in the meantime: 1. A stale copy of the destroyed table is still returned via sysctl. 2. Reading the destroyed key, or writing the table, panics. That commit addressed 1 by creating a new RSS table, so that sysctl returns a fresh default table with the new number of queues. It did not set out to fix 2, but the rebuild hid it by accident. The rebuilt table is the default round-robin one, wired to no queues and unusable: a write still fails, because programming the device needs the IO queues that only exist after ena_up(). ena_up() builds that same table anyway. Rebuilding also programs the device while no IO queues exist. When the queue count grows this fails with EINVAL; when it shrinks it succeeds and points the device at completion queues that ena_down() destroyed. The following commit addresses both issues properly. Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61056 (cherry picked from commit ccceb1729a6bd82b8b293bc5ea61b863179a268e) --- sys/dev/ena/ena.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 6b1139bb0237..767cccd3918f 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1437,11 +1437,6 @@ ena_update_io_queue_nb(struct ena_adapter *adapter, uint32_t new_num) ENA_REGS_RESET_OS_TRIGGER); } } - } else { - /* Reconfigure RSS to reflect the new queue count. - * When dev_was_up, this happens through ena_up(). - */ - rc = ena_rss_configure(adapter); } return (rc);