From nobody Wed Nov 04 21:20:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf153nbz703x6 for ; Wed, 04 Nov 2026 21:20:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKdf12nBHz4WxH for ; Wed, 04 Nov 2026 21:20:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QJH3TRLLNidAfOTJg2jUTb/JoK66C7DZERi+YAgNUiw=; b=sfaI06aWBbWUGec6912896UwX0E+ouiE0HIhwicmn9ceAu4bb5Eigw5767H6gdf5KpxVsn 1C+X9ob1eciY3V7MfNxHHtRvkA8ANsOUMgxcjRvl8FzTgJAoSQSz2XEvlvD3Ez/3A951H8 5hyOV/7p2l6m/goXrlBezpnOWRoh9PqLaIeuca2vzgoQUgRz9crJH2cFbEyZZTy9mSqSg9 iNX3Wa5CupwQ/t91gbCDsTMpK0Bu2IhNpFFeBJ68opEyVEx2dHkFJsAkEybgDGcCQoNRIn t+WzcjSWEAAul6XB7d08/JnGfnuLN4R4EhtSkU0DUhxV+b62cRqnngUzGjkcWQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793827257; b=XZT3tkgiK1PfWTGgtGg0Ys1A0L4+5MAAwIfDDMMvxW6e1PSfmgV6GdO5tPpmDaA+1ly4Jq ZJqHTlE9iceXe2IzJID1Dm7u7E+Nu20v2iXPN7nAqyl66q5FGUicYRwS/83k18BZr8fc3W M6TaxJ7xZkLc7Q7N+QbgOOS/wn4NdgdmQx30v26BboEZ2+BDLXhvaBMj7JQjYmQpZVUtV4 uZzSz59vGIJUFzMqgAr4q2VCFrNKGCo8uN8H9OS83PvzZoWlWkKCKsV0B5jkV5ttO9ev2F kUVcsmhluRrIodRxTNUN2jQaaKjVHv/miwDupzn1uxlvrFBwRUuxfJ4Wx8sELA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QJH3TRLLNidAfOTJg2jUTb/JoK66C7DZERi+YAgNUiw=; b=deD514AcYIgtkAwfQnyH+paInlUp/zMVEq8VawvqrIjxdJT0ZJDio5zwAyVCycjZ2FOQSN Nnz8DeCYu8b4jd5yEM4mBv6Zf6O5evG3leK5rGKeN1Q/efcw0skGKozOuZ2TiOulPzr92n TafDAoEHUkIMdgtUDt9XxPwSHv+z4YsKLib+9wfABcW2zHNFExEx5qXMDp6+E42jarVApC TH0oOdeQEIC48/3w6Gpx3p93EEsIkbFn3Htud4jwNg5cfAeVQ6RFnTkymZLzYrVjt96m+v DfDLpPUAH3iInwGhqVdUf7CIgUMfXaMebf8xk43NrITrDMxzQfCC9TAUEKsq9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf12RLQzJfc for ; Wed, 04 Nov 2026 21:20:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 214ed by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:20:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Gilad Ben Yakov From: Arthur Kiyanovski Subject: git: 8ce9a86efaf0 - stable/14 - ena: Reinit RSS components during queue count change flow List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8ce9a86efaf01e18dbc1d4dab020a48c455c65a1 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:20:57 +0000 Message-Id: <6aeba1b9.214ed.344b0116@gitrepo.freebsd.org> The branch stable/14 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=8ce9a86efaf01e18dbc1d4dab020a48c455c65a1 commit 8ce9a86efaf01e18dbc1d4dab020a48c455c65a1 Author: Gilad Ben Yakov AuthorDate: 2026-05-31 08:28:48 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 21:18:02 +0000 ena: Reinit RSS components during queue count change flow The io_queues_nb sysctl is writable while the interface is down, and setting it destroys the RSS components. When the interface is not UP nothing reinitialises them, so the indirection table is left referencing queues that no longer exist until the next ifconfig up. Call ena_rss_configure() after the queue count changes when the interface is down. When it is up, this happens through ena_up(). This can configure RSS twice if the interface is brought up afterwards, costing three redundant admin commands. That is preferred over changing ena_up(), which the reset path also uses. Reviewed by: cperciva Fixes: 56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") MFC after: 3 days Sponsored by: Amazon, Inc. (cherry picked from commit 2a27dd0076c55789a43415559906f795fd10c2da) --- sys/dev/ena/ena.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 767cccd3918f..6b1139bb0237 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1437,6 +1437,11 @@ ena_update_io_queue_nb(struct ena_adapter *adapter, uint32_t new_num) ENA_REGS_RESET_OS_TRIGGER); } } + } else { + /* Reconfigure RSS to reflect the new queue count. + * When dev_was_up, this happens through ena_up(). + */ + rc = ena_rss_configure(adapter); } return (rc);