From nobody Wed Nov 04 21:20:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf04Qz2z703mD for ; Wed, 04 Nov 2026 21:20:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKdf02SCHz4X9L for ; Wed, 04 Nov 2026 21:20:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UcVEtbCG3ZjJUSZNWW7kbO156ssA8y31aT4ECEAbvfs=; b=flIdSH6XfZEHiD8YkNG5fR03eoqRQRAKWvfTEwAuLN1VVGnV2IBHB7YEoq0gBuPYm9NuAH Oei9vm6xBtsS7ApNCYrFdE1MoQjpZCl8ptnxFCsz5E/TFuEp/ObbBuYOPtd3mq014rfBR0 nRFS8Mcx2ajsk8jLSYzYYml/ih7kp43ExB/6xKGNtpyIL7VvgKvblnmWWEsL2k6F8TaWFe Q3arASGpnptDkCO/ejgK9ureAtLMz/L1Y+xwT37VRX0FUstp/BDqiDG7cHGT6XYNyZWYJ5 hGq3MydQfaVirHq68S83126h2NR2jrzz7ohSptpm0VwCnVKpnBB6boEiFjG4dQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793827256; b=jvaQU305DmkFK+z6aD4nlmg68Idbq3tgcFPH2LjixLh3uhRs4lxAmhKC/YK1dQjOS5MbKG QCQrGrKFGP55vSJMLFElq2LJ6nnF9D6bznfUzEc+NHOwU7g06HcXlUuntjpfuIjPSRxqX7 ltnqboibURMFDJCmaY77WOmk0ybJvdEP6yd2R+ir6P5QLbrDSF10mkI4ponfF9iajrTRw6 Qi6VPsAW6ouZZElANL539GltK3tvvls6IlaTvxj89jGnqIOzVTN4S9kfQqHVQOh6ViE35J S1aYaXCT2UG9t2eI87svTn7RINoZBisoJjGeg3g/KJWCdW3UQWMWY3cpHCUz3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UcVEtbCG3ZjJUSZNWW7kbO156ssA8y31aT4ECEAbvfs=; b=qmpvUeQ7LNyUGunFKZ1VGYgfT0Umj59P0irMOp90g/s9HPOnmdPqn1v5gyAnhYgK/oDJBA 04tCQou9HQ7j5RyyoviLJZEzmRn5HhnW4f+XcbMHAfT4ql458DI6uRfFAx8PcKxVlO6U76 cYwvyDuQNx1V2NC/I6dNH+EpA3NfqdULttY9hvPmEi49PyQIhfRqee9YER+vGSn7lbVNDa 59JDZtu88y/e99eoFthXcmqLzT5k8mchZuHb5bV97+fuG7ojLQiC7z8tgK5WVvxXDhrhgK u9gks7viYZcS2knEG/HVifF+ooZS7FcEQcM7VOQoQqZVjWJqxWNMuuA5UZZkdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKdf01wDqzKDb for ; Wed, 04 Nov 2026 21:20:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 216bd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:20:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Evgeny Ostrovsky From: Arthur Kiyanovski Subject: git: 2240b5153d6c - stable/14 - ena: Fix NULL deref before NULL check in RSS sysctl List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2240b5153d6c4519921456f97b94b6019ee5842c Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:20:56 +0000 Message-Id: <6aeba1b8.216bd.90ccf78@gitrepo.freebsd.org> The branch stable/14 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=2240b5153d6c4519921456f97b94b6019ee5842c commit 2240b5153d6c4519921456f97b94b6019ee5842c Author: Evgeny Ostrovsky AuthorDate: 2026-05-26 07:01:39 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 21:18:01 +0000 ena: Fix NULL deref before NULL check in RSS sysctl In ena_sysctl_rss_indir_table(), the code dereferenced indir->sysctl_buf before checking whether indir itself is NULL. Move the NULL check above the dereference so the early-return path fires before any access through indir. Reviewed by: cperciva Fixes: 6d1ef2abd330 ("ena: Implement full RSS reconfiguration") MFC after: 3 days Sponsored by: Amazon, Inc. (cherry picked from commit 462b6c50c7089e96c54cbd34378467f32fc709d4) --- sys/dev/ena/ena_sysctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/ena/ena_sysctl.c b/sys/dev/ena/ena_sysctl.c index 02793ec9bd9f..5ffab72c1d00 100644 --- a/sys/dev/ena/ena_sysctl.c +++ b/sys/dev/ena/ena_sysctl.c @@ -1160,12 +1160,11 @@ ena_sysctl_rss_indir_table(SYSCTL_HANDLER_ARGS) } indir = adapter->rss_indir; - msg = indir->sysctl_buf; - if (unlikely(indir == NULL)) { error = ENOTSUP; goto unlock; } + msg = indir->sysctl_buf; error = sysctl_handle_string(oidp, msg, indir->record_size * indir->table_size, req);