From nobody Wed Nov 04 21:20:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKddw0sCsz7040H for ; Wed, 04 Nov 2026 21:20:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKddw06wwz4Wr5 for ; Wed, 04 Nov 2026 21:20:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CQ1IrrOC94+E97Wre070cE35R0MwG4bw9swEVOFITbo=; b=lPZSMKmQ3YiWVq+40lHCYI23LoC18YAfAV3M49oK9DrlMf+0DYu5QB6d7Z6kp5jY+i69Cz cAxeDH1DmEaBUOXIBK+CGjylSyU7TJakrQoTp8332NMRYt8rIN8RQg+JIrLQhM+arQGEIZ LWpRKK3XsibI4YVxv7+mvYDtSnxyTIYXrhbsRCKtWr+Yi2dunrxUmNFlOOinTVnK/ZaCEX iqy2m2kMAGOIn6vJIave2hOzZEMTXf/54tC+XOmJEno+qn6jTARlXekBXg15D0Q9LRDc87 9En50mvT3pKQpSxlk6DeRnR2vjmrwnJuOBq0jfhllO8Drm+BSHCAOa0yuZImrA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793827252; b=dre6OaHo4GNbVESfAUjUe/5lHSRf9zxsY5sL4oO+W+/xlup1erfRh+V59szncKqHwf42WY J8XO0Zmvd6Sae/k03HCSzS1gNVwXno0o/69Zwn97NrEZV5YPRJlKWusJbwoWGuw2n1Xalm fF8qCcy2GMWq6HLlLa0Y1Cb2FuKsYJ5v2KAGeiQwPw2DEqwRzX7TAFC7BRuywyuJlCWsDt Euc1BvFK7fyVScMhwdAiNDi9G6Yh56w76lPDtiYhNDYDTnB3fRZVLgT1p10FjRuFyKqR8h j5oPOep5tigpGn/iSutGxwypKG+tPAnWWb313+fLrKF/b1o6+vgEeooAgjXO1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793827252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CQ1IrrOC94+E97Wre070cE35R0MwG4bw9swEVOFITbo=; b=tCr7NYCeDEUJBF+S1VfXfGD7aq9QSaqfHSxebt2CcanBp8XaFj/mxcfJznag0xPeDH15AK BmcDt0/8C3A1XpaGLw1v6SiYPNQMbWgNPOa0ICDlzKUMT6ywM+/HBBKAHknBqI2mP8j2uF 5+zUz4jI1tG1aHqICdcirNQoT+yGjos5EDmZF4hfLGa7xcb+1xLh1huCPIlbDCyasIGG0q RwKM6ykI+in2SSNNNn9D/YzPKioBuKwCj5KpvXSyxnOMnOLDeOC0plJEumjE4d/kHDVW5k Zi1mDj0ouOHimYEC8yK4eDjTfIeelHODeeuXpwssNEn1QS26W8d+QnGB3W37nQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKddv6R0DzKDX for ; Wed, 04 Nov 2026 21:20:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20711 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:20:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Gilad Ben Yakov From: Arthur Kiyanovski Subject: git: cd1772fb9045 - stable/14 - ena: Limit IO IRQ setup loop to active queues only List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: cd1772fb90459f537a0987b726c66413fe2319b6 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:20:51 +0000 Message-Id: <6aeba1b3.20711.4696837d@gitrepo.freebsd.org> The branch stable/14 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=cd1772fb90459f537a0987b726c66413fe2319b6 commit cd1772fb90459f537a0987b726c66413fe2319b6 Author: Gilad Ben Yakov AuthorDate: 2026-04-29 12:10:38 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 21:18:01 +0000 ena: Limit IO IRQ setup loop to active queues only The loop in ena_request_io_irq() iterated over adapter->msix_vecs, which reflects the maximum number of MSI-X vectors allocated at init time. When the number of IO queues is reduced at runtime via the io_queues_nb sysctl, msix_vecs is not updated, causing the driver to bind interrupts and log CPU affinity for queues that no longer exist. Replace the loop bound with ENA_IO_IRQ_IDX(adapter->num_io_queues) to iterate only over the currently active IO queues. Also replace the loop in ena_free_io_irq() the same. Reviewed by: cperciva Fixes: 56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") MFC after: 3 days Sponsored by: Amazon, Inc. (cherry picked from commit 32c301922dc1e6f52bdd043046661ac1e2b462d8) --- sys/dev/ena/ena.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 8a3bb8f7960e..a8af69e94093 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1939,7 +1939,7 @@ ena_request_io_irq(struct ena_adapter *adapter) flags = RF_ACTIVE | RF_SHAREABLE; } - for (i = ENA_IO_IRQ_FIRST_IDX; i < adapter->msix_vecs; i++) { + for (i = ENA_IO_IRQ_FIRST_IDX; i < ENA_IO_IRQ_IDX(adapter->num_io_queues); i++) { irq = &adapter->irq_tbl[i]; if (unlikely(irq->requested)) @@ -2053,7 +2053,7 @@ ena_free_io_irq(struct ena_adapter *adapter) struct ena_irq *irq; int rc; - for (int i = ENA_IO_IRQ_FIRST_IDX; i < adapter->msix_vecs; i++) { + for (int i = ENA_IO_IRQ_FIRST_IDX; i < ENA_IO_IRQ_IDX(adapter->num_io_queues); i++) { irq = &adapter->irq_tbl[i]; if (irq->requested) { ena_log(pdev, DBG, "tear down irq: %d\n", irq->vector);