From nobody Wed Nov 04 21:15:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKdWc0bJRz703Tq for ; Wed, 04 Nov 2026 21:15:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKdWb5lz9z4SRm for ; Wed, 04 Nov 2026 21:15:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793826923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dENMWWTYiw/ZJo48UQQmTD8O/AsT5Nc5FDOXPoC1um8=; b=jvhHzIUUjmVOOtpex9Sp43z+LpBk++ZoEYOzO9KgHk6BsuxdzBrOTrB57EskBUb9xt19pK sD+lwwJLPzddgaOICBxwGtDmZK+m9wuNWXLqp3Gp/bnHgWHl2tr/Fdx5zpHntNI0G/AM+j kVhaAveBZP7SYmDAiCs2sGQrL1E9z6FB5eByEUVxAaTniszVqRX4P5ndhRxXlNdvMP3+Fa R76PkkGlAVvY3iqqWW02F/cnU/DYweJjUel0+cRAxap3B5e4S5Av0Ng1EE3XR6ra3w1GVz xLxzJ0l/EoBYDK17cG2jOvx5Sije0yYgEkYNdQSdtj7IGgxFNuvbivEXIPH4Wg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793826923; b=wfGfj5cVqOZo7GSKKBV5Dyw8zaohNb8IEcqEobIMRQ9o7s4uVmpT8QistrcAn0WhlHO/ik NzQ9MhfAyDfoQvRDMYE58dKVWB0h53yCF1E8vOKZjSY+Gi2IU/YQK2ik2VgKq6OHzlGKe6 ZtlltT+y1MlPIOpglTeu03mLudPJNft8peK840nFSToojWc/19FKPHB1EiCbGm0t9ggg+8 MNfHP2TRHaEV8oMHJZvbRCpcgHts2WWtA034af05KTarVTKW6qf/kDwB8HTDOP8fnd7uIE IhhozneEG0eXBgjkzuqj2UwjM/cwSj/AG2Z8T5XYLRhm/355h1F7MOUcK00hCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793826923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dENMWWTYiw/ZJo48UQQmTD8O/AsT5Nc5FDOXPoC1um8=; b=jF0PGWT171kEMSb/BVVMROJBVjmlzX4daOycreBQ1AI+CBjXF9NIgljdg33GuDOWhxzE33 rgBWUcKPK+1pL2xL4xNoMzbwRypByZrzE72dEPaYjwIsqMkY9g3y1ZfotRJXUtHTa7IfG7 zB2ONbBrRxGWvF3XouMbLrNAyh610Ki7IcWY258s0Z8T2CR/KRkcqxQ+zM1dsuGXjTEGTC qGXzyt29hkH/HCbwqzhZivOEcSeV7fk6CWM91BTqkQAKIZ5K2maoS5zmlqu66MxJBpsTCE wee0svpoWKqpvFQ0FsEsk/srn9TN67zC5+iKaYOWYrSqcsRRZx6G5/CCxHGzog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKdWb59GKzKDQ for ; Wed, 04 Nov 2026 21:15:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20703 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:15:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Arthur Kiyanovski From: Arthur Kiyanovski Subject: git: 98d25a8ce885 - stable/15 - Revert "ena: Reinit RSS components during queue count change flow" List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 98d25a8ce885d830f4aeaa38d3f491b2aca86614 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:15:23 +0000 Message-Id: <6aeba06b.20703.183c1974@gitrepo.freebsd.org> The branch stable/15 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=98d25a8ce885d830f4aeaa38d3f491b2aca86614 commit 98d25a8ce885d830f4aeaa38d3f491b2aca86614 Author: Arthur Kiyanovski AuthorDate: 2026-10-30 01:38:44 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 20:52:58 +0000 Revert "ena: Reinit RSS components during queue count change flow" This reverts commit 2a27dd0076c5. Changing the IO queue count destroys the RSS table, and if this is done while the device is down a new table is not rebuilt until the next ena_up(). That leaves 2 problems in the meantime: 1. A stale copy of the destroyed table is still returned via sysctl. 2. Reading the destroyed key, or writing the table, panics. That commit addressed 1 by creating a new RSS table, so that sysctl returns a fresh default table with the new number of queues. It did not set out to fix 2, but the rebuild hid it by accident. The rebuilt table is the default round-robin one, wired to no queues and unusable: a write still fails, because programming the device needs the IO queues that only exist after ena_up(). ena_up() builds that same table anyway. Rebuilding also programs the device while no IO queues exist. When the queue count grows this fails with EINVAL; when it shrinks it succeeds and points the device at completion queues that ena_down() destroyed. The following commit addresses both issues properly. Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61056 (cherry picked from commit ccceb1729a6bd82b8b293bc5ea61b863179a268e) --- sys/dev/ena/ena.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 6b1139bb0237..767cccd3918f 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1437,11 +1437,6 @@ ena_update_io_queue_nb(struct ena_adapter *adapter, uint32_t new_num) ENA_REGS_RESET_OS_TRIGGER); } } - } else { - /* Reconfigure RSS to reflect the new queue count. - * When dev_was_up, this happens through ena_up(). - */ - rc = ena_rss_configure(adapter); } return (rc);