From nobody Wed Nov 04 21:15:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKdWZ1ttcz703Ft for ; Wed, 04 Nov 2026 21:15:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKdWY4Hc7z4SRW for ; Wed, 04 Nov 2026 21:15:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793826921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LHoy5eZAxxubt/7m3CDp6d1nAPmdCGBO+MOv+/OXPYE=; b=i7XTb+vf5q1jUMTY1z4HyZEvw05ko63d61jZLXJ9BYmda5aET/6KP8whpgNxl4ekd2J59d sh6Bj9DNv7eUJzSjGw5SNClYcn37wFxWX0KkP6+XBTNw6cAL8axmjDJuiHy3/4QaiRIDb8 Wif9ZXi3HAYjsnVUl58UKFeo3UOd+IDGhnuoT+2nfofhAXkiND1Gwb75xGzBW+EE3emjM7 +M/G0gCgScwnWNVqnxZs/n8Ru8qr8ATZw0q/aq61GdQR7d3sbAH5I0c9xrlmDMsRYDySLZ yRL645yuIaWNws/4EO1u3uxjqJixZPDob/xegcH6Gr3N9GyHwZV6MBKtSrJohg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793826921; b=QjmUkctt2K0Qq+DYUbyO3CdjjnQoBPWS3a1N1/9JRslhz9QciywHRPVxE4DMvNGGIVGC5A l2gX3JJ4UfdVpCkIaNjT/JDwODodgV9dPr6eQKxNXS0cwqKsm/F7X7cQR40RuygnoeCvao bgwy7oq7ItuUBohxQ2/zXAHa/l3n8Ph+35td2UVg9l/u5wnIOfDmcQFBFBu/tx6T+0eR0h 4J62z3AmjOwVW3Qo3B8cxJLT7tdMaGiJEveaDngULJcF3CPpSDLMhrvNHBr44OeFTtdxX3 6rzTrmnmcN3Vc9d5ED5NDzr+g2ebofdIPhwEB3rVcgzceXtQmSrnWWbua2oAsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793826921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LHoy5eZAxxubt/7m3CDp6d1nAPmdCGBO+MOv+/OXPYE=; b=PE/yyZ69zbgiQ7SPSi5t+NvQ4YtdjzmPgMTcF27X2O0EVcwwhwQi59a2iC0YSUPm64Q2PY f9/QCx1wGMp3YoNv+ew68Kcc8KWmU3MC/09hvazaI1GllC8T9yOlZAjkHhhikEBgMfSSIx YoFg95TJKifCyl7p7cfSjr4oB0qIeJrE85fUu6XGRVtlNfYJSv9wMpV11Q5D8HfIdrcbAT ZojdJrbxt5QFQO2Pyk7NKZvSv1Dg8f0gu9KPQxOzOBAaM/+LkPI1I6U/5Y2KMfhdVCNVFO yBqfBbFcKfXb4zDQ9ePmcYq8pKH13oUKFC+gR3vaUWXLAnXnx1WxbIGGwodtWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKdWY3hyKzKh3 for ; Wed, 04 Nov 2026 21:15:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f765 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:15:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Gilad Ben Yakov From: Arthur Kiyanovski Subject: git: 28236ef569dd - stable/15 - ena: Reinit RSS components during queue count change flow List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 28236ef569dd795d266fd3c10606b0d64fc59553 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:15:21 +0000 Message-Id: <6aeba069.1f765.59a9155b@gitrepo.freebsd.org> The branch stable/15 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=28236ef569dd795d266fd3c10606b0d64fc59553 commit 28236ef569dd795d266fd3c10606b0d64fc59553 Author: Gilad Ben Yakov AuthorDate: 2026-05-31 08:28:48 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 20:52:57 +0000 ena: Reinit RSS components during queue count change flow The io_queues_nb sysctl is writable while the interface is down, and setting it destroys the RSS components. When the interface is not UP nothing reinitialises them, so the indirection table is left referencing queues that no longer exist until the next ifconfig up. Call ena_rss_configure() after the queue count changes when the interface is down. When it is up, this happens through ena_up(). This can configure RSS twice if the interface is brought up afterwards, costing three redundant admin commands. That is preferred over changing ena_up(), which the reset path also uses. Reviewed by: cperciva Fixes: 56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") MFC after: 3 days Sponsored by: Amazon, Inc. (cherry picked from commit 2a27dd0076c55789a43415559906f795fd10c2da) --- sys/dev/ena/ena.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 767cccd3918f..6b1139bb0237 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1437,6 +1437,11 @@ ena_update_io_queue_nb(struct ena_adapter *adapter, uint32_t new_num) ENA_REGS_RESET_OS_TRIGGER); } } + } else { + /* Reconfigure RSS to reflect the new queue count. + * When dev_was_up, this happens through ena_up(). + */ + rc = ena_rss_configure(adapter); } return (rc);