From nobody Wed Nov 04 21:15:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKdWX53W6z703ZX for ; Wed, 04 Nov 2026 21:15:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKdWX36Nvz4Ryr for ; Wed, 04 Nov 2026 21:15:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793826920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MlHmoNaauxnu9kVJIOufMMtdhMM1Pw4hi74QJo/81Oc=; b=YTHRNI02beIYgdBE0KL2WbKt0g5LLCay2fSpVvuK5NJ7/2QK/9UMwCbC1HmxERM0Nk2ULN kU4DPHqWfbIbNzgQLpHttI/9UjcNXD0BIkGSxh38JVsjviOiPrW/49asnidTl7+MtUhIIx IhIjYIw+WQ9bz2JJA9o4t+skstc9g3u+iMSWEriPj0BskqVUb6z9xCt9Vlf4ckFecPmamb VfpuigRIQIJONpnyla+glPmJ6+vg62hliwkGESLIrTECJULkLli/VwsLwZou4/GahyL3KA lixwCdufLKklvtpswn/bguW4O1ij4NzJaJWlufbx3F6pV0hOUzRhvI/BQJEi4g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793826920; b=WMIX0OyAoOTSQQWtPNzcWETKQogkW6USB4UVE7nRVacmk9CkPurPGrNf3v3ViIk4BD1B5w 41h29FOz+io++znwsispuYNbXtZj1XiAWe+ZFlxSYhyVgpmob+bvFEZ0scuVcpqFGsfyq0 hEfmao0fPVvkl/1rIqPmpVoqmYoXZrOYoz4JcJ/T8855unrh4Oc87YUK0uC/+pvZmU10Az zAy6i+O7WKPgzrlk1xXzun1B12eKxUJdvElKvy+2OQa5BFHgPUWnSagGXOmx6cdYYK8nR7 S1wpQF719ipGBjEDd62g8gSvb3wuG258pgw0JfQlgEfn76DGYx1SdbawtV+UDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793826920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MlHmoNaauxnu9kVJIOufMMtdhMM1Pw4hi74QJo/81Oc=; b=HTFfIZlgO++NCfPv4Fzadk/YdijIdwkjisuHGkZ2H+LMIdq11+/mysofRGA7qdXvgT5SVl /YVNi34t0YUMUJraBd8O8yYktzOibtVMtZvDNSxZ4MXZvIFgxhmP9MY4ZFURxPSzWkSHNl n3DwAp9oH7IUOPhTfuZ6varcFtTyqzsDnZFzdD9b/7puH+r7/u2xHAaRdh0w6MyDM5BQeB eNzMvBQ4ljCN3uOI1FqALN9RHtYjqasO8yG9kvc7dhllsOWZtWR8RxEGDtjn87JVohdAp5 +F8cOZfVoVwyndGO5pIDOH8+mYmV8gLxh+bTW+tIFb9kz9NklzWOGjX4mnObYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKdWX2mlTzKSp for ; Wed, 04 Nov 2026 21:15:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f61e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 21:15:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Evgeny Ostrovsky From: Arthur Kiyanovski Subject: git: 612e19784b28 - stable/15 - ena: Fix NULL deref before NULL check in RSS sysctl List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 612e19784b286f2c016847e41091201610640b37 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 21:15:20 +0000 Message-Id: <6aeba068.1f61e.1fbd71e0@gitrepo.freebsd.org> The branch stable/15 has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=612e19784b286f2c016847e41091201610640b37 commit 612e19784b286f2c016847e41091201610640b37 Author: Evgeny Ostrovsky AuthorDate: 2026-05-26 07:01:39 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-04 20:52:57 +0000 ena: Fix NULL deref before NULL check in RSS sysctl In ena_sysctl_rss_indir_table(), the code dereferenced indir->sysctl_buf before checking whether indir itself is NULL. Move the NULL check above the dereference so the early-return path fires before any access through indir. Reviewed by: cperciva Fixes: 6d1ef2abd330 ("ena: Implement full RSS reconfiguration") MFC after: 3 days Sponsored by: Amazon, Inc. (cherry picked from commit 462b6c50c7089e96c54cbd34378467f32fc709d4) --- sys/dev/ena/ena_sysctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/ena/ena_sysctl.c b/sys/dev/ena/ena_sysctl.c index 62fded932025..74ab16d1b977 100644 --- a/sys/dev/ena/ena_sysctl.c +++ b/sys/dev/ena/ena_sysctl.c @@ -1160,12 +1160,11 @@ ena_sysctl_rss_indir_table(SYSCTL_HANDLER_ARGS) } indir = adapter->rss_indir; - msg = indir->sysctl_buf; - if (unlikely(indir == NULL)) { error = ENOTSUP; goto unlock; } + msg = indir->sysctl_buf; error = sysctl_handle_string(oidp, msg, indir->record_size * indir->table_size, req);