From nobody Wed Nov 04 17:14:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKXB91Zd8z6yX5r for ; Wed, 04 Nov 2026 17:14:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKXB90BqTz4wNp for ; Wed, 04 Nov 2026 17:14:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793812497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d6plgW+QdpoCv1KarWv2QZu0eYDjf27CFdNiUlxHqeI=; b=GJ6ULl5FrTl7siZiLXm+S/WA33Uv+/aJhn/mNs2lOwC/UDkO+TQVwRbq1ouIq6RLhmaXK6 OSBH5kVgNQbxfXiEB10EcY2gNy+Vfd+OXDYg2cZjzaO8zY1Qy82dJG5pRReCHk+HBYkQdK v31Z2z4cBE7HFJsr11B5asWyaaYnqGJamNj9YMuNmM+cGcQCB7To7om7CX2flHonqqAR+/ EyLLpXPrTd1u2Y6XFpbCfcYG528Wnt1v6OIK/SGfDFuER0DgzJY6yWw4jGMPzv1Jx0TnLC Q1lkzpUs1R5CSJC2yMFrOtvq/3SYRDYtsG2yDIKckOBtwwZ/ksZ4MXU+nmMAWQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793812497; b=Za1CxdQzcUAeP8+dqySJT5vvEnSFNyjBXmovKu3AJ6m3Sj3KTOQaU7y/v6rGbZoRnUjZru zfI106/xtmj2shfZdDZpGBOAiPw1NFMORROU5xGeqnpx8+4C5FhLbxHG4DQX8YacvBf6Ji KjZDTqv7qMY8DyIl3+cA7X4FzJOgDjwSRvJ+sV+eM0TgsuC+PpLf9xs/Tminx42tZyN7E8 i4zJakFWhDICF2lEko0J+cE2lXcYjUcg9vo8Yt7UuD5Y5FvSgXOEcfZHgpVezEP3kZq0sj 705bOraJlG2LyFjG3KGfCkIJt0AtKZk/2NwHMNk7XrJRy83lOcTkkfjcB28fsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793812497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d6plgW+QdpoCv1KarWv2QZu0eYDjf27CFdNiUlxHqeI=; b=YjTIK+AFJNd12Ik68QDAwA9bqPb/9OwnzQMs/vzaRE8jh584yr/orE3ejaWqw1+5srdJFI TQvqJ9jOV4jO843l7WNuSI4IWipOtqZBkudPX4GYRUvCAW+UMDGQlKcOKehRruywyKxyL7 COCpxeAcgdGc1WwyYa7E2XKchkf4QnU59e+yeM5N5nGZeekFlVP78wG6ERx43Hf4w0Pzie siXGTbNRBaNTpNFNp/52HZQ4KmuR+xrn68drXrrhs6TOsgH1NjZQJb9whJ2nSBzJvwZgTi CszIphSKA8+iIwXNruOJusIXeVSqJwpuGRFr/XbBC0fIco7HN7weGhuzaYCkuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKXB86yQrz1BMl for ; Wed, 04 Nov 2026 17:14:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22b61 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 17:14:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Denis Borovikov From: Vladimir Kondratyev Subject: git: 2edd355e33d2 - main - vt_vga: repost only a vgapci(4) video device List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2edd355e33d28e02f7c7ab3809729f5420c5edaf Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 17:14:56 +0000 Message-Id: <6aeb6810.22b61.27317068@gitrepo.freebsd.org> The branch main has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=2edd355e33d28e02f7c7ab3809729f5420c5edaf commit 2edd355e33d28e02f7c7ab3809729f5420c5edaf Author: Denis Borovikov AuthorDate: 2026-11-04 17:13:50 +0000 Commit: Vladimir Kondratyev CommitDate: 2026-11-04 17:13:50 +0000 vt_vga: repost only a vgapci(4) video device When vt(4) falls back to vt_vga, vga_init() passes vd_video_dev to vga_pci_repost(), which expects a vgapci(4) device. The framebuffer driver that set it need not provide one: drm-kmod's linux_fb passes the parent of the DRM parent device, which is vgapci for LinuxKPI PCI drivers but the PCI bus for virtio-gpu, whose DRM parent is the virtio PCI transport. On x86, vga_pci_repost() then calls pci_get_class() on the bus, which fails the accessor's KASSERT under INVARIANTS; without INVARIANTS the class reads as 0 and the repost is skipped. Repost only a vgapci device. Signed-off-by: Denis Borovikov Reviewed by: wulf Differential Revision: https://reviews.freebsd.org/D60880 --- sys/dev/vt/hw/vga/vt_vga.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/dev/vt/hw/vga/vt_vga.c b/sys/dev/vt/hw/vga/vt_vga.c index 675c0573bd7e..bf2b7090b29d 100644 --- a/sys/dev/vt/hw/vga/vt_vga.c +++ b/sys/dev/vt/hw/vga/vt_vga.c @@ -1301,7 +1301,9 @@ vga_init(struct vt_device *vd) vd->vd_softc = (void *)&vga_conssoftc; sc = vd->vd_softc; - if (vd->vd_flags & VDF_DOWNGRADE && vd->vd_video_dev != NULL) + /* vga_pci_repost() takes a vgapci(4) device. */ + if (vd->vd_flags & VDF_DOWNGRADE && vd->vd_video_dev != NULL && + device_get_devclass(vd->vd_video_dev) == devclass_find("vgapci")) vga_pci_repost(vd->vd_video_dev); #if defined(__amd64__) || defined(__i386__)