From nobody Wed Nov 04 17:12:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKX7T4LsSz6yX3N for ; Wed, 04 Nov 2026 17:12:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKX7T3BzQz4vdB for ; Wed, 04 Nov 2026 17:12:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793812357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o2gTgkS2G56AA/+5//QL8/B46C93NHzNzatTbpP2qNQ=; b=MlbL8sgFsBW++tBbEQOJ79CsoU5RszK2VFpNenTHO8r94cbBcVSNy0N1B8HZgp1b+H8fSy vEl2rA4be3OgHKyO5lBrCkSQ2sdgVsP/B0zXodHVEzTAKUTgVIpmTBl4P2APsJxAeW9UC4 yfgSs/zUo87T0/mAZU/pQu34757kAdRTvTPcc8oTi2gVe3eaT7m9iux4erj3fikDusWHRh 4a5XkImMq1HQ4/4l+dFuM2Fyr+cLlgwXBlDCxPUjw4p+DD+v4KuuRyUDODYxn+nvr29YZo K04zUd2qCytjDqyL1cmspb0O3Ts2Cfuq7gMStmVEnhL1/GkziaUAjWtx6uc2fw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793812357; b=QqLAyjb8Awt71isl2AlL4Ygrj85z0F2z6lSx3a6l6DYNL+54RuCOvFxfFsUrXQn3QiQhg9 LfJOVyR5kH63BA3kXv2daH/uBwqa5O/RCvEmYcGqj4iqMbLkRrsgvbj2qg1Z7uAf3y9sjl pu1d/gU3HO+Q27m/IKbzsLdWKi+bL4jZQWxntAvAdd7MZ4hWcEZi2Ge3yQZJVNOX9/aXJ0 LL7SP9U442Ie0Z6QU/gG/aP2zmA5H/RLZxsWVSyHVNi3JBntL1vrg1d6Kng0eM/jvW7OKR Ea2iHAxDXHqp8qnQyBNHnEzDKqN78NIO+o2ftQSwv8zOkXmkk41Wcw8NJadXlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793812357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o2gTgkS2G56AA/+5//QL8/B46C93NHzNzatTbpP2qNQ=; b=B5/d0dYFd1FDJzGz1brj7q5jisoA1NQt1KNM2tigFtPiMsl1kET7UJ79SX70qE9tNzp5Rs DWETbXaB+Ye8lYzOm26ngEkYFqATR8SNnNz47W5BODPSIirVzwBTcT81UFvF/kxEIghKcV jF6awM4U5REExI2f3MNwFb9ELoRmE24uqEJ7Urlc3IzWQe/wYu7JHLhlJyrQ82Jaamj9HF r8djUjsR+GNZb8W0h6sDsh7ws4xe9rqMVjOSgAHrsP3Lg648n6Nds0b0TisKfKqMtH3aaB FD1i/oszaQQ3HxWA0dl/hvgAOV2LidFkeEqmRa/aTpB7guk9OtU19lY2bjYBag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKX7T2gjGz1BcH for ; Wed, 04 Nov 2026 17:12:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22b5d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 17:12:37 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 36cd9f2ff331 - main - bnxt: avoid unintialized use of media_type in bnxt_add_media_types() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 36cd9f2ff3316e113eb2ed0c69b70695c0d9b9c8 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 17:12:37 +0000 Message-Id: <6aeb6785.22b5d.6fc5a0ea@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=36cd9f2ff3316e113eb2ed0c69b70695c0d9b9c8 commit 36cd9f2ff3316e113eb2ed0c69b70695c0d9b9c8 Author: Andrew Gallatin AuthorDate: 2026-11-04 17:01:50 +0000 Commit: Andrew Gallatin CommitDate: 2026-11-04 17:12:14 +0000 bnxt: avoid unintialized use of media_type in bnxt_add_media_types() When 5e6e4f752833 landed, it inadvertently allowed unsupported / unknown phys with a valid link_info->sig_mode to use media_type uninitialized. Fix this by returning from those cases that do not assign a media_type so as to avoid using it uninitialized. Reported by: imp (forwarding an llm's post-commit review of previous changes to this file) Fixes: 5e6e4f752833 Reviewed by: imp, kbowling, sumit.saxena_broadcom.com Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D61164 --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index adbe36447683..c0d271a99924 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -5526,12 +5526,12 @@ bnxt_add_media_types(struct bnxt_softc *softc) case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_UNKNOWN: /* Only Autoneg is supported for TYPE_UNKNOWN */ - break; + return; default: /* Only Autoneg is supported for new phy type values */ device_printf(softc->dev, "phy type %d not supported by driver\n", phy_type); - break; + return; } switch (link_info->sig_mode) {