From nobody Wed Nov 04 17:12:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKX7S2bXdz6yX08 for ; Wed, 04 Nov 2026 17:12:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKX7S1ycNz4vHv for ; Wed, 04 Nov 2026 17:12:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793812356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B8hXlP2aJ2+Edeh7dWrvE9yhj3K1JVIkb7dd58sf7mg=; b=IxWxLEWu+aW3dznhtOPTqB5ZUkvbwYp/vGAxyMrZNP7GHS+cUtoBISmZU3NcOxVtACR/f/ n3w8jCmE0lL3wvOrSfIvRP1UFFuLaRE9IxNJ2vmSdk+/JMclTB7ne4GMSsDBmHuZMQzAZ1 gBnNReWwczO6q5d06HETgtM7EN/SjsiDIvgbfe3jEqP0sOcyvG3Tvf1XAG6TkZgiNpD6Sj BX7EU2y4UE8YnFb6LiVu85SjgNnJoOWd2U62eqKyAjMNsCDfl66KrFrfDlVI1NNKsokDs0 vC5qbcQlBkdbYmKTN3KWvxOrF3uKi+/0EsJixvXpybAw9a06jAMAXCdlKPB3pA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793812356; b=Ec0AaWT6H71PRe0LI4qEQcDC0UvEeZJNv6hhV86Vl+JAHAoTDxMhXECpm1ZDYHvf8dus5g 8Hb5XD109KHkvuT/ajrJaK9BS/MoLCHjGNOtB4yU2MLaaCOcUFypghcpx5dnIRU/eGjUCo Y48RLyrj1hL/CgFKacG9HQkDfkajFdCNuVLEqRv2LNQ0R8TUGHEu6uhhdaaPcUhlE9p2mK 2MI9NWUMfjnKq8ovs1DH6T3hmtAEZZwXu/5lh7SGCS4waKT6UeI1UXWksqnAq314pLFPYP kbkmG3y3Y5ComqoUvm9VPjGlNtOvy85P9vAefrbbQKIvTwN4+SMoF8OdRXJGcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793812356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B8hXlP2aJ2+Edeh7dWrvE9yhj3K1JVIkb7dd58sf7mg=; b=q7xsR7xh2WGmR+AhfQFZXrntv1dSFy+4nBMo7kWzPBU3DUQFviCCkV0CweoT6dJR0gvclK okgQ1UFQaPOBdR8LT4Q932ytd2XTebF8Cq++IdjMjmD1Q4VqjmXM+dmKAswBQy/MdemvL8 6mD1FFk+w0zMeDY2ibypdtodpKkmLUW7MOkLm8hAPzbJKgwE0NAfHmFQ5A5caWBaWisn4j qVh7toG8k1pVlH1eafkLqexj3w6eRqgNu+tlkoWGyxDTIJJccataNNRz6ZYa5wu+jbiG93 DqQZupW4FrF+Wk878kDtlzJApJq7n90Iqbu3iP6nxST4bpd2DJlMGIlCJIf0gw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKX7S1d0Mz1Bl3 for ; Wed, 04 Nov 2026 17:12:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25413 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 17:12:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: d1695bbd48cc - main - iflib: prefer simple_tx over mp_ring List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d1695bbd48ccef6cd922be5fc089345954e87e42 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 17:12:36 +0000 Message-Id: <6aeb6784.25413.7f27d3d1@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=d1695bbd48ccef6cd922be5fc089345954e87e42 commit d1695bbd48ccef6cd922be5fc089345954e87e42 Author: Andrew Gallatin AuthorDate: 2026-11-04 16:56:04 +0000 Commit: Andrew Gallatin CommitDate: 2026-11-04 17:12:14 +0000 iflib: prefer simple_tx over mp_ring In preparation for removing mp_ring, enable simple_tx by default. Users encountering bugs are still able to set the tunable: net.iflib.prefer_mpring="1" at boot, but are encouraged to report any regressions so they can be fixed. My plan is to remove mp_ring assuming no major bugs are found in simple_tx after a month or two. Reviewed by: kbowling, netchild, rcm Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D61166 --- share/man/man4/iflib.4 | 4 ++-- sys/net/iflib.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/share/man/man4/iflib.4 b/share/man/man4/iflib.4 index 2a752871d9a8..e5b45304e913 100644 --- a/share/man/man4/iflib.4 +++ b/share/man/man4/iflib.4 @@ -1,4 +1,4 @@ -.Dd September 16, 2026 +.Dd November 4, 2026 .Dt IFLIB 4 .Os .Sh NAME @@ -156,7 +156,7 @@ is loaded. An explicitly configured per-device .Va simple_tx value takes precedence. -The default is one. +The default is zero. .It Va net.iflib.simple_drain_quota Sets the maximum number of packets that the transmit task may remove from a simple transmit deferral ring in one drain operation. diff --git a/sys/net/iflib.c b/sys/net/iflib.c index 6682ccbcfca8..77bcedf329eb 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -704,7 +704,7 @@ static int iflib_simple_txbr_size = IFLIB_SIMPLE_TXBR_SIZE; SYSCTL_INT(_net_iflib, OID_AUTO, simple_txbr_size, CTLFLAG_RDTUN, &iflib_simple_txbr_size, 0, "number of entries in the simple tx deferral ring"); -static bool iflib_prefer_mpring = true; +static bool iflib_prefer_mpring = false; SYSCTL_BOOL(_net_iflib, OID_AUTO, prefer_mpring, CTLFLAG_RDTUN, &iflib_prefer_mpring, 0, "prefer the mp_ring transmit path by default");