From nobody Wed Nov 04 16:53:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKWjz3zz7z6yTgc for ; Wed, 04 Nov 2026 16:53:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKWjz37RTz4pQq for ; Wed, 04 Nov 2026 16:53:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793811239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GC9AYmEBV43lJqaGfXbw7rNgkPMKQzRxM7o6B2w9MXQ=; b=HBt3KOqtkAoQKMe4xLT2D+aPUqMTG5P4vGVz0DZKn34hZDyCOtKZUykozlpNAQhvf7w0d7 NOTWiNMGQRVDZJFWfxyZ1fnHQox2qVwKGpidI1odVFUIV3VwGWfnVMPR2JWeO44eDHPkS0 lmgb6UvEmBRkJ71AJtdNJ/n5wwk5muajCKddlzXGnvsBRpmxeyRn68txJH3e+Kgws22nNL NySWswAC5vBSgcnYVHXtZYRyh8mzsNwXBK7t554QfZ9GXWigQ0BqbgppYJNqVRdNl7IPF3 7UG2A6FDu+MgZ77a2eWiS//am210JAC4nRPfHJUL/zBD8WT7rONfIQHVNiH1sg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793811239; b=V16sfoQbBI45jgWd1knreLMv34la0e1+NWcEy91la09c3XjzTyuw1hPcVOmpmpeL30812J tmYdgLmez9EKlird/v2nOnSbaRcNbmIdBjf36a5E2wXp9NL6134W1VBYOqW1j+ODpzXgkI 16X2aHf0XFQd6JcQPKw9RAtHBRAhzeggSM2Od3jzLI3cxw515DQW7Ys7AcyiGKsbtxgspl kq859Pg0WBKSry8sco1tkJr31suxvvrCD+7YYh4p3F4rVz5DZeB2kPpW3QqpLEb6aRlKQT hFiUY181OefCzZhVFqimMifd2Az8awrk6hgfHv7SDIjf/uHywZ/McWag/jHk5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793811239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GC9AYmEBV43lJqaGfXbw7rNgkPMKQzRxM7o6B2w9MXQ=; b=AY+xT2bz+kT9hQI9N3jW0PGxHA/CuPcI9FOoEJmwmRoLI0QVJElj9gbb8quzw6PJzJomm0 82ib/nf30C7FYg3cACA2pROXrjFhIu9PB/HiJsh+OyNLk4vt3x0F9ZyQCqzwVYocCaodH4 /fqFZQK9P+Sh4YE0iFad67UsSjga8VP6tmV7WAU6X/sUjLE26h6NQ1agMU52b+ALusYkxL EX7C2TExIFMm2QZLkpZDapkcbcTjmM8hqTreZ3RyLPTc4LVEb5GEdvJSnNNm2/L0G+TKhl Xxf81WVEpxsq481zD8CDFdLsrHHeKOYENt9aJ8m/mYY2FIowfEgYSzrh+NtiLw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKWjz2jlVz1B6v for ; Wed, 04 Nov 2026 16:53:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2086b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 16:53:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Osvaldo Janeri Filho From: Bojan Novk=?utf-8?Q?ovi=C4=87?= Subject: git: d67c363e85e7 - main - bhyve: check paddr_guest2host return in _vq_record List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bnovkov X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d67c363e85e7c720b1e0ac16e30cb64317c0dc2f Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 16:53:54 +0000 Message-Id: <6aeb6322.2086b.71237bf5@gitrepo.freebsd.org> The branch main has been updated by bnovkov: URL: https://cgit.FreeBSD.org/src/commit/?id=d67c363e85e7c720b1e0ac16e30cb64317c0dc2f commit d67c363e85e7c720b1e0ac16e30cb64317c0dc2f Author: Osvaldo Janeri Filho AuthorDate: 2026-11-04 16:11:02 +0000 Commit: Bojan Novković CommitDate: 2026-11-04 16:53:03 +0000 bhyve: check paddr_guest2host return in _vq_record _vq_record() stored the result of paddr_guest2host() without checking for NULL. A guest descriptor with an invalid address causes a NULL dereference in every virtio driver. Return early on failure; the caller sees zero descriptors and discards the chain. The indirect path already performs this check (line 357). Reviewed by: bnovkov Differential Revision: https://reviews.freebsd.org/D60870 MFC after: 1 week --- usr.sbin/bhyve/virtio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/usr.sbin/bhyve/virtio.c b/usr.sbin/bhyve/virtio.c index c0122238b457..f1b0e41d21df 100644 --- a/usr.sbin/bhyve/virtio.c +++ b/usr.sbin/bhyve/virtio.c @@ -48,6 +48,8 @@ #endif #include "virtio.h" +#define WPRINTF(params) PRINTLN params + /* * Functions for dealing with generalized "virtual devices" as * defined by @@ -230,6 +232,11 @@ _vq_record(int i, struct vring_desc *vd, struct vmctx *ctx, struct iovec *iov, addr = atomic_load_64(&vd->addr); iov[i].iov_len = len; iov[i].iov_base = paddr_guest2host(ctx, addr, len); + if (iov[i].iov_base == NULL) { + WPRINTF(("%s: invalid guest address 0x%lx len %u\n", + __func__, addr, len)); + return; + } if ((vd->flags & VRING_DESC_F_WRITE) == 0) reqp->readable++; else