From nobody Wed Nov 04 13:25:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKR5B3ntnz6ymNH for ; Wed, 04 Nov 2026 13:25:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKR5B0qrnz3LjF for ; Wed, 04 Nov 2026 13:25:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793798718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H3a3Nrtr7CG0pbKl+0ldRy1ySpZaRK6en+QUF/T69uY=; b=bV+IwLovMWDhPUQ/xjmahyhluNhEw7uTOi6uxdrrm9pMinWZyK8pJy2OKUFLUL7hsJdgUB tdmowe0usGJwxFvpxSt4j0j1TKsXFOziq/EOBiCJsbqC1HMpst3yuYxXczN2s6SZvTqlWS lTBssJiz43SZv11HE6QkMiZ2Dfw04laXFkLG+N4H/JqcWKwdFKJeXVoSC79aEnqm5pIJRu R+FVa1g4ag1f9z7q3g4L0N3MNBJ036vtguNaUcM1RMUYIU2gCaVSDUY+NkpMVqr+xcfKbC z7Itq5Ly4Ur9bnplZhe25R4XOirW2tSgv7ywy7YaqksBxkynRRsONQjAD/wx7g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793798718; b=AsrMsWKCMLLcWze2lIm22CTvR5XBoJcYELKU+XQsQDwDFr4fnqnRzsbpV6LgCOo0blr63F WEAwbGH7zRAB9fOpBjmA6Jf7PKyW71ih8bnpt71EI1BYfe72WCGESz7bHo9zduq+nvuVZH WbbKPmHCf6M3YeGEzrKopVigeTOcVa70LLxpwMnyzakI5dbRWvcCfq+4K4iI7RMcGa8FP9 fyGlb2ThW4xry/PVRzF2i02bjm+KSmLdIXD9xQs5WoZT6WGJaf3V5+YONoWRwU8vqh5rMD Tb3l8fltuAvDcDbeYl6/+05nyCg6l9d9RJByK9j2QRyKFs3R3jyemjtSH3EUiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793798718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H3a3Nrtr7CG0pbKl+0ldRy1ySpZaRK6en+QUF/T69uY=; b=PuwoSNxaOlWQi+zB91YZbdlZxq5trcClfwzv+BAwMdxFP1TeyQiOUFbZvTWFLvSzHg1j2V 2vmlryBNFCog0EPluTwLe3NK7uXrvWmu07MagHYElBTsRpdQbrTCLlMkvT1L+2DVkX4RrJ 1qtsjtv88C3MD8la+iN+/YC2EzC3R6IOmcHVE1mBs8Gl5R2nMBD9w/s8GwzC4Cx2OIePxC 2BN6ZrmqEYOZXu4IS6yaNh3bXjBls4EcfwmtS29kfkWDakPE6HEwcsYZvIH4dl1W9bc02Q gphiD8V58H08efzy8cWMRexlln5kQoEl77N82jIB4JYEVNcP4ui81lB1wP8ovA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKR5B0VBvz14Qd for ; Wed, 04 Nov 2026 13:25:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c0b7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 13:25:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 52fd2aabb772 - stable/15 - powerpc: powerpc_ipi_handler(): Stop first, preempt last List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 52fd2aabb7726521e81f620d98a4c8d8c5a784fe Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 13:25:18 +0000 Message-Id: <6aeb323e.3c0b7.50a6209b@gitrepo.freebsd.org> The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=52fd2aabb7726521e81f620d98a4c8d8c5a784fe commit 52fd2aabb7726521e81f620d98a4c8d8c5a784fe Author: Olivier Certner AuthorDate: 2026-10-17 17:38:59 +0000 Commit: Olivier Certner CommitDate: 2026-11-04 13:21:38 +0000 powerpc: powerpc_ipi_handler(): Stop first, preempt last Preemption should happen last so that other IPIs have a chance to be executed in due course, in particular hardclockintr(). So, move handling of IPI_PREEMPT at the end. An IPI_STOP/IPI_STOP_HARD request should be processed immediately to avoid risks that further processing changes the system state on panic, or worse itself causes another panic on corrupted kernel state. While here, move IPI_AST handling just before IPI_PREEMPT. We currently do not need to do anything for it, but if we were to, it is likely that would have to happen after other IPIs but IPI_PREEMPT. Reviewed by: jhibbits Fixes: 9d5a22b928c2 ("MFp4: SMP support") Fixes: 12640815f815 ("MFp4: SMP support") Fixes: 7ed09a6778d3 ("powerpc: Rework IPI message processing") MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60863 (cherry picked from commit 07ab87b60d08c665eab0b187e81a239145f9961d) --- sys/powerpc/powerpc/mp_machdep.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/sys/powerpc/powerpc/mp_machdep.c b/sys/powerpc/powerpc/mp_machdep.c index d6d140aa0ea2..ce0557c28d5a 100644 --- a/sys/powerpc/powerpc/mp_machdep.c +++ b/sys/powerpc/powerpc/mp_machdep.c @@ -301,17 +301,7 @@ powerpc_ipi_handler(void *arg) ipimask = atomic_readandclear_32(&(pcpup->pc_ipimask)); if (ipimask == 0) return (FILTER_STRAY); - if (ipimask & (1 << IPI_AST)) { - CTR1(KTR_SMP, "%s: IPI_AST", __func__); - } - if (ipimask & (1 << IPI_PREEMPT)) { - CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__); - sched_preempt(curthread); - } - if (ipimask & (1 << IPI_RENDEZVOUS)) { - CTR1(KTR_SMP, "%s: IPI_RENDEZVOUS", __func__); - smp_rendezvous_action(); - } + /* A stop request should not be delayed. Keep it first. */ if (ipimask & (1 << IPI_STOP)) { /* @@ -329,10 +319,26 @@ powerpc_ipi_handler(void *arg) CPU_CLR_ATOMIC(cpuid, &started_cpus); CTR1(KTR_SMP, "%s: IPI_STOP (restart)", __func__); } + if (ipimask & (1 << IPI_RENDEZVOUS)) { + CTR1(KTR_SMP, "%s: IPI_RENDEZVOUS", __func__); + smp_rendezvous_action(); + } if (ipimask & (1 << IPI_HARDCLOCK)) { CTR1(KTR_SMP, "%s: IPI_HARDCLOCK", __func__); hardclockintr(); } + if (ipimask & (1 << IPI_AST)) { + CTR1(KTR_SMP, "%s: IPI_AST", __func__); + } + /* + * sched_preempt() causes an immediate switch to another thread when not + * executing in a critical section. In order to ensure that all other + * IPIs are processed in due course, it has to be called last. + */ + if (ipimask & (1 << IPI_PREEMPT)) { + CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__); + sched_preempt(curthread); + } return (FILTER_HANDLED); }